From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Ho Subject: [OSSTest Nested v12 18/21] After Xen install, configure its xenbr0 interface as dhcp. Date: Fri, 28 Aug 2015 23:08:07 +0800 Message-ID: <1440774490-16725-19-git-send-email-robert.hu@intel.com> References: <1440774490-16725-1-git-send-email-robert.hu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1440774490-16725-1-git-send-email-robert.hu@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org, robert.hu@intel.com Cc: wei.liu2@citrix.com, Ian.Jackson@eu.citrix.com, ian.campbell@citrix.com, di.zheng@intel.com, gordon.jin@intel.com List-Id: xen-devel@lists.xenproject.org This is more idiomatic because, even if host is fixed IP in DHCP server side, client side shall still be dhcp mode, rather than fixed self. And if it is not configured fixed in DHCP server side, it shall more necessarily use dhcp mode. This applies for both nested test and other test cases. Signed-off-by: Robert Ho --- ts-xen-install | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ts-xen-install b/ts-xen-install index e039173..6d04982 100755 --- a/ts-xen-install +++ b/ts-xen-install @@ -303,10 +303,7 @@ END if (m/^\s* iface \s+ (?: $physif | xenbr0 ) \s+ inet \s /x) { $suppress= 1; print EO <{Ip} - netmask $netmask - gateway $gateway +iface $iface inet dhcp $bridgex END } -- 1.8.3.1