All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Lieven <pl@kamp.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] vnc: destroy server surface if no client is connected
Date: Thu, 03 Sep 2015 12:54:25 +0200	[thread overview]
Message-ID: <1441277665.557.48.camel@redhat.com> (raw)
In-Reply-To: <55E81C09.9020504@kamp.de>

On Do, 2015-09-03 at 12:08 +0200, Peter Lieven wrote:
> Am 03.09.2015 um 11:57 schrieb Gerd Hoffmann:
> > On Do, 2015-08-27 at 12:18 +0200, Peter Lieven wrote:
> >> if no client is connected there is no need to keep the server
> >> surface. Throw it away and replace it with a dummy surface to
> >> save memory.
> > No dummy surface please.  Just set vd->server = NULL.
> 
> I can do that, but I have to check for vd->server == NULL at some points then.

Sure.  That'll shortcut code paths which should not have any effect
anyway.  You probably also want factor out server surface initialization
into a function which is called for both first vnc connect and surface
changes.

Oh, and btw: in case the surface changes without resolution/depth
changing (guest page flip) we might simply skip surface
(re-)initialization.

cheers,
  Gerd

      reply	other threads:[~2015-09-03 10:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 10:18 [Qemu-devel] [PATCH 0/4] VNC server memory savings Peter Lieven
2015-08-27 10:18 ` [Qemu-devel] [PATCH 1/4] vnc: make the Buffer capacity increase in powers of two Peter Lieven
2015-09-03  8:56   ` Gerd Hoffmann
2015-09-03 10:29     ` Peter Lieven
2015-09-03 10:47       ` Gerd Hoffmann
2015-08-27 10:18 ` [Qemu-devel] [PATCH 2/4] vnc: allow the Buffer to shrink again Peter Lieven
2015-08-27 10:39   ` Daniel P. Berrange
2015-08-27 12:36     ` Peter Lieven
2015-09-03  9:52     ` Gerd Hoffmann
2015-09-03 10:07       ` Peter Lieven
2015-09-03 11:52         ` Gerd Hoffmann
2015-09-03 14:52           ` Peter Lieven
2015-09-03 10:36       ` Peter Lieven
2015-09-03 11:57         ` Gerd Hoffmann
2015-09-03 12:00           ` Peter Lieven
2015-08-27 10:18 ` [Qemu-devel] [PATCH 3/4] vnc-jobs: move buffer_reset to vnc_async_encoding_end Peter Lieven
2015-08-27 10:18 ` [Qemu-devel] [PATCH 4/4] vnc: destroy server surface if no client is connected Peter Lieven
2015-09-03  9:57   ` Gerd Hoffmann
2015-09-03 10:08     ` Peter Lieven
2015-09-03 10:54       ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441277665.557.48.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.