All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dimitri Sivanich <sivanich@sgi.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH v2 3/5] drivers/misc/sgi-gru: remove always false condition
Date: Thu,  3 Sep 2015 20:20:49 +0530	[thread overview]
Message-ID: <1441291851-29411-3-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1441291851-29411-1-git-send-email-sudipm.mukherjee@gmail.com>

The member gid in struct gru_dump_chiplet_state_req is unsigned int. So
it can never be less than 0.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Acked-by: Dimitri Sivanich <sivanich@sgi.com>
---

v2: no change, sent as a part of the series.

 drivers/misc/sgi-gru/grukdump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c
index 7e9aae5..313da31 100644
--- a/drivers/misc/sgi-gru/grukdump.c
+++ b/drivers/misc/sgi-gru/grukdump.c
@@ -194,7 +194,7 @@ int gru_dump_chiplet_request(unsigned long arg)
 		return -EFAULT;
 
 	/* Currently, only dump by gid is implemented */
-	if (req.gid >= gru_max_gids || req.gid < 0)
+	if (req.gid >= gru_max_gids)
 		return -EINVAL;
 
 	gru = GID_TO_GRU(req.gid);
-- 
1.9.1


  parent reply	other threads:[~2015-09-03 14:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-03 14:50 [PATCH v2 1/5] drivers/misc/sgi-gru: add return on error Sudip Mukherjee
2015-09-03 14:50 ` [PATCH v2 2/5] drivers/misc/sgi-gru: make functions static Sudip Mukherjee
2015-09-03 14:50 ` Sudip Mukherjee [this message]
2015-09-03 14:50 ` [PATCH v2 4/5] drivers/misc/sgi-gru: fix dereference of ERR_PTR Sudip Mukherjee
2015-09-03 18:45   ` Dimitri Sivanich
2015-09-04  4:26   ` [PATCH v3] " Sudip Mukherjee
2015-09-04 12:56     ` Dimitri Sivanich
2015-09-03 14:50 ` [PATCH v2 5/5] drivers/misc/sgi-gru: remove unused variable Sudip Mukherjee
2015-09-03 18:22   ` Dimitri Sivanich
2015-09-03 18:21 ` [PATCH v2 1/5] drivers/misc/sgi-gru: add return on error Dimitri Sivanich
2015-09-15  7:50   ` Sudip Mukherjee
2015-09-21  2:26     ` Greg Kroah-Hartman
2015-09-21  5:34       ` Sudip Mukherjee
2015-09-21  5:36         ` Greg Kroah-Hartman
2015-09-21  6:53           ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441291851-29411-3-git-send-email-sudipm.mukherjee@gmail.com \
    --to=sudipm.mukherjee@gmail.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sivanich@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.