From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757270AbbICSfD (ORCPT ); Thu, 3 Sep 2015 14:35:03 -0400 Received: from smtprelay0237.hostedemail.com ([216.40.44.237]:36032 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753881AbbICSfA (ORCPT ); Thu, 3 Sep 2015 14:35:00 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:152:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1543:1593:1594:1711:1730:1747:1777:1792:1801:2197:2198:2199:2200:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3355:3622:3653:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4321:4605:5007:6119:6261:7903:8603:8957:9010:9707:10004:10044:10400:10848:11026:11232:11473:11658:11914:12043:12295:12296:12438:12517:12519:12555:12663:12679:12740:13894:21080:21221,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: back66_2b51e6e1fb238 X-Filterd-Recvd-Size: 4611 Message-ID: <1441305296.9666.14.camel@perches.com> Subject: Re: [GIT] Networking From: Joe Perches To: Linus Torvalds , Julia Lawall Cc: David Miller , Lorenzo Bianconi , Johannes Berg , Andrew Morton , Network Development , Linux Kernel Mailing List Date: Thu, 03 Sep 2015 11:34:56 -0700 In-Reply-To: References: <20150902.223522.1792493140210966693.davem@davemloft.net> <20150903.104032.767889134756094076.davem@davemloft.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-09-03 at 11:22 -0700, Linus Torvalds wrote: > On Thu, Sep 3, 2015 at 10:40 AM, David Miller wrote: > > > > Linus, what GCC version are you using and what does the warning look > > like? > > I'm on whatever is in F22. gcc -v says > > gcc version 5.1.1 20150618 (Red Hat 5.1.1-4) (GCC) > > and the warning looks like so: > > net/mac80211/rate.c: In function ‘rate_control_cap_mask’: > net/mac80211/rate.c:719:25: warning: ‘sizeof’ on array function > parameter ‘mcs_mask’ will return size of ‘u8 * {aka unsigned char *}’ > [-Wsizeof-array-argument] > for (i = 0; i < sizeof(mcs_mask); i++) > ^ > > (note the lack of warning about the use of an array in the function > definition parameter list - I tried to find if there's any way to > enable such a warning, but couldn't find anything. Maybe my google-fu > is weak, but more probably that just doesn't exist). Coccinelle might be a better tool for this but a possible checkpatch patch is below: It produces output like: $ ./scripts/checkpatch.pl -f net/iucv/iucv.c --types=sized_array_argument WARNING: Avoid sized array arguments #716: FILE: net/iucv/iucv.c:716: +static int iucv_sever_pathid(u16 pathid, u8 userdata[16]) +{ WARNING: Avoid sized array arguments #878: FILE: net/iucv/iucv.c:878: +int iucv_path_accept(struct iucv_path *path, struct iucv_handler *handler, + u8 userdata[16], void *private) +{ WARNING: Avoid sized array arguments #925: FILE: net/iucv/iucv.c:925: +int iucv_path_connect(struct iucv_path *path, struct iucv_handler *handler, + u8 userid[8], u8 system[8], u8 userdata[16], + void *private) +{ WARNING: Avoid sized array arguments #988: FILE: net/iucv/iucv.c:988: +int iucv_path_quiesce(struct iucv_path *path, u8 userdata[16]) +{ WARNING: Avoid sized array arguments #1020: FILE: net/iucv/iucv.c:1020: +int iucv_path_resume(struct iucv_path *path, u8 userdata[16]) +{ WARNING: Avoid sized array arguments #1050: FILE: net/iucv/iucv.c:1050: +int iucv_path_sever(struct iucv_path *path, u8 userdata[16]) +{ total: 0 errors, 6 warnings, 0 checks, 2119 lines checked --- scripts/checkpatch.pl | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index e14dcdb..747b164 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -5422,6 +5422,24 @@ sub process { "externs should be avoided in .c files\n" . $herecurr); } +# check for function arguments using arg[SIZE] + if ($^V && $^V ge 5.10.0 && + defined $stat && + $stat =~ /^.\s*(?:$Declare|$DeclareMisordered)\s*$Ident\s*($balanced_parens)\s*\{/s) { + my $func_args = $1; + if ($func_args =~ /(.*)\[\s*(?:$Constant|[A-Z0-9_]+)\s*\]/ && (!defined($1) || $1 !~ /\[\s*\]\s*$/)) { + my $ctx = ''; + my $herectx = $here . "\n"; + my $cnt = statement_rawlines($stat); + for (my $n = 0; $n < $cnt; $n++) { + $herectx .= raw_line($linenr, $n) . "\n"; + $n = $cnt if ($herectx =~ /{/); + } + WARN("SIZED_ARRAY_ARGUMENT", + "Avoid sized array arguments\n" . $herectx); + } + } + # checks for new __setup's if ($rawline =~ /\b__setup\("([^"]*)"/) { my $name = $1;