* [PATCH] acpi-dma: Use ACPI_COMPANION() instead of acpi_bus_get_device()
@ 2015-09-04 13:12 Jarkko Nikula
2015-09-15 0:18 ` Rafael J. Wysocki
2015-09-30 6:52 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Jarkko Nikula @ 2015-09-04 13:12 UTC (permalink / raw)
To: dmaengine; +Cc: Dan Williams, Vinod Koul, linux-acpi, Jarkko Nikula
Get pointer to the struct acpi_device by using ACPI_COMPANION() macro. This
is more efficient than using ACPI_HANDLE() and acpi_bus_get_device().
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
drivers/dma/acpi-dma.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/dma/acpi-dma.c b/drivers/dma/acpi-dma.c
index 5a635646e05c..04257432c482 100644
--- a/drivers/dma/acpi-dma.c
+++ b/drivers/dma/acpi-dma.c
@@ -160,10 +160,8 @@ int acpi_dma_controller_register(struct device *dev,
return -EINVAL;
/* Check if the device was enumerated by ACPI */
- if (!ACPI_HANDLE(dev))
- return -EINVAL;
-
- if (acpi_bus_get_device(ACPI_HANDLE(dev), &adev))
+ adev = ACPI_COMPANION(dev);
+ if (!adev)
return -EINVAL;
adma = kzalloc(sizeof(*adma), GFP_KERNEL);
@@ -358,10 +356,11 @@ struct dma_chan *acpi_dma_request_slave_chan_by_index(struct device *dev,
int found;
/* Check if the device was enumerated by ACPI */
- if (!dev || !ACPI_HANDLE(dev))
+ if (!dev)
return ERR_PTR(-ENODEV);
- if (acpi_bus_get_device(ACPI_HANDLE(dev), &adev))
+ adev = ACPI_COMPANION(dev);
+ if (!adev)
return ERR_PTR(-ENODEV);
memset(&pdata, 0, sizeof(pdata));
--
2.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] acpi-dma: Use ACPI_COMPANION() instead of acpi_bus_get_device()
2015-09-04 13:12 [PATCH] acpi-dma: Use ACPI_COMPANION() instead of acpi_bus_get_device() Jarkko Nikula
@ 2015-09-15 0:18 ` Rafael J. Wysocki
2015-09-30 6:52 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2015-09-15 0:18 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: dmaengine, Dan Williams, Vinod Koul, linux-acpi
On Friday, September 04, 2015 04:12:30 PM Jarkko Nikula wrote:
> Get pointer to the struct acpi_device by using ACPI_COMPANION() macro. This
> is more efficient than using ACPI_HANDLE() and acpi_bus_get_device().
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/dma/acpi-dma.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/dma/acpi-dma.c b/drivers/dma/acpi-dma.c
> index 5a635646e05c..04257432c482 100644
> --- a/drivers/dma/acpi-dma.c
> +++ b/drivers/dma/acpi-dma.c
> @@ -160,10 +160,8 @@ int acpi_dma_controller_register(struct device *dev,
> return -EINVAL;
>
> /* Check if the device was enumerated by ACPI */
> - if (!ACPI_HANDLE(dev))
> - return -EINVAL;
> -
> - if (acpi_bus_get_device(ACPI_HANDLE(dev), &adev))
> + adev = ACPI_COMPANION(dev);
> + if (!adev)
> return -EINVAL;
>
> adma = kzalloc(sizeof(*adma), GFP_KERNEL);
> @@ -358,10 +356,11 @@ struct dma_chan *acpi_dma_request_slave_chan_by_index(struct device *dev,
> int found;
>
> /* Check if the device was enumerated by ACPI */
> - if (!dev || !ACPI_HANDLE(dev))
> + if (!dev)
> return ERR_PTR(-ENODEV);
>
> - if (acpi_bus_get_device(ACPI_HANDLE(dev), &adev))
> + adev = ACPI_COMPANION(dev);
> + if (!adev)
> return ERR_PTR(-ENODEV);
>
> memset(&pdata, 0, sizeof(pdata));
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] acpi-dma: Use ACPI_COMPANION() instead of acpi_bus_get_device()
2015-09-04 13:12 [PATCH] acpi-dma: Use ACPI_COMPANION() instead of acpi_bus_get_device() Jarkko Nikula
2015-09-15 0:18 ` Rafael J. Wysocki
@ 2015-09-30 6:52 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2015-09-30 6:52 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: dmaengine, Dan Williams, linux-acpi
On Fri, Sep 04, 2015 at 04:12:30PM +0300, Jarkko Nikula wrote:
> Get pointer to the struct acpi_device by using ACPI_COMPANION() macro. This
> is more efficient than using ACPI_HANDLE() and acpi_bus_get_device().
Applied aftre fixing the right subsystem name. Please ensure you send
patches with right tags
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-30 6:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-04 13:12 [PATCH] acpi-dma: Use ACPI_COMPANION() instead of acpi_bus_get_device() Jarkko Nikula
2015-09-15 0:18 ` Rafael J. Wysocki
2015-09-30 6:52 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.