From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA13CFA372A for ; Thu, 17 Oct 2019 16:54:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A6A020872 for ; Thu, 17 Oct 2019 16:54:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440534AbfJQQyz convert rfc822-to-8bit (ORCPT ); Thu, 17 Oct 2019 12:54:55 -0400 Received: from mailoutvs57.siol.net ([185.57.226.248]:49257 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732079AbfJQQyz (ORCPT ); Thu, 17 Oct 2019 12:54:55 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 3DE9E52402E; Thu, 17 Oct 2019 18:54:52 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta11.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta11.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id D6UzhXF7HyCW; Thu, 17 Oct 2019 18:54:51 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id DCFF2524BFA; Thu, 17 Oct 2019 18:54:51 +0200 (CEST) Received: from jernej-laptop.localnet (cpe-86-58-59-25.static.triera.net [86.58.59.25]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id 8A3395247E3; Thu, 17 Oct 2019 18:54:51 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard Cc: wens@csie.org, robh+dt@kernel.org, mark.rutland@arm.com, mchehab@kernel.org, hverkuil@xs4all.nl, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v3 5/6] media: sun4i: Add H3 deinterlace driver Date: Thu, 17 Oct 2019 18:54:51 +0200 Message-ID: <14416618.qeK7XMoh1f@jernej-laptop> In-Reply-To: <20191017092800.old6jcyeoq3ruawv@gilmour> References: <20191016192807.1278987-1-jernej.skrabec@siol.net> <20191016192807.1278987-6-jernej.skrabec@siol.net> <20191017092800.old6jcyeoq3ruawv@gilmour> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne četrtek, 17. oktober 2019 ob 11:28:00 CEST je Maxime Ripard napisal(a): > Hi, > > I have a small comment that can definitely be addressed in a subsequent > patch > On Wed, Oct 16, 2019 at 09:28:06PM +0200, Jernej Skrabec wrote: > > + dev->bus_clk = devm_clk_get(dev->dev, "bus"); > > + if (IS_ERR(dev->bus_clk)) { > > + dev_err(dev->dev, "Failed to get bus clock\n"); > > + > > + return PTR_ERR(dev->bus_clk); > > + } > > + > > + dev->mod_clk = devm_clk_get(dev->dev, "mod"); > > + if (IS_ERR(dev->mod_clk)) { > > + dev_err(dev->dev, "Failed to get mod clock\n"); > > + > > + return PTR_ERR(dev->mod_clk); > > + } > > + > > + dev->ram_clk = devm_clk_get(dev->dev, "ram"); > > + if (IS_ERR(dev->ram_clk)) { > > + dev_err(dev->dev, "Failed to get ram clock\n"); > > + > > + return PTR_ERR(dev->ram_clk); > > + } > > + > > + dev->rstc = devm_reset_control_get(dev->dev, NULL); > > + if (IS_ERR(dev->rstc)) { > > + dev_err(dev->dev, "Failed to get reset control\n"); > > + > > + return PTR_ERR(dev->rstc); > > + } > > + > > + clk_set_rate_exclusive(dev->mod_clk, 300000000); > > clk_set_rate_exclusive puts a pretty big constraint on the clock tree, > and we shouldn't really enforce it if the device is unused. That is true in general, but as I said before, that is not really an issue for H3. Deinterlace clock default parent is peripheral clock, which is fixed to 600 MHz and doesn't change. > > I guess we should move it to the runtime_pm resume hook (with the > put_exclusive call in suspend). Ok, I'll move it in case that this deinterlace core is used on other SoCs with non-fixed parent clock. > > Otherwise, that patch is > Acked-by: Maxime Ripard Thanks! Best regards, Jernej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CD49FA372A for ; Thu, 17 Oct 2019 16:55:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FEAA20872 for ; Thu, 17 Oct 2019 16:55:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I1rb+/NT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FEAA20872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Jh2ook6wisnsAC5QRYRCKFOK0/zTcKtbYVeCT6/w4FU=; b=I1rb+/NTwR6gRb 13gKselOBMMi8Cq9E6d2TtyXVmjxuQp8O+Ktd3B+9CalYVUUBkkvl7Ywt+w0m8N+SZh3mH06HdOuo uThWON88PXnQaStBtdE3DsG9gKo5UHBrr8+7pfspZz7vuXtO4f4HJ2Bxu+eCfDzkxG8bqexwgUahG vO9eZcYJM6s4MPge/8nfAQ7rV7y3gRPBP7qRIXSwC/SZK8jIciA45+km/cmmeaIaoikjJ0r3+c2cL dTWU7WZBE9rldI+xU+jVV5ErzbxyqyDFFEfz1tdPol6kd8P3dvUFNxL8TwQBw3WvO8nbLuuJN1ITC xevcS8+tO7WnfX62rr8Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iL93B-0008Na-4z; Thu, 17 Oct 2019 16:54:57 +0000 Received: from mailoutvs28.siol.net ([185.57.226.219] helo=mail.siol.net) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iL938-0008N8-Ea for linux-arm-kernel@lists.infradead.org; Thu, 17 Oct 2019 16:54:55 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 3DE9E52402E; Thu, 17 Oct 2019 18:54:52 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta11.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta11.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id D6UzhXF7HyCW; Thu, 17 Oct 2019 18:54:51 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id DCFF2524BFA; Thu, 17 Oct 2019 18:54:51 +0200 (CEST) Received: from jernej-laptop.localnet (cpe-86-58-59-25.static.triera.net [86.58.59.25]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id 8A3395247E3; Thu, 17 Oct 2019 18:54:51 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard Subject: Re: [PATCH v3 5/6] media: sun4i: Add H3 deinterlace driver Date: Thu, 17 Oct 2019 18:54:51 +0200 Message-ID: <14416618.qeK7XMoh1f@jernej-laptop> In-Reply-To: <20191017092800.old6jcyeoq3ruawv@gilmour> References: <20191016192807.1278987-1-jernej.skrabec@siol.net> <20191016192807.1278987-6-jernej.skrabec@siol.net> <20191017092800.old6jcyeoq3ruawv@gilmour> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191017_095454_649458_269FA491 X-CRM114-Status: GOOD ( 11.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, hverkuil@xs4all.nl, wens@csie.org, robh+dt@kernel.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org RG5lIMSNZXRydGVrLCAxNy4gb2t0b2JlciAyMDE5IG9iIDExOjI4OjAwIENFU1QgamUgTWF4aW1l IFJpcGFyZCBuYXBpc2FsKGEpOgo+IEhpLAo+IAo+IEkgaGF2ZSBhIHNtYWxsIGNvbW1lbnQgdGhh dCBjYW4gZGVmaW5pdGVseSBiZSBhZGRyZXNzZWQgaW4gYSBzdWJzZXF1ZW50Cj4gcGF0Y2gKPiBP biBXZWQsIE9jdCAxNiwgMjAxOSBhdCAwOToyODowNlBNICswMjAwLCBKZXJuZWogU2tyYWJlYyB3 cm90ZToKPiA+ICsJZGV2LT5idXNfY2xrID0gZGV2bV9jbGtfZ2V0KGRldi0+ZGV2LCAiYnVzIik7 Cj4gPiArCWlmIChJU19FUlIoZGV2LT5idXNfY2xrKSkgewo+ID4gKwkJZGV2X2VycihkZXYtPmRl diwgIkZhaWxlZCB0byBnZXQgYnVzIGNsb2NrXG4iKTsKPiA+ICsKPiA+ICsJCXJldHVybiBQVFJf RVJSKGRldi0+YnVzX2Nsayk7Cj4gPiArCX0KPiA+ICsKPiA+ICsJZGV2LT5tb2RfY2xrID0gZGV2 bV9jbGtfZ2V0KGRldi0+ZGV2LCAibW9kIik7Cj4gPiArCWlmIChJU19FUlIoZGV2LT5tb2RfY2xr KSkgewo+ID4gKwkJZGV2X2VycihkZXYtPmRldiwgIkZhaWxlZCB0byBnZXQgbW9kIGNsb2NrXG4i KTsKPiA+ICsKPiA+ICsJCXJldHVybiBQVFJfRVJSKGRldi0+bW9kX2Nsayk7Cj4gPiArCX0KPiA+ ICsKPiA+ICsJZGV2LT5yYW1fY2xrID0gZGV2bV9jbGtfZ2V0KGRldi0+ZGV2LCAicmFtIik7Cj4g PiArCWlmIChJU19FUlIoZGV2LT5yYW1fY2xrKSkgewo+ID4gKwkJZGV2X2VycihkZXYtPmRldiwg IkZhaWxlZCB0byBnZXQgcmFtIGNsb2NrXG4iKTsKPiA+ICsKPiA+ICsJCXJldHVybiBQVFJfRVJS KGRldi0+cmFtX2Nsayk7Cj4gPiArCX0KPiA+ICsKPiA+ICsJZGV2LT5yc3RjID0gZGV2bV9yZXNl dF9jb250cm9sX2dldChkZXYtPmRldiwgTlVMTCk7Cj4gPiArCWlmIChJU19FUlIoZGV2LT5yc3Rj KSkgewo+ID4gKwkJZGV2X2VycihkZXYtPmRldiwgIkZhaWxlZCB0byBnZXQgcmVzZXQgY29udHJv bFxuIik7Cj4gPiArCj4gPiArCQlyZXR1cm4gUFRSX0VSUihkZXYtPnJzdGMpOwo+ID4gKwl9Cj4g PiArCj4gPiArCWNsa19zZXRfcmF0ZV9leGNsdXNpdmUoZGV2LT5tb2RfY2xrLCAzMDAwMDAwMDAp Owo+IAo+IGNsa19zZXRfcmF0ZV9leGNsdXNpdmUgcHV0cyBhIHByZXR0eSBiaWcgY29uc3RyYWlu dCBvbiB0aGUgY2xvY2sgdHJlZSwKPiBhbmQgd2Ugc2hvdWxkbid0IHJlYWxseSBlbmZvcmNlIGl0 IGlmIHRoZSBkZXZpY2UgaXMgdW51c2VkLgoKVGhhdCBpcyB0cnVlIGluIGdlbmVyYWwsIGJ1dCBh cyBJIHNhaWQgYmVmb3JlLCB0aGF0IGlzIG5vdCByZWFsbHkgYW4gaXNzdWUgZm9yIApIMy4gRGVp bnRlcmxhY2UgY2xvY2sgZGVmYXVsdCBwYXJlbnQgaXMgcGVyaXBoZXJhbCBjbG9jaywgd2hpY2gg aXMgZml4ZWQgdG8gNjAwIApNSHogYW5kIGRvZXNuJ3QgY2hhbmdlLgoKPiAKPiBJIGd1ZXNzIHdl IHNob3VsZCBtb3ZlIGl0IHRvIHRoZSBydW50aW1lX3BtIHJlc3VtZSBob29rICh3aXRoIHRoZQo+ IHB1dF9leGNsdXNpdmUgY2FsbCBpbiBzdXNwZW5kKS4KCk9rLCBJJ2xsIG1vdmUgaXQgaW4gY2Fz ZSB0aGF0IHRoaXMgZGVpbnRlcmxhY2UgY29yZSBpcyB1c2VkIG9uIG90aGVyIFNvQ3Mgd2l0aCAK bm9uLWZpeGVkIHBhcmVudCBjbG9jay4KCj4gCj4gT3RoZXJ3aXNlLCB0aGF0IHBhdGNoIGlzCj4g QWNrZWQtYnk6IE1heGltZSBSaXBhcmQgPG1yaXBhcmRAa2VybmVsLm9yZz4KClRoYW5rcyEKCkJl c3QgcmVnYXJkcywKSmVybmVqCgoKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=