From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34011)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bmT4i-0003To-Js
	for qemu-devel@nongnu.org; Tue, 20 Sep 2016 17:59:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bmT4d-0001mJ-2h
	for qemu-devel@nongnu.org; Tue, 20 Sep 2016 17:59:36 -0400
Received: from mx3-phx2.redhat.com ([209.132.183.24]:33284)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bmT4c-0001mD-PW
	for qemu-devel@nongnu.org; Tue, 20 Sep 2016 17:59:31 -0400
Date: Tue, 20 Sep 2016 17:58:48 -0400 (EDT)
From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <mlureau@redhat.com>
Message-ID: <1441973931.277653.1474408728887.JavaMail.zimbra@redhat.com>
In-Reply-To: <20160920144844.nzbpfrauczlml3a5@perseus.local>
References: <20160912091913.15831-1-marcandre.lureau@redhat.com>
	<20160912091913.15831-16-marcandre.lureau@redhat.com>
	<20160920144844.nzbpfrauczlml3a5@perseus.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v6 15/18] monitor: use qmp_dispatch()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>
Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org, eblake@redhat.com, armbru@redhat.com

Hi Alberto

----- Original Message -----
> On Mon, Sep 12, 2016 at 01:19:10PM +0400, Marc-Andr=C3=A9 Lureau wrote:
> > Replace the old manual dispatch and validation code by the generic one
> > provided by qapi common code.
> >=20
> > Note that it is now possible to call the following commands that used t=
o
> > be disabled by compile-time conditionals:
> > - dump-skeys
> > - query-spice
> > - rtc-reset-reinjection
> > - query-gic-capabilities
> >=20
> > Their fallback functions return an appropriate "feature disabled" error=
.
> >=20
> > Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>=20
> This patch breaks iotest 085 because the "missing parameter" error is
> now different:
>=20
> -{"error": {"class": "GenericError", "desc": "Parameter 'snapshot-file' i=
s
> missing"}}
> +{"error": {"class": "GenericError", "desc": "Invalid parameter type for
> 'snapshot-file', expected: string"}}
>=20
> I was thinking to update the expected output of the iotest, but I
> guess it's better to return a more meaningful error message?

The change is relatively easy (see attached patch), but there are other tes=
ts that expected the current error, see commit fe509ee237307843. I guess we=
 should decided with one, and I think missing parameter is more appropriate=
.