From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>
Subject: Re: [PATCH v10 11/20] x86/VPMU: Interface for setting
	PMU mode and flags
Date: Mon, 15 Sep 2014 15:35:58 +0200
Message-ID: <1442133.CSPYB6psEc@amur>
References: <1409802080-6160-1-git-send-email-boris.ostrovsky@oracle.com>
	<2128719.pvZ4uib3i5@amur> <54130242.6020507@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54130242.6020507@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: xen-devel@lists.xen.org
Cc: kevin.tian@intel.com, keir@xen.org, jbeulich@suse.com, andrew.cooper3@citrix.com, eddie.dong@intel.com, tim@xen.org, Aravind.Gopalakrishnan@amd.com, jun.nakajima@intel.com, Boris Ostrovsky <boris.ostrovsky@oracle.com>, suravee.suthikulpanit@amd.com
List-Id: xen-devel@lists.xenproject.org

Am Freitag 12 September 2014, 10:25:06 schrieb Boris Ostrovsky:
> On 09/12/2014 07:41 AM, Dietmar Hahn wrote:
> >
> > +
> > +    case XENPMU_feature_get:
> > +        memset(&pmu_params, 0, sizeof(pmu_params));
> > +        pmu_params.val = vpmu_mode;
> > Shouldn't this be:
> >
> >             pmu_params.val = vpmu_features;
> 
> Yes, it should. Thanks.
> 
> BTW, I am going to ask you to review the next version (v11) since Jan 
> requested that someone with knowledge in PMU area looks at it.

Sorry for the late reply but I'am very busy with company stuff.
I already saw Jan's comment and I'll have a look on your v11 and will do some
tests. Thanks.
Dietmar.

> 
> 
> Thanks.
> -boris
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
> 

-- 
Company details: http://ts.fujitsu.com/imprint.html