From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932243AbbIUNgS (ORCPT ); Mon, 21 Sep 2015 09:36:18 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:37352 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756847AbbIUNgN (ORCPT ); Mon, 21 Sep 2015 09:36:13 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-b4-560007cbaf1a From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Pawel Moll , Arnd Bergmann , Olof Johansson Subject: [PATCH 02/38] bus: arm-ccn: fix handling cpumask_any_but return value Date: Mon, 21 Sep 2015 15:33:34 +0200 Message-id: <1442842450-29769-3-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCLMWRmVeSWpSXmKPExsVy+t/xq7qn2RnCDF5MYre4te4cq8XfScfY LTbOWM9qcXnXHDaLtUfuslucuv6ZzWLC9LUsDuwea+atYfT4/WsSo8eVE02sHn1bVjF6fN4k F8AaxWWTkpqTWZZapG+XwJVx6Msb1oLp7BU9H18yNjC2s3UxcnJICJhIPNv7gRXCFpO4cG89 UJyLQ0hgKaPE3f99UE4Tk8Ss+f+ZQKrYBDQl/m6+CdYtIqAgsbn3GVg3s8BHRokFq1JAbGEB P4nnj1rYQWwWAVWJTR29YL28As4Sk66fgtosJ3Hy2GSwXk4BF4kDB7+wgNhCQDUHlhxhmsDI u4CRYRWjaGppckFxUnquoV5xYm5xaV66XnJ+7iZGSFh92cG4+JjVIUYBDkYlHl4Hgf+hQqyJ ZcWVuYcYJTiYlUR4dWYBhXhTEiurUovy44tKc1KLDzFKc7AoifPO3fU+REggPbEkNTs1tSC1 CCbLxMEp1cBYaqcXxJjjqn+4+cQmzkgPI6djzO+9Jddb//jI9PDd5BUcWi7eP01fMgtwTOtV i74XumKekPOzhveB5ftFDgfOnyH2RLnDiqtFR2XRw7a49q+2P5RLSzctm//zl+GmyX7hz5gd 3hj9Yr5w3O71/o08DH9t371ifXO554L9lglbxHhO6sX6VuoosRRnJBpqMRcVJwIAU14V9CcC AAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cpumask_any_but returns value >= nr_cpu_ids if there are no more CPUs. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/bus/arm-ccn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/arm-ccn.c b/drivers/bus/arm-ccn.c index 7d9879e..cc322fb 100644 --- a/drivers/bus/arm-ccn.c +++ b/drivers/bus/arm-ccn.c @@ -1184,7 +1184,7 @@ static int arm_ccn_pmu_cpu_notifier(struct notifier_block *nb, if (!cpumask_test_and_clear_cpu(cpu, &dt->cpu)) break; target = cpumask_any_but(cpu_online_mask, cpu); - if (target < 0) + if (target >= nr_cpu_ids) break; perf_pmu_migrate_context(&dt->pmu, cpu, target); cpumask_set_cpu(target, &dt->cpu); -- 1.9.1