From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx142.netapp.com ([216.240.21.19]:2009 "EHLO mx142.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932638AbbI3R1O (ORCPT ); Wed, 30 Sep 2015 13:27:14 -0400 From: Anna Schumaker To: , , , , , , , , , , Subject: [PATCH v5 5/9] vfs: Copy shouldn't forbid ranges inside the same file Date: Wed, 30 Sep 2015 13:26:49 -0400 Message-ID: <1443634014-3026-6-git-send-email-Anna.Schumaker@Netapp.com> In-Reply-To: <1443634014-3026-1-git-send-email-Anna.Schumaker@Netapp.com> References: <1443634014-3026-1-git-send-email-Anna.Schumaker@Netapp.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-btrfs-owner@vger.kernel.org List-ID: This is perfectly valid for BTRFS and XFS, so let's leave this up to filesystems to check. Signed-off-by: Anna Schumaker Reviewed-by: David Sterba Reviewed-by: Darrick J. Wong --- fs/read_write.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index f3d6c48..8e7cb33 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -1371,10 +1371,6 @@ ssize_t vfs_copy_file_range(struct file *file_in, loff_t pos_in, file_in->f_path.mnt != file_out->f_path.mnt) return -EXDEV; - /* forbid ranges in the same file */ - if (inode_in == inode_out) - return -EINVAL; - if (len == 0) return 0; -- 2.6.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anna Schumaker Subject: [PATCH v5 5/9] vfs: Copy shouldn't forbid ranges inside the same file Date: Wed, 30 Sep 2015 13:26:49 -0400 Message-ID: <1443634014-3026-6-git-send-email-Anna.Schumaker@Netapp.com> References: <1443634014-3026-1-git-send-email-Anna.Schumaker@Netapp.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1443634014-3026-1-git-send-email-Anna.Schumaker@Netapp.com> Sender: linux-fsdevel-owner@vger.kernel.org To: linux-nfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, zab@zabbo.net, viro@zeniv.linux.org.uk, clm@fb.com, darrick.wong@oracle.com, mtk.manpages@gmail.com, andros@netapp.com, hch@infradead.org List-Id: linux-api@vger.kernel.org This is perfectly valid for BTRFS and XFS, so let's leave this up to filesystems to check. Signed-off-by: Anna Schumaker Reviewed-by: David Sterba Reviewed-by: Darrick J. Wong --- fs/read_write.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index f3d6c48..8e7cb33 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -1371,10 +1371,6 @@ ssize_t vfs_copy_file_range(struct file *file_in, loff_t pos_in, file_in->f_path.mnt != file_out->f_path.mnt) return -EXDEV; - /* forbid ranges in the same file */ - if (inode_in == inode_out) - return -EINVAL; - if (len == 0) return 0; -- 2.6.0