All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] rtc: at91rm9200: clear RTC alarm status flag prior to suspending
@ 2015-10-12  8:39 ` Wenyou Yang
  0 siblings, 0 replies; 6+ messages in thread
From: Wenyou Yang @ 2015-10-12  8:39 UTC (permalink / raw)
  To: Alessandro Zummo, Alexandre Belloni
  Cc: Nicolas Ferre, Ludovic Desroches, rtc-linux, linux-kernel,
	linux-arm-kernel, Wenyou Yang

As said in the SAMA5D2 datasheet, "Prior to instructing the device
to enter ULP mode 1, ... and the internal sources of wake-up must
be cleared."

This patch is to clear the RTC alarm status flag prior to suspending
to avoid the erroneous wake-up activity, as it is often used as
the wake-up source for the ULP mode 1.

Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---

Changes in v2:
 - Add more detail commit log.

 drivers/rtc/rtc-at91rm9200.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
index cb62e21..b60fd47 100644
--- a/drivers/rtc/rtc-at91rm9200.c
+++ b/drivers/rtc/rtc-at91rm9200.c
@@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
 	/* this IRQ is shared with DBGU and other hardware which isn't
 	 * necessarily doing PM like we are...
 	 */
+	at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
+
 	at91_rtc_imr = at91_rtc_read_imr()
 			& (AT91_RTC_ALARM|AT91_RTC_SECEV);
 	if (at91_rtc_imr) {
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [rtc-linux] [PATCH v2] rtc: at91rm9200: clear RTC alarm status flag prior to suspending
@ 2015-10-12  8:39 ` Wenyou Yang
  0 siblings, 0 replies; 6+ messages in thread
From: Wenyou Yang @ 2015-10-12  8:39 UTC (permalink / raw)
  To: Alessandro Zummo, Alexandre Belloni
  Cc: Nicolas Ferre, Ludovic Desroches, rtc-linux, linux-kernel,
	linux-arm-kernel, Wenyou Yang

As said in the SAMA5D2 datasheet, "Prior to instructing the device
to enter ULP mode 1, ... and the internal sources of wake-up must
be cleared."

This patch is to clear the RTC alarm status flag prior to suspending
to avoid the erroneous wake-up activity, as it is often used as
the wake-up source for the ULP mode 1.

Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---

Changes in v2:
 - Add more detail commit log.

 drivers/rtc/rtc-at91rm9200.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
index cb62e21..b60fd47 100644
--- a/drivers/rtc/rtc-at91rm9200.c
+++ b/drivers/rtc/rtc-at91rm9200.c
@@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
 	/* this IRQ is shared with DBGU and other hardware which isn't
 	 * necessarily doing PM like we are...
 	 */
+	at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
+
 	at91_rtc_imr = at91_rtc_read_imr()
 			& (AT91_RTC_ALARM|AT91_RTC_SECEV);
 	if (at91_rtc_imr) {
-- 
1.7.9.5

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2] rtc: at91rm9200: clear RTC alarm status flag prior to suspending
@ 2015-10-12  8:39 ` Wenyou Yang
  0 siblings, 0 replies; 6+ messages in thread
From: Wenyou Yang @ 2015-10-12  8:39 UTC (permalink / raw)
  To: linux-arm-kernel

As said in the SAMA5D2 datasheet, "Prior to instructing the device
to enter ULP mode 1, ... and the internal sources of wake-up must
be cleared."

This patch is to clear the RTC alarm status flag prior to suspending
to avoid the erroneous wake-up activity, as it is often used as
the wake-up source for the ULP mode 1.

Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---

Changes in v2:
 - Add more detail commit log.

 drivers/rtc/rtc-at91rm9200.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
index cb62e21..b60fd47 100644
--- a/drivers/rtc/rtc-at91rm9200.c
+++ b/drivers/rtc/rtc-at91rm9200.c
@@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
 	/* this IRQ is shared with DBGU and other hardware which isn't
 	 * necessarily doing PM like we are...
 	 */
+	at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
+
 	at91_rtc_imr = at91_rtc_read_imr()
 			& (AT91_RTC_ALARM|AT91_RTC_SECEV);
 	if (at91_rtc_imr) {
-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] rtc: at91rm9200: clear RTC alarm status flag prior to suspending
  2015-10-12  8:39 ` [rtc-linux] " Wenyou Yang
  (?)
@ 2015-10-18  0:15   ` Alexandre Belloni
  -1 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2015-10-18  0:15 UTC (permalink / raw)
  To: Wenyou Yang
  Cc: Alessandro Zummo, Nicolas Ferre, Ludovic Desroches, rtc-linux,
	linux-kernel, linux-arm-kernel

On 12/10/2015 at 16:39:23 +0800, Wenyou Yang wrote :
> As said in the SAMA5D2 datasheet, "Prior to instructing the device
> to enter ULP mode 1, ... and the internal sources of wake-up must
> be cleared."
> 
> This patch is to clear the RTC alarm status flag prior to suspending
> to avoid the erroneous wake-up activity, as it is often used as
> the wake-up source for the ULP mode 1.
> 
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
> 
> Changes in v2:
>  - Add more detail commit log.
> 
>  drivers/rtc/rtc-at91rm9200.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [rtc-linux] Re: [PATCH v2] rtc: at91rm9200: clear RTC alarm status flag prior to suspending
@ 2015-10-18  0:15   ` Alexandre Belloni
  0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2015-10-18  0:15 UTC (permalink / raw)
  To: Wenyou Yang
  Cc: Alessandro Zummo, Nicolas Ferre, Ludovic Desroches, rtc-linux,
	linux-kernel, linux-arm-kernel

On 12/10/2015 at 16:39:23 +0800, Wenyou Yang wrote :
> As said in the SAMA5D2 datasheet, "Prior to instructing the device
> to enter ULP mode 1, ... and the internal sources of wake-up must
> be cleared."
> 
> This patch is to clear the RTC alarm status flag prior to suspending
> to avoid the erroneous wake-up activity, as it is often used as
> the wake-up source for the ULP mode 1.
> 
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
> 
> Changes in v2:
>  - Add more detail commit log.
> 
>  drivers/rtc/rtc-at91rm9200.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2] rtc: at91rm9200: clear RTC alarm status flag prior to suspending
@ 2015-10-18  0:15   ` Alexandre Belloni
  0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2015-10-18  0:15 UTC (permalink / raw)
  To: linux-arm-kernel

On 12/10/2015 at 16:39:23 +0800, Wenyou Yang wrote :
> As said in the SAMA5D2 datasheet, "Prior to instructing the device
> to enter ULP mode 1, ... and the internal sources of wake-up must
> be cleared."
> 
> This patch is to clear the RTC alarm status flag prior to suspending
> to avoid the erroneous wake-up activity, as it is often used as
> the wake-up source for the ULP mode 1.
> 
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
> 
> Changes in v2:
>  - Add more detail commit log.
> 
>  drivers/rtc/rtc-at91rm9200.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-10-18  0:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-12  8:39 [PATCH v2] rtc: at91rm9200: clear RTC alarm status flag prior to suspending Wenyou Yang
2015-10-12  8:39 ` Wenyou Yang
2015-10-12  8:39 ` [rtc-linux] " Wenyou Yang
2015-10-18  0:15 ` Alexandre Belloni
2015-10-18  0:15   ` Alexandre Belloni
2015-10-18  0:15   ` [rtc-linux] " Alexandre Belloni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.