From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:53065 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751801AbbJLM4P (ORCPT ); Mon, 12 Oct 2015 08:56:15 -0400 Message-ID: <1444654560.2956.330.camel@decadent.org.uk> Subject: Re: [Xen-devel] [linux-3.14 bisection] complete test-amd64-i386-xl-qcow2 From: Ben Hutchings To: David Vrabel , Ian Campbell , Ian Jackson , stable@vger.kernel.org, Greg Kroah-Hartman Cc: xen-devel@lists.xensource.com, osstest service owner , Marek =?ISO-8859-1?Q?Marczykowski-G=F3recki?= Date: Mon, 12 Oct 2015 13:56:00 +0100 In-Reply-To: <561B873E.5040803@citrix.com> References: <1441099198.27618.13.camel@citrix.com> <21989.30329.419566.715627@mariner.uk.xensource.com> <1441101938.27618.17.camel@citrix.com> <1441185512.26292.111.camel@citrix.com> <1444342480.2956.274.camel@decadent.org.uk> <561B873E.5040803@citrix.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-2W2xh6KGvny7J7P26zBP" Mime-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: --=-2W2xh6KGvny7J7P26zBP Content-Type: multipart/mixed; boundary="=-IAx2BSOGvZKu/n/SXogA" --=-IAx2BSOGvZKu/n/SXogA Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-10-12 at 11:11 +0100, David Vrabel wrote: > On 08/10/15 23:14, Ben Hutchings wrote: > > On Wed, 2015-09-02 at 10:18 +0100, Ian Campbell wrote: > > > [resending to correct stable address, sorry folks] > > >=20 > > > TL;DR: Any backport of 30b03d05e074 to earlier than commit 1401c00e59= e > > > ("xen/gntdev: convert priv->lock to a mutex", which was added in v4.0= ) > > > needs $something doing to it, either s/mutex/spinlock/ or (more likel= y) > > > backporting of 1401c00e59e too. > > >=20 > > > Looking at LTS: > > >=20 > > > 3.18.y:> > > > > > > > Backported both. > > > 3.16.y:> > > > > > > > Has backported neither > > > 3.14.y:> > > > > > > > * Only backported 30b03d05e074 > > > 3.12.y:> > > > > > > > Has backported neither > > > 3.10.y:> > > > > > > > * Only backported 30b03d05e074 > > > 3.4.y:> > > > > > > > Has backported neither > > > 3.2.y:> > > > > > > > Has backported neither > > >=20 > > > So AFAICT 3.14.y and 3.10.y need fixes, probably following 3.18 and > > > backporting 1401c00e59e. > > >=20 > > > 3.16/12/4/2 might need to be careful if they subsequently pick up 30b= 03d05. > > [...] > >=20 > > I came up with the patch below for 3.2. Let me know if it's not > > correct. >=20 > Please just take commit 1401c00e59e instead. I couldn't 'just' take that commit; it doesn't apply cleanly. However I've backported it and changed 30b03d05e074 accordingly. The two patches are attached for your review. Ben. --=20 Ben Hutchings Teamwork is essential - it allows you to blame someone else. --=-IAx2BSOGvZKu/n/SXogA Content-Disposition: attachment; filename="xen-gntdev-convert-priv-lock-to-a-mutex.patch" Content-Type: text/x-patch; name="xen-gntdev-convert-priv-lock-to-a-mutex.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbTogRGF2aWQgVnJhYmVsIDxkYXZpZC52cmFiZWxAY2l0cml4LmNvbT4KRGF0ZTogRnJpLCA5 IEphbiAyMDE1IDE4OjA2OjEyICswMDAwClN1YmplY3Q6IHhlbi9nbnRkZXY6IGNvbnZlcnQgcHJp di0+bG9jayB0byBhIG11dGV4Cgpjb21taXQgMTQwMWMwMGU1OWVhMDIxYzU3NWY3NDYxMmZlMmRi YmEzNmQ2YTRlZSB1cHN0cmVhbS4KClVubWFwcGluZyBtYXkgcmVxdWlyZSBzbGVlcGluZyBhbmQg d2UgdW5tYXAgd2hpbGUgaG9sZGluZyBwcml2LT5sb2NrLCBzbwpjb252ZXJ0IGl0IHRvIGEgbXV0 ZXguCgpTaWduZWQtb2ZmLWJ5OiBEYXZpZCBWcmFiZWwgPGRhdmlkLnZyYWJlbEBjaXRyaXguY29t PgpSZXZpZXdlZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzdGVmYW5vLnN0YWJlbGxpbmlAZXUu Y2l0cml4LmNvbT4KW2J3aDogQmFja3BvcnRlZCB0byAzLjI6CiAtIEFkanVzdCBjb250ZXh0CiAt IERyb3AgY2hhbmdlcyB0byBmdW5jdGlvbnMgd2UgZG9uJ3QgaGF2ZV0KU2lnbmVkLW9mZi1ieTog QmVuIEh1dGNoaW5ncyA8YmVuQGRlY2FkZW50Lm9yZy51az4KLS0tCiBkcml2ZXJzL3hlbi9nbnRk ZXYuYyB8IDQwICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmls ZSBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAyMCBkZWxldGlvbnMoLSkKCi0tLSBhL2RyaXZl cnMveGVuL2dudGRldi5jCisrKyBiL2RyaXZlcnMveGVuL2dudGRldi5jCkBAIC02MCw3ICs2MCw3 IEBAIHN0YXRpYyBpbnQgdXNlX3B0ZW1vZDsKIHN0cnVjdCBnbnRkZXZfcHJpdiB7CiAJc3RydWN0 IGxpc3RfaGVhZCBtYXBzOwogCS8qIGxvY2sgcHJvdGVjdHMgbWFwcyBmcm9tIGNvbmN1cnJlbnQg Y2hhbmdlcyAqLwotCXNwaW5sb2NrX3QgbG9jazsKKwlzdHJ1Y3QgbXV0ZXggbG9jazsKIAlzdHJ1 Y3QgbW1fc3RydWN0ICptbTsKIAlzdHJ1Y3QgbW11X25vdGlmaWVyIG1uOwogfTsKQEAgLTM5NSw3 ICszOTUsNyBAQCBzdGF0aWMgdm9pZCBtbl9pbnZsX3JhbmdlX3N0YXJ0KHN0cnVjdCBtCiAJdW5z aWduZWQgbG9uZyBtc3RhcnQsIG1lbmQ7CiAJaW50IGVycjsKIAotCXNwaW5fbG9jaygmcHJpdi0+ bG9jayk7CisJbXV0ZXhfbG9jaygmcHJpdi0+bG9jayk7CiAJbGlzdF9mb3JfZWFjaF9lbnRyeSht YXAsICZwcml2LT5tYXBzLCBuZXh0KSB7CiAJCWlmICghbWFwLT52bWEpCiAJCQljb250aW51ZTsK QEAgLTQxNCw3ICs0MTQsNyBAQCBzdGF0aWMgdm9pZCBtbl9pbnZsX3JhbmdlX3N0YXJ0KHN0cnVj dCBtCiAJCQkJCShtZW5kIC0gbXN0YXJ0KSA+PiBQQUdFX1NISUZUKTsKIAkJV0FSTl9PTihlcnIp OwogCX0KLQlzcGluX3VubG9jaygmcHJpdi0+bG9jayk7CisJbXV0ZXhfdW5sb2NrKCZwcml2LT5s b2NrKTsKIH0KIAogc3RhdGljIHZvaWQgbW5faW52bF9wYWdlKHN0cnVjdCBtbXVfbm90aWZpZXIg Km1uLApAQCAtNDMxLDcgKzQzMSw3IEBAIHN0YXRpYyB2b2lkIG1uX3JlbGVhc2Uoc3RydWN0IG1t dV9ub3RpZmkKIAlzdHJ1Y3QgZ3JhbnRfbWFwICptYXA7CiAJaW50IGVycjsKIAotCXNwaW5fbG9j aygmcHJpdi0+bG9jayk7CisJbXV0ZXhfbG9jaygmcHJpdi0+bG9jayk7CiAJbGlzdF9mb3JfZWFj aF9lbnRyeShtYXAsICZwcml2LT5tYXBzLCBuZXh0KSB7CiAJCWlmICghbWFwLT52bWEpCiAJCQlj b250aW51ZTsKQEAgLTQ0MSw3ICs0NDEsNyBAQCBzdGF0aWMgdm9pZCBtbl9yZWxlYXNlKHN0cnVj dCBtbXVfbm90aWZpCiAJCWVyciA9IHVubWFwX2dyYW50X3BhZ2VzKG1hcCwgLyogb2Zmc2V0ICov IDAsIG1hcC0+Y291bnQpOwogCQlXQVJOX09OKGVycik7CiAJfQotCXNwaW5fdW5sb2NrKCZwcml2 LT5sb2NrKTsKKwltdXRleF91bmxvY2soJnByaXYtPmxvY2spOwogfQogCiBzdHJ1Y3QgbW11X25v dGlmaWVyX29wcyBnbnRkZXZfbW11X29wcyA9IHsKQEAgLTQ2Miw3ICs0NjIsNyBAQCBzdGF0aWMg aW50IGdudGRldl9vcGVuKHN0cnVjdCBpbm9kZSAqaW5vCiAJCXJldHVybiAtRU5PTUVNOwogCiAJ SU5JVF9MSVNUX0hFQUQoJnByaXYtPm1hcHMpOwotCXNwaW5fbG9ja19pbml0KCZwcml2LT5sb2Nr KTsKKwltdXRleF9pbml0KCZwcml2LT5sb2NrKTsKIAogCWlmICh1c2VfcHRlbW9kKSB7CiAJCXBy aXYtPm1tID0gZ2V0X3Rhc2tfbW0oY3VycmVudCk7CkBAIC01MzUsMTAgKzUzNSwxMCBAQCBzdGF0 aWMgbG9uZyBnbnRkZXZfaW9jdGxfbWFwX2dyYW50X3JlZihzCiAJCXJldHVybiBlcnI7CiAJfQog Ci0Jc3Bpbl9sb2NrKCZwcml2LT5sb2NrKTsKKwltdXRleF9sb2NrKCZwcml2LT5sb2NrKTsKIAln bnRkZXZfYWRkX21hcChwcml2LCBtYXApOwogCW9wLmluZGV4ID0gbWFwLT5pbmRleCA8PCBQQUdF X1NISUZUOwotCXNwaW5fdW5sb2NrKCZwcml2LT5sb2NrKTsKKwltdXRleF91bmxvY2soJnByaXYt PmxvY2spOwogCiAJaWYgKGNvcHlfdG9fdXNlcih1LCAmb3AsIHNpemVvZihvcCkpICE9IDApCiAJ CXJldHVybiAtRUZBVUxUOwpAQCAtNTU3LDEzICs1NTcsMTMgQEAgc3RhdGljIGxvbmcgZ250ZGV2 X2lvY3RsX3VubWFwX2dyYW50X3JlZgogCQlyZXR1cm4gLUVGQVVMVDsKIAlwcl9kZWJ1ZygicHJp diAlcCwgZGVsICVkKyVkXG4iLCBwcml2LCAoaW50KW9wLmluZGV4LCAoaW50KW9wLmNvdW50KTsK IAotCXNwaW5fbG9jaygmcHJpdi0+bG9jayk7CisJbXV0ZXhfbG9jaygmcHJpdi0+bG9jayk7CiAJ bWFwID0gZ250ZGV2X2ZpbmRfbWFwX2luZGV4KHByaXYsIG9wLmluZGV4ID4+IFBBR0VfU0hJRlQs IG9wLmNvdW50KTsKIAlpZiAobWFwKSB7CiAJCWxpc3RfZGVsKCZtYXAtPm5leHQpOwogCQllcnIg PSAwOwogCX0KLQlzcGluX3VubG9jaygmcHJpdi0+bG9jayk7CisJbXV0ZXhfdW5sb2NrKCZwcml2 LT5sb2NrKTsKIAlpZiAobWFwKQogCQlnbnRkZXZfcHV0X21hcChtYXApOwogCXJldHVybiBlcnI7 CkBAIC02MDgsNyArNjA4LDcgQEAgc3RhdGljIGxvbmcgZ250ZGV2X2lvY3RsX25vdGlmeShzdHJ1 Y3QgZwogCWlmIChvcC5hY3Rpb24gJiB+KFVOTUFQX05PVElGWV9DTEVBUl9CWVRFfFVOTUFQX05P VElGWV9TRU5EX0VWRU5UKSkKIAkJcmV0dXJuIC1FSU5WQUw7CiAKLQlzcGluX2xvY2soJnByaXYt PmxvY2spOworCW11dGV4X2xvY2soJnByaXYtPmxvY2spOwogCiAJbGlzdF9mb3JfZWFjaF9lbnRy eShtYXAsICZwcml2LT5tYXBzLCBuZXh0KSB7CiAJCXVpbnQ2NF90IGJlZ2luID0gbWFwLT5pbmRl eCA8PCBQQUdFX1NISUZUOwpAQCAtNjMxLDcgKzYzMSw3IEBAIHN0YXRpYyBsb25nIGdudGRldl9p b2N0bF9ub3RpZnkoc3RydWN0IGcKIAltYXAtPm5vdGlmeS5ldmVudCA9IG9wLmV2ZW50X2NoYW5u ZWxfcG9ydDsKIAlyYyA9IDA7CiAgdW5sb2NrX291dDoKLQlzcGluX3VubG9jaygmcHJpdi0+bG9j ayk7CisJbXV0ZXhfdW5sb2NrKCZwcml2LT5sb2NrKTsKIAlyZXR1cm4gcmM7CiB9CiAKQEAgLTY3 Niw3ICs2NzYsNyBAQCBzdGF0aWMgaW50IGdudGRldl9tbWFwKHN0cnVjdCBmaWxlICpmbGlwCiAJ cHJfZGVidWcoIm1hcCAlZCslZCBhdCAlbHggKHBnb2ZmICVseClcbiIsCiAJCQlpbmRleCwgY291 bnQsIHZtYS0+dm1fc3RhcnQsIHZtYS0+dm1fcGdvZmYpOwogCi0Jc3Bpbl9sb2NrKCZwcml2LT5s b2NrKTsKKwltdXRleF9sb2NrKCZwcml2LT5sb2NrKTsKIAltYXAgPSBnbnRkZXZfZmluZF9tYXBf aW5kZXgocHJpdiwgaW5kZXgsIGNvdW50KTsKIAlpZiAoIW1hcCkKIAkJZ290byB1bmxvY2tfb3V0 OwpAQCAtNzExLDcgKzcxMSw3IEBAIHN0YXRpYyBpbnQgZ250ZGV2X21tYXAoc3RydWN0IGZpbGUg KmZsaXAKIAkJCW1hcC0+ZmxhZ3MgfD0gR05UTUFQX3JlYWRvbmx5OwogCX0KIAotCXNwaW5fdW5s b2NrKCZwcml2LT5sb2NrKTsKKwltdXRleF91bmxvY2soJnByaXYtPmxvY2spOwogCiAJaWYgKHVz ZV9wdGVtb2QpIHsKIAkJZXJyID0gYXBwbHlfdG9fcGFnZV9yYW5nZSh2bWEtPnZtX21tLCB2bWEt PnZtX3N0YXJ0LApAQCAtNzM5LDExICs3MzksMTEgQEAgc3RhdGljIGludCBnbnRkZXZfbW1hcChz dHJ1Y3QgZmlsZSAqZmxpcAogCXJldHVybiAwOwogCiB1bmxvY2tfb3V0OgotCXNwaW5fdW5sb2Nr KCZwcml2LT5sb2NrKTsKKwltdXRleF91bmxvY2soJnByaXYtPmxvY2spOwogCXJldHVybiBlcnI7 CiAKIG91dF91bmxvY2tfcHV0OgotCXNwaW5fdW5sb2NrKCZwcml2LT5sb2NrKTsKKwltdXRleF91 bmxvY2soJnByaXYtPmxvY2spOwogb3V0X3B1dF9tYXA6CiAJaWYgKHVzZV9wdGVtb2QpCiAJCW1h cC0+dm1hID0gTlVMTDsK --=-IAx2BSOGvZKu/n/SXogA Content-Disposition: attachment; filename="xen-gntdevt-fix-race-condition-in-gntdev_release.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="xen-gntdevt-fix-race-condition-in-gntdev_release.patch"; charset="UTF-8" RnJvbTogPT9VVEYtOD9xP01hcmVrPTIwTWFyY3p5a293c2tpLUc9QzM9QjNyZWNraT89CiA8bWFy bWFyZWtAaW52aXNpYmxldGhpbmdzbGFiLmNvbT4KRGF0ZTogRnJpLCAyNiBKdW4gMjAxNSAwMzoy ODoyNCArMDIwMApTdWJqZWN0OiB4ZW4vZ250ZGV2dDogRml4IHJhY2UgY29uZGl0aW9uIGluIGdu dGRldl9yZWxlYXNlKCkKTUlNRS1WZXJzaW9uOiAxLjAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWlu OyBjaGFyc2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCmNvbW1pdCAz MGIwM2QwNWUwNzQ2N2I4YzZlYzY4M2VhOTZiNWJmZmNiY2QzOTMxIHVwc3RyZWFtLgoKV2hpbGUg Z250ZGV2X3JlbGVhc2UoKSBpcyBjYWxsZWQgdGhlIE1NVSBub3RpZmllciBpcyBzdGlsbCByZWdp c3RlcmVkCmFuZCBjYW4gdHJhdmVyc2UgcHJpdi0+bWFwcyBsaXN0IGV2ZW4gaWYgbm8gcGFnZXMg YXJlIG1hcHBlZCAod2hpY2ggaXMKdGhlIGNhc2UgLS0gZ250ZGV2X3JlbGVhc2UoKSBpcyBjYWxs ZWQgYWZ0ZXIgYWxsKS4gQnV0CmdudGRldl9yZWxlYXNlKCkgd2lsbCBjbGVhciB0aGF0IGxpc3Qs IHNvIG1ha2Ugc3VyZSB0aGF0IG9ubHkgb25lIG9mCnRob3NlIHRoaW5ncyBoYXBwZW5zIGF0IHRo ZSBzYW1lIHRpbWUuCgpTaWduZWQtb2ZmLWJ5OiBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kg PG1hcm1hcmVrQGludmlzaWJsZXRoaW5nc2xhYi5jb20+ClNpZ25lZC1vZmYtYnk6IERhdmlkIFZy YWJlbCA8ZGF2aWQudnJhYmVsQGNpdHJpeC5jb20+Cltid2g6IEJhY2twb3J0ZWQgdG8gMy4yOiBh ZGp1c3QgY29udGV4dF0KU2lnbmVkLW9mZi1ieTogQmVuIEh1dGNoaW5ncyA8YmVuQGRlY2FkZW50 Lm9yZy51az4KLS0tCiBkcml2ZXJzL3hlbi9nbnRkZXYuYyB8IDIgKysKIDEgZmlsZSBjaGFuZ2Vk LCAyIGluc2VydGlvbnMoKykKCi0tLSBhL2RyaXZlcnMveGVuL2dudGRldi5jCisrKyBiL2RyaXZl cnMveGVuL2dudGRldi5jCkBAIC00OTMsMTEgKzQ5MywxMyBAQCBzdGF0aWMgaW50IGdudGRldl9y ZWxlYXNlKHN0cnVjdCBpbm9kZSAqCiAKIAlwcl9kZWJ1ZygicHJpdiAlcFxuIiwgcHJpdik7CiAK KwltdXRleF9sb2NrKCZwcml2LT5sb2NrKTsKIAl3aGlsZSAoIWxpc3RfZW1wdHkoJnByaXYtPm1h cHMpKSB7CiAJCW1hcCA9IGxpc3RfZW50cnkocHJpdi0+bWFwcy5uZXh0LCBzdHJ1Y3QgZ3JhbnRf bWFwLCBuZXh0KTsKIAkJbGlzdF9kZWwoJm1hcC0+bmV4dCk7CiAJCWdudGRldl9wdXRfbWFwKG1h cCk7CiAJfQorCW11dGV4X3VubG9jaygmcHJpdi0+bG9jayk7CiAKIAlpZiAodXNlX3B0ZW1vZCkK IAkJbW11X25vdGlmaWVyX3VucmVnaXN0ZXIoJnByaXYtPm1uLCBwcml2LT5tbSk7Cg== --=-IAx2BSOGvZKu/n/SXogA-- --=-2W2xh6KGvny7J7P26zBP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVhut4Oe/yOyVhhEJAQrvCBAArpDhAJG/McBwfBrbX1kkLO940cGImfHj hqdTcOgkff8uMW7aA8jVEnYU0d9MrJm0bsiO23ZVSIOdBHv64J+GS8BpV+OGSLyK thk3PhVmMc+95/EFK8fFFbxmd4IuCGGAsZM4UOi4uTYmA/s5+cFO2cOEDT8bYfd1 c5SYkWTvRiftvz/WkgW5BuUb4InnBFK0voeFow19sOPrdOsAf7mgmcq6jDGWNyIb NGuLfUTssAPfnJdcqqhcZ0BiApVcyna/FxzIoZm8tVxci7/53C+yZBQ3uQnAA4k9 CvOdjpWI/H2WAzeihWp5NaHry66PbBJ1weJxq6DT2LA5yBda2qGytgAQg2aIXqhq d5MZOG2G6PDGTzMm/W4uvk2+KKj7V7zVlO3C9lDRxp1a05gHYxWCF9vs7/s1HTrl FJ1PzFxvzYTwfp2p0omGz0pi75IY5Iu8/QNW8SOr2L8RXkhI8hhaH7coynQIFcXb SuEhnaqKailUTecdTiaYvC+w3e0w+4KnSIBaPIj7YNEANvG8zpFgRwyVKcAUam+r b+zvndJZyjU6dTKO1lSxi06XTY6e91QQTPHODnaZ1MOhdyH8G+0vZkvbp0d7ZT54 BAQk7qRdqcViKg27fALURyKuZa7PYhD0u0TgXgtcKt6wLTOKD46PXr85h+h3kRXQ FrADkJHFr08= =N5Vn -----END PGP SIGNATURE----- --=-2W2xh6KGvny7J7P26zBP--