All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH] drm/i915: Disable DC6 for now.
Date: Mon, 12 Oct 2015 08:43:29 -0700	[thread overview]
Message-ID: <1444664609-24584-1-git-send-email-rodrigo.vivi@intel.com> (raw)
In-Reply-To: <1444656733.13337.31.camel@intel.com>

There is an intermitent RAM corruption happening with DMC
micro-controler when in DC6 transitioning to PC9/10. So
the recoomendation is to use DC5 as the deeper DC state
for now until this issue is being investigated at firmware
level.

This macros must be re-worked in order to allow us to use
module parameters to allow max DC states. However let's do
this simple approach first before products out there start
facing this corruption. Also this is the easiest one to be
backported by products.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index ec010ee..7332cc0 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -49,8 +49,8 @@
  * present for a given platform.
  */
 
-#define GEN9_ENABLE_DC5(dev) 0
-#define SKL_ENABLE_DC6(dev) IS_SKYLAKE(dev)
+#define GEN9_ENABLE_DC5(dev) IS_SKYLAKE(dev)
+#define SKL_ENABLE_DC6(dev) 0
 
 #define for_each_power_well(i, power_well, domain_mask, power_domains)	\
 	for (i = 0;							\
-- 
2.4.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-10-12 15:42 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03 16:25 [SKL-DMC-BUGFIX 0/5] SKL PC10 entry fixes Animesh Manna
2015-08-03 16:25 ` [SKL-DMC-BUGFIX 1/5] drm/i915/gen9: Removed byte swapping for csr firmware Animesh Manna
2015-08-04  3:46   ` Nagaraju, Vathsala
2015-08-04  5:55     ` Animesh Manna
2015-08-05  9:01       ` Daniel Vetter
2015-08-06  9:20         ` Animesh Manna
2015-09-11 15:29         ` Mika Kuoppala
2015-09-14  7:35           ` [REGRESSION] " Daniel Vetter
2015-09-17  9:36             ` Mika Kuoppala
2015-08-04 11:24   ` [SKL-DMC-BUGFIX 1/5] " Sunil Kamath
2015-08-03 16:25 ` [SKL-DMC-BUGFIX 2/5] drm/i915/skl: Making DC6 entry is the last call in suspend flow Animesh Manna
2015-08-04 11:25   ` Sunil Kamath
2015-08-05  9:07     ` Daniel Vetter
2015-08-05  9:05   ` Daniel Vetter
2015-08-06  9:17     ` Animesh Manna
2015-08-06 10:50       ` [PATCH " Animesh Manna
2015-08-06 13:18       ` [SKL-DMC-BUGFIX " Daniel Vetter
2015-08-06 14:38         ` Animesh Manna
2015-08-06 15:38           ` Daniel Vetter
2015-10-12 13:32   ` Imre Deak
2015-10-12 15:43     ` Rodrigo Vivi [this message]
2015-10-13  1:24       ` [PATCH] drm/i915: Disable DC6 for now Hindman, Gavin
2015-08-03 16:25 ` [SKL-DMC-BUGFIX 3/5] drm/i915/skl: Do not disable cdclk PLL if csr firmware is present Animesh Manna
2015-08-04 11:26   ` Sunil Kamath
2015-08-05  9:12   ` Daniel Vetter
2015-08-06  9:03     ` Animesh Manna
2015-08-06 11:23       ` Animesh Manna
2015-10-12 13:37   ` Imre Deak
2015-10-12 14:07     ` Imre Deak
2015-10-12 14:46       ` Patrik Jakobsson
2015-10-12 15:11         ` Imre Deak
2015-08-03 16:25 ` [SKL-DMC-BUGFIX 4/5] drm/i915/skl: Block disable call for pw1 if dmc " Animesh Manna
2015-08-04 11:27   ` Sunil Kamath
2015-08-05  9:14   ` Daniel Vetter
2015-08-06  8:57     ` Animesh Manna
2015-10-12 13:45   ` Imre Deak
2015-08-03 16:25 ` [SKL-DMC-BUGFIX 5/5] drm/i915/skl: Removed csr firmware load in resume path Animesh Manna
2015-08-04 11:20   ` Sunil Kamath
2015-08-04 11:33     ` Animesh Manna
2015-08-06  9:49       ` Animesh Manna
2015-10-12 14:02   ` Imre Deak
2015-08-03 18:47 ` [SKL-DMC-BUGFIX 0/5] SKL PC10 entry fixes Zanoni, Paulo R
2015-08-04 11:31   ` Sunil Kamath
2015-08-04 13:14     ` Zanoni, Paulo R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444664609-24584-1-git-send-email-rodrigo.vivi@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.