All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Esquivel <benjamin.esquivel@linux.intel.com>
To: "Aníbal Limón" <anibal.limon@linux.intel.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] bash: Disable custom memory allocator
Date: Tue, 13 Oct 2015 10:58:18 -0500	[thread overview]
Message-ID: <1444751898.2440.2.camel@linux.intel.com> (raw)
In-Reply-To: <1444429304-22379-1-git-send-email-anibal.limon@linux.intel.com>

Hey Anibal, a line or 2 in mentioning the issue at the git commit
message would be required. You're only mentioning that there is an
issue and it would be informational to say what it is, even though the
bug number is at the end.

On Fri, 2015-10-09 at 17:21 -0500, Aníbal Limón wrote:
> Bash is failing trying to allocate memory [1] using the custom
> memory allocator if we disable it the issue is fixed.
> 
> The major distributions also disabled by default [2], so we
> don't have a good reason to use it.
> 
> [YOCTO #8452]
> 
> [1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8452#c0
> [2] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8452#c5
> 
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
>  meta/recipes-extended/bash/bash.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/bash/bash.inc b/meta/recipes
> -extended/bash/bash.inc
> index c06f157..020409f 100644
> --- a/meta/recipes-extended/bash/bash.inc
> +++ b/meta/recipes-extended/bash/bash.inc
> @@ -7,7 +7,7 @@ DEPENDS = "ncurses bison-native"
>  inherit autotools gettext texinfo update-alternatives ptest
>  
>  EXTRA_AUTORECONF += "--exclude=autoheader"
> -EXTRA_OECONF = "--enable-job-control"
> +EXTRA_OECONF = "--enable-job-control --without-bash-malloc"
>  
>  # If NON_INTERACTIVE_LOGIN_SHELLS is defined, all login shells read
> the
>  # startup files, even if they are not interactive.


  parent reply	other threads:[~2015-10-13 15:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-09 22:21 [PATCH] bash: Disable custom memory allocator Aníbal Limón
2015-10-10  0:25 ` Khem Raj
2015-10-13 15:58 ` Benjamin Esquivel [this message]
2015-10-13 16:06   ` Aníbal Limón
2015-10-13 16:24     ` Benjamin Esquivel
2015-10-14  5:05     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444751898.2440.2.camel@linux.intel.com \
    --to=benjamin.esquivel@linux.intel.com \
    --cc=anibal.limon@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.