All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Sebastian Reichel <sre@kernel.org>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
	"Andrew F . Davis" <afd@ti.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] power: bq27xxx_battery: move irq handler to i2c section
Date: Fri, 16 Oct 2015 15:44:11 +0200	[thread overview]
Message-ID: <1445003052-31373-3-git-send-email-sre@kernel.org> (raw)
In-Reply-To: <1445003052-31373-1-git-send-email-sre@kernel.org>

The IRQ handler is not used by the platform based
code resulting in a 'defined but not used' warning,
if CONFIG_BQ27XXX_I2C is not enabled.

Signed-off-by: Sebastian Reichel <sre@kernel.org>
---
 drivers/power/bq27xxx_battery.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
index 69e6b371a51c..880233ce9343 100644
--- a/drivers/power/bq27xxx_battery.c
+++ b/drivers/power/bq27xxx_battery.c
@@ -762,15 +762,6 @@ static void bq27xxx_battery_update(struct bq27xxx_device_info *di)
 	di->last_update = jiffies;
 }
 
-static irqreturn_t bq27xxx_battery_irq_handler_thread(int irq, void *data)
-{
-	struct bq27xxx_device_info *di = data;
-
-	bq27xxx_battery_update(di);
-
-	return IRQ_HANDLED;
-}
-
 static void bq27xxx_battery_poll(struct work_struct *work)
 {
 	struct bq27xxx_device_info *di =
@@ -1061,6 +1052,15 @@ static void bq27xxx_powersupply_unregister(struct bq27xxx_device_info *di)
 static DEFINE_IDR(battery_id);
 static DEFINE_MUTEX(battery_mutex);
 
+static irqreturn_t bq27xxx_battery_irq_handler_thread(int irq, void *data)
+{
+	struct bq27xxx_device_info *di = data;
+
+	bq27xxx_battery_update(di);
+
+	return IRQ_HANDLED;
+}
+
 static int bq27xxx_battery_i2c_read(struct bq27xxx_device_info *di, u8 reg,
 				    bool single)
 {
-- 
2.6.1


  parent reply	other threads:[~2015-10-16 13:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 13:44 [PATCH 0/3] power: bq27xxx: Fix multiple defined but not used warnings Sebastian Reichel
2015-10-16 13:44 ` [PATCH 1/3] power: bq27xxx_battery: fix platform probe Sebastian Reichel
2015-10-16 14:47   ` Pali Rohár
2015-10-16 14:53   ` Andrew F. Davis
2015-10-16 13:44 ` Sebastian Reichel [this message]
2015-10-16 14:48   ` [PATCH 2/3] power: bq27xxx_battery: move irq handler to i2c section Pali Rohár
2015-10-16 15:06   ` Andrew F. Davis
2015-10-16 13:44 ` [PATCH 3/3] power: bq27xxx_battery: fix defined but not used warnings Sebastian Reichel
2015-10-16 14:47   ` Pali Rohár
2015-10-16 15:01     ` Andrew F. Davis
2015-10-16 15:01       ` Andrew F. Davis
2015-10-19  9:37       ` Sebastian Reichel
2015-10-19 16:33         ` Andrew F. Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445003052-31373-3-git-send-email-sre@kernel.org \
    --to=sre@kernel.org \
    --cc=afd@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.