From mboxrd@z Thu Jan 1 00:00:00 1970 From: geoff@infradead.org (Geoff Levand) Date: Tue, 20 Oct 2015 10:19:25 -0700 Subject: [PATCH 08/16] arm64/kexec: Add core kexec support In-Reply-To: <20151020085620.GC31893@dhcppc13.redhat.com> References: <20151020085620.GC31893@dhcppc13.redhat.com> Message-ID: <1445361565.30908.68.camel@infradead.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Tue, 2015-10-20 at 14:26 +0530, Pratyush Anand wrote: > On 19/10/2015:11:38:53 PM, Geoff Levand wrote: > > +static void soft_restart(unsigned long addr) > > +{ > > +> > > > setup_mm_for_reboot(); > > +> > > > cpu_soft_restart(virt_to_phys(cpu_reset), addr, > > +> > > > > > is_hyp_mode_available()); > > So now we do not flush cache for any memory region. Shouldn't we still flush > at least kernel and purgatory segments. Relevant pages of the kexec list are flushed in the code following the comment 'Invalidate dest page to PoC' of the arm64_relocate_new_kernel routine: The dcache is turned off The page is invalidated to PoC The new page is written -Geoff From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Message-ID: <1445361565.30908.68.camel@infradead.org> Subject: Re: [PATCH 08/16] arm64/kexec: Add core kexec support From: Geoff Levand Date: Tue, 20 Oct 2015 10:19:25 -0700 In-Reply-To: <20151020085620.GC31893@dhcppc13.redhat.com> References: <20151020085620.GC31893@dhcppc13.redhat.com> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Pratyush Anand Cc: Mark Rutland , AKASHI@infradead.org, marc.zyngier@arm.com, Catalin Marinas , Will Deacon , Takahiro , linux-arm-kernel@lists.infradead.org, kexec@lists.infradead.org, christoffer.dall@linaro.org Hi, On Tue, 2015-10-20 at 14:26 +0530, Pratyush Anand wrote: > On 19/10/2015:11:38:53 PM, Geoff Levand wrote: > > +static void soft_restart(unsigned long addr) > > +{ > > +> > > > setup_mm_for_reboot(); > > +> > > > cpu_soft_restart(virt_to_phys(cpu_reset), addr, > > +> > > > > > is_hyp_mode_available()); > > So now we do not flush cache for any memory region. Shouldn't we still flush > at least kernel and purgatory segments. Relevant pages of the kexec list are flushed in the code following the comment 'Invalidate dest page to PoC' of the arm64_relocate_new_kernel routine: The dcache is turned off The page is invalidated to PoC The new page is written -Geoff _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec