From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zoiol-0003uj-Dz for qemu-devel@nongnu.org; Tue, 20 Oct 2015 22:07:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zoiok-00047b-Ip for qemu-devel@nongnu.org; Tue, 20 Oct 2015 22:07:55 -0400 From: Fam Zheng Date: Wed, 21 Oct 2015 10:06:48 +0800 Message-Id: <1445393209-26545-12-git-send-email-famz@redhat.com> In-Reply-To: <1445393209-26545-1-git-send-email-famz@redhat.com> References: <1445393209-26545-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v5 11/12] qed: Implement .bdrv_drain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org The "need_check_timer" is used to clear the "NEED_CHECK" flag in the image header after a grace period once metadata update has finished. In compliance to the bdrv_drain semantics we should make sure it remains deleted once .bdrv_drain is called. Call the qed_need_check_timer_cb manually to update the header immediately. Signed-off-by: Fam Zheng --- block/qed.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/block/qed.c b/block/qed.c index 5ea05d4..e9dcb4d 100644 --- a/block/qed.c +++ b/block/qed.c @@ -375,6 +375,12 @@ static void bdrv_qed_attach_aio_context(BlockDriverState *bs, } } +static void bdrv_qed_drain(BlockDriverState *bs) +{ + qed_cancel_need_check_timer(bs->opaque); + qed_need_check_timer_cb(bs->opaque); +} + static int bdrv_qed_open(BlockDriverState *bs, QDict *options, int flags, Error **errp) { @@ -1676,6 +1682,7 @@ static BlockDriver bdrv_qed = { .bdrv_check = bdrv_qed_check, .bdrv_detach_aio_context = bdrv_qed_detach_aio_context, .bdrv_attach_aio_context = bdrv_qed_attach_aio_context, + .bdrv_drain = bdrv_qed_drain, }; static void bdrv_qed_init(void) -- 2.4.3