From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] libxl: make libxl_vncviewer_exec work with stubdom Date: Thu, 22 Oct 2015 17:31:17 +0100 Message-ID: <1445531477.2374.55.camel@citrix.com> References: <1445432829-19310-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZpIlt-0003Ke-Tl for xen-devel@lists.xenproject.org; Thu, 22 Oct 2015 16:31:22 +0000 In-Reply-To: <1445432829-19310-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Xen-devel Cc: Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Wed, 2015-10-21 at 14:07 +0100, Wei Liu wrote: > The xenstore path to look at when stubdom is in used is different. Libxl > should look at stubdom path instead. It took me a while to work this out, so please mention that the VNC in question is the backend corresponding to the stubdom's PVFB (into which it writes the emulated VGA content) and that the port for that is written into the PVFB frontend dir, i.e. on the stubdom path. Or alternatively since semantically this is the guest's console (albiet laundered through a stubdom) perhaps we should be writing these vnc-* keys there instead/as well? Either way these vnc-* keys need to be documented in docs/misc/xenstore -paths.markdown, either directly or by a reference to pvfb.h (which would then need to talk about them), so we know what they mean and where they should live (which in turn may render at least half what I said above moot). Ian.