All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: lvivier@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org,
	aik@ozlabs.ru, agraf@suse.de, mdroth@linux.vnet.ibm.com,
	qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 08/21] hw/scsi/spapr_vscsi: Remove superfluous memset
Date: Fri, 23 Oct 2015 20:43:20 +1100	[thread overview]
Message-ID: <1445593413-22057-10-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1445593413-22057-1-git-send-email-david@gibson.dropbear.id.au>

From: Thomas Huth <thuth@redhat.com>

g_malloc0 already clears the memory, so no need for
the additional memset here.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/scsi/spapr_vscsi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c
index 891424f..f4f5140 100644
--- a/hw/scsi/spapr_vscsi.c
+++ b/hw/scsi/spapr_vscsi.c
@@ -750,7 +750,6 @@ static void vscsi_report_luns(VSCSIState *s, vscsi_req *req)
     len = n+8;
 
     resp_data = g_malloc0(len);
-    memset(resp_data, 0, len);
     stl_be_p(resp_data, n);
     i = found_lun0 ? 8 : 16;
     QTAILQ_FOREACH(kid, &s->bus.qbus.children, sibling) {
-- 
2.4.3

  parent reply	other threads:[~2015-10-23  9:43 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23  9:43 [Qemu-devel] [PULL 00/21] ppc-next-20151023 queue 20151023 David Gibson
2015-10-23  9:43 ` David Gibson
2015-10-23 12:50   ` Peter Maydell
2015-10-23  9:43 ` [Qemu-devel] [PULL 01/21] spapr: Allocate HTAB from machine init David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 02/21] spapr: Abort when HTAB of requested size isn't allocated David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 03/21] spapr: Add "slb-size" property to CPU device tree nodes David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 04/21] spapr_pci: Allow PCI host bridge DMA window to be configured David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 05/21] spapr_iommu: Rename vfio_accel parameter David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 06/21] spapr_iommu: Provide a function to switch a TCE table to allowing VFIO David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 07/21] spapr_pci: Allow VFIO devices to work on the normal PCI host bridge David Gibson
2015-10-23  9:43 ` David Gibson [this message]
2015-10-23  9:43 ` [Qemu-devel] [PULL 09/21] ppc: Add mmu_model defines for arch 2.03 and 2.07 David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 10/21] ppc/spapr: Add "ibm, pa-features" property to the device-tree David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 11/21] adb: add to input category David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 12/21] cmd646: add to storage category David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 13/21] escc: add to input category David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 14/21] grackle: add to bridge category David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 15/21] cuda: " David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 16/21] macio-ide: add to storage category David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 17/21] uninorth: add to bridge category David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 18/21] macio: " David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 19/21] macio-nvram: add to misc category David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 20/21] openpic: " David Gibson
2015-10-23  9:43 ` [Qemu-devel] [PULL 21/21] prep: do not use CPU_LOG_IOPORT, convert to tracepoints David Gibson
2015-10-23 13:56 ` [Qemu-devel] [PULL 00/21] ppc-next-20151023 queue 20151023 Michael Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445593413-22057-10-git-send-email-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=lvivier@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.