All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taku Izumi <izumi.taku@jp.fujitsu.com>
To: linux-tip-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
	mingo.kernel.org@gmail.com, ard.biesheuvel@linaro.org,
	matt.fleming@intel.com
Cc: kamezawa.hiroyu@jp.fujitsu.com, Taku Izumi <izumi.taku@jp.fujitsu.com>
Subject: [PATCH v2] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds
Date: Fri, 23 Oct 2015 18:50:26 +0900	[thread overview]
Message-ID: <1445593826-4578-1-git-send-email-izumi.taku@jp.fujitsu.com> (raw)

commit-0f96a99 introduces the following warning message:

  drivers/firmware/efi/fake_mem.c:186:20: warning: cast to pointer
  from integer of different size [-Wint-to-pointer-cast]

new_memmap_phy was defined as a u64 value and casted to void*.
This causes a warning of int-to-pointer-cast on x86 32-bit
environment.

This patch changes the type of "new_memmap_phy" variable
from "u64" into "ulong" to avoid it.

v1 -> v2:
 - change the type of "new_memmap_phy" from phys_addr_t
   into ulong according to Ard's comment

Reported-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
---
 drivers/firmware/efi/fake_mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/fake_mem.c b/drivers/firmware/efi/fake_mem.c
index 32bcb14..1f483b4 100644
--- a/drivers/firmware/efi/fake_mem.c
+++ b/drivers/firmware/efi/fake_mem.c
@@ -59,7 +59,7 @@ void __init efi_fake_memmap(void)
 	u64 start, end, m_start, m_end, m_attr;
 	int new_nr_map = memmap.nr_map;
 	efi_memory_desc_t *md;
-	u64 new_memmap_phy;
+	ulong new_memmap_phy;
 	void *new_memmap;
 	void *old, *new;
 	int i;
-- 
1.8.3.1


             reply	other threads:[~2015-10-23  0:48 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23  9:50 Taku Izumi [this message]
2015-10-23  8:37 ` [PATCH v2] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds Ard Biesheuvel
2015-10-23  8:37   ` Ard Biesheuvel
2015-10-23  8:50   ` Ingo Molnar
2015-10-23  9:48     ` [PATCH 1/2] efi: use correct type for struct efi_memory_map::phys_map Ard Biesheuvel
2015-10-23  9:48       ` [PATCH 2/2] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds Ard Biesheuvel
2015-10-23  9:48         ` Ard Biesheuvel
2015-10-23 10:27         ` Ingo Molnar
2015-10-23 10:30           ` Ingo Molnar
2015-10-23 10:30             ` Ingo Molnar
2015-10-23 10:33             ` Ingo Molnar
2015-10-23 10:33               ` Ingo Molnar
2015-10-27 21:12               ` Matt Fleming
2015-10-28 11:28                 ` Ingo Molnar
2015-10-27 21:11         ` Matt Fleming
2015-10-28 20:57         ` [tip:core/efi] " tip-bot for Taku Izumi
2015-10-27 21:09       ` [PATCH 1/2] efi: use correct type for struct efi_memory_map::phys_map Matt Fleming
2015-10-28 20:57       ` [tip:core/efi] efi: Use correct type for struct efi_memory_map:: phys_map tip-bot for Ard Biesheuvel
2015-10-26 21:02   ` [PATCH v2] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds Matt Fleming
2015-10-26 21:02     ` Matt Fleming
2015-10-27  2:33     ` Ard Biesheuvel
2015-10-27 21:08       ` Matt Fleming
2015-10-27 21:08         ` Matt Fleming
2015-10-23  8:40 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445593826-4578-1-git-send-email-izumi.taku@jp.fujitsu.com \
    --to=izumi.taku@jp.fujitsu.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=mingo.kernel.org@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.