All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>,
	Harmandeep Kaur <write.harmandeep@gmail.com>,
	xen-devel@lists.xenproject.org
Cc: wei.liu2@citrix.com, stefano.stebellini@eu.citrix.com,
	ian.jackson@eu.citrix.com, george.dunlap@citrix.com,
	Lars Kurth <lars.kurth@citrix.com>
Subject: Re: [PATCH 1/3] xl: convert scheduling related return codes to EXIT_[SUCCESS|FAILURE]
Date: Fri, 23 Oct 2015 10:56:21 +0100	[thread overview]
Message-ID: <1445594181.2374.99.camel@citrix.com> (raw)
In-Reply-To: <1445589018.5117.8.camel@citrix.com>

On Fri, 2015-10-23 at 10:30 +0200, Dario Faggioli wrote:
> On Fri, 2015-10-23 at 13:18 +0530, Harmandeep Kaur wrote:
> > turning scheduling related functions xl exit codes towards using the
> > EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary
> > numbers
> > or libxl return codes.
> > 
> So, it's probably worth mentioning that this is Harman's "bite size
> contribution" that is required for applying to the Outreachy program.
> 
> Harman, when you send a patch series, as you did here (thanks and good
> job doing it so quickly :-) ), you want to include a 'cover letter'. That
> is an introductory email, often labelled (usually automatically by git
> tools) as patch 0 of the series itself. In it, you give a brief
> explanation of what the series is meant at, and any kind of information
> you think the people reviewing the series should have, but that wouldn't
> fit in the various patches' changelogs, code comments, etc.

In particular in this case I would like to know whether all xl functions
now use EXIT_SUCCESS/FAILURE or if there is still inconsistencies/work to
be done.

I don't see any existing use of of EXIT_* in xl*.

> 
> For instance, in this case, you could have mentioned (among other things)
> that this is your small contribution for the sake of applying to
> Outreachy right in there. :-)
> 
> Thanks and Regards,
> Dario

  reply	other threads:[~2015-10-23  9:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23  7:48 [PATCH 1/3] xl: convert scheduling related return codes to EXIT_[SUCCESS|FAILURE] Harmandeep Kaur
2015-10-23  7:48 ` [PATCH 2/3] xl: convert vcpu " Harmandeep Kaur
2015-10-23 10:41   ` Dario Faggioli
2015-10-23  7:48 ` [PATCH 3/3] xl: convert cpupool " Harmandeep Kaur
2015-10-23 12:10   ` Dario Faggioli
2015-10-23 12:33     ` Harmandeep Kaur
2015-10-23  8:30 ` [PATCH 1/3] xl: convert scheduling " Dario Faggioli
2015-10-23  9:56   ` Ian Campbell [this message]
2015-10-23 10:03     ` Dario Faggioli
2015-10-23 10:16       ` Ian Campbell
2015-10-23 10:16 ` Dario Faggioli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445594181.2374.99.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=dario.faggioli@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=lars.kurth@citrix.com \
    --cc=stefano.stebellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=write.harmandeep@gmail.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.