From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1445639975.701.257.camel@freescale.com> Subject: Re: [PATCH v3 0/5] clk: qoriq: Move chip-specific knowledge into driver From: Scott Wood To: Michael Turquette , Stephen Boyd CC: "Rafael J. Wysocki" , Viresh Kumar , Russell King , , , , , Tang Yuantian , , Bhupesh Sharma , Russell King , Arnd Bergmann Date: Fri, 23 Oct 2015 17:39:35 -0500 In-Reply-To: <1442723397-26329-1-git-send-email-scottwood@freescale.com> References: <1442723397-26329-1-git-send-email-scottwood@freescale.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Return-Path: scottwood@freescale.com List-ID: On Sat, 2015-09-19 at 23:29 -0500, Scott Wood wrote: > The existing device tree bindings are error-prone and inflexible. > Correct the mistake by moving the knowledge into the driver, which has > more flexibility in describing the quirks of each chip. This leaves the > device tree to its proper role of identifying a programming interface > rather than describing its individual registers. > > For more detail, see the commit message of patch 2. > > As there are both ARM and PPC patches that depend on this patchset, I'm > requesting ACKs from clk and cpufreq in order to put this into a topic > branch that both ARM and PPC can pull. > > Scott Wood (5): > powerpc/fsl: Move fsl_guts.h out of arch/powerpc > clk: qoriq: Move chip-specific knowledge into driver > clk: qoriq: Add ls2080a support. > clk: Add consumer APIs for discovering possible parent clocks > cpufreq: qoriq: Don't look at clock implementation details I've applied the first three patches plus http://patchwork.ozlabs.org/patch/534739/ to the clock branch of scottwood/linux.git to be used as a basis for PPC and ARM device tree patches. Note that there is a trivial merge conflict with commit 4a7748c3d6419bb8178748 ("clk: Allow drivers to build if COMPILE_TEST is enabled"). Another option is for these patches to go via the clk tree, and the device tree patches will ust go separately. This would result in intermediate commits where the device tree contains clock information that the clock driver can't handle, but it would be resolved by -rc1 -- and it seems that one of the ARM device tree patches ("dts/ls2080a: Update DTSI to add support of various peripherals") was already merged without waiting for the clock driver patch. I could still wait until next merge window to rip out the legacy stuff from existing device trees, so it would only affect new functionality. Patch 4 is still waiting for an ack from Russell King, but it appears that patch 5 (which depends on patch 4) can probably wait until the next merge window. Without those patches, qoriq-cpufreq should still mostly work, as long as the old device trees are used. Patches 4 and 5 will be needed to make qoriq-cpufreq continue to work with device trees using the new binding. -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH v3 0/5] clk: qoriq: Move chip-specific knowledge into driver Date: Fri, 23 Oct 2015 17:39:35 -0500 Message-ID: <1445639975.701.257.camel@freescale.com> References: <1442723397-26329-1-git-send-email-scottwood@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bl2on0135.outbound.protection.outlook.com ([65.55.169.135]:58784 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751301AbbJWWkG (ORCPT ); Fri, 23 Oct 2015 18:40:06 -0400 In-Reply-To: <1442723397-26329-1-git-send-email-scottwood@freescale.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Michael Turquette , Stephen Boyd Cc: "Rafael J. Wysocki" , Viresh Kumar , Russell King , linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Tang Yuantian , javier@osg.samsung.com, Bhupesh Sharma Russell King , Arnd Bergmann On Sat, 2015-09-19 at 23:29 -0500, Scott Wood wrote: > The existing device tree bindings are error-prone and inflexible. > Correct the mistake by moving the knowledge into the driver, which has > more flexibility in describing the quirks of each chip. This leaves the > device tree to its proper role of identifying a programming interface > rather than describing its individual registers. > > For more detail, see the commit message of patch 2. > > As there are both ARM and PPC patches that depend on this patchset, I'm > requesting ACKs from clk and cpufreq in order to put this into a topic > branch that both ARM and PPC can pull. > > Scott Wood (5): > powerpc/fsl: Move fsl_guts.h out of arch/powerpc > clk: qoriq: Move chip-specific knowledge into driver > clk: qoriq: Add ls2080a support. > clk: Add consumer APIs for discovering possible parent clocks > cpufreq: qoriq: Don't look at clock implementation details I've applied the first three patches plus http://patchwork.ozlabs.org/patch/534739/ to the clock branch of scottwood/linux.git to be used as a basis for PPC and ARM device tree patches. Note that there is a trivial merge conflict with commit 4a7748c3d6419bb8178748 ("clk: Allow drivers to build if COMPILE_TEST is enabled"). Another option is for these patches to go via the clk tree, and the device tree patches will ust go separately. This would result in intermediate commits where the device tree contains clock information that the clock driver can't handle, but it would be resolved by -rc1 -- and it seems that one of the ARM device tree patches ("dts/ls2080a: Update DTSI to add support of various peripherals") was already merged without waiting for the clock driver patch. I could still wait until next merge window to rip out the legacy stuff from existing device trees, so it would only affect new functionality. Patch 4 is still waiting for an ack from Russell King, but it appears that patch 5 (which depends on patch 4) can probably wait until the next merge window. Without those patches, qoriq-cpufreq should still mostly work, as long as the old device trees are used. Patches 4 and 5 will be needed to make qoriq-cpufreq continue to work with device trees using the new binding. -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 From: scottwood@freescale.com (Scott Wood) Date: Fri, 23 Oct 2015 17:39:35 -0500 Subject: [PATCH v3 0/5] clk: qoriq: Move chip-specific knowledge into driver In-Reply-To: <1442723397-26329-1-git-send-email-scottwood@freescale.com> References: <1442723397-26329-1-git-send-email-scottwood@freescale.com> Message-ID: <1445639975.701.257.camel@freescale.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, 2015-09-19 at 23:29 -0500, Scott Wood wrote: > The existing device tree bindings are error-prone and inflexible. > Correct the mistake by moving the knowledge into the driver, which has > more flexibility in describing the quirks of each chip. This leaves the > device tree to its proper role of identifying a programming interface > rather than describing its individual registers. > > For more detail, see the commit message of patch 2. > > As there are both ARM and PPC patches that depend on this patchset, I'm > requesting ACKs from clk and cpufreq in order to put this into a topic > branch that both ARM and PPC can pull. > > Scott Wood (5): > powerpc/fsl: Move fsl_guts.h out of arch/powerpc > clk: qoriq: Move chip-specific knowledge into driver > clk: qoriq: Add ls2080a support. > clk: Add consumer APIs for discovering possible parent clocks > cpufreq: qoriq: Don't look at clock implementation details I've applied the first three patches plus http://patchwork.ozlabs.org/patch/534739/ to the clock branch of scottwood/linux.git to be used as a basis for PPC and ARM device tree patches. Note that there is a trivial merge conflict with commit 4a7748c3d6419bb8178748 ("clk: Allow drivers to build if COMPILE_TEST is enabled"). Another option is for these patches to go via the clk tree, and the device tree patches will ust go separately. This would result in intermediate commits where the device tree contains clock information that the clock driver can't handle, but it would be resolved by -rc1 -- and it seems that one of the ARM device tree patches ("dts/ls2080a: Update DTSI to add support of various peripherals") was already merged without waiting for the clock driver patch. I could still wait until next merge window to rip out the legacy stuff from existing device trees, so it would only affect new functionality. Patch 4 is still waiting for an ack from Russell King, but it appears that patch 5 (which depends on patch 4) can probably wait until the next merge window. Without those patches, qoriq-cpufreq should still mostly work, as long as the old device trees are used. Patches 4 and 5 will be needed to make qoriq-cpufreq continue to work with device trees using the new binding. -Scott