All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glen Lee <glen.lee@atmel.com>
To: <gregkh@linuxfoundation.org>
Cc: <devel@driverdev.osuosl.org>, <linux-wireless@vger.kernel.org>,
	<tony.cho@atmel.com>, <glen.lee@atmel.com>, <leo.kim@atmel.com>,
	<austin.shin@atmel.com>, <adel.noureldin@atmel.com>,
	<adham.abozaeid@atmel.com>, <Nicolas.FERRE@atmel.com>
Subject: [PATCH 01/80] staging: wilc1000: remove unnecessary parentheses around
Date: Wed, 28 Oct 2015 15:59:21 +0900	[thread overview]
Message-ID: <1446015640-29398-1-git-send-email-glen.lee@atmel.com> (raw)

From: Leo Kim <leo.kim@atmel.com>

This patch removes the checks reported by checkpatch.pl
for unnecessary parentheses around.

Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
---
 drivers/staging/wilc1000/host_interface.c | 48 +++++++++++++++----------------
 1 file changed, 23 insertions(+), 25 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index f658594..acc6552b 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -332,7 +332,7 @@ static s32 Handle_SetChannel(struct host_if_drv *hif_drv,
 
 	strWID.id = (u16)WID_CURRENT_CHANNEL;
 	strWID.type = WID_CHAR;
-	strWID.val = (char *)&(pstrHostIFSetChan->set_ch);
+	strWID.val = (char *)&pstrHostIFSetChan->set_ch;
 	strWID.size = sizeof(char);
 
 	PRINT_D(HOSTINF_DBG, "Setting channel\n");
@@ -356,7 +356,7 @@ static s32 Handle_SetWfiDrvHandler(struct host_if_drv *hif_drv,
 
 	strWID.id = (u16)WID_SET_DRV_HANDLER;
 	strWID.type = WID_INT;
-	strWID.val = (s8 *)&(pstrHostIfSetDrvHandler->u32Address);
+	strWID.val = (s8 *)&pstrHostIfSetDrvHandler->u32Address;
 	strWID.size = sizeof(u32);
 
 	result = send_config_pkt(SET_CFG, &strWID, 1,
@@ -381,7 +381,7 @@ static s32 Handle_SetOperationMode(struct host_if_drv *hif_drv,
 
 	strWID.id = (u16)WID_SET_OPERATION_MODE;
 	strWID.type = WID_INT;
-	strWID.val = (s8 *)&(pstrHostIfSetOperationMode->u32Mode);
+	strWID.val = (s8 *)&pstrHostIfSetOperationMode->u32Mode;
 	strWID.size = sizeof(u32);
 
 	result = send_config_pkt(SET_CFG, &strWID, 1,
@@ -881,7 +881,7 @@ static s32 Handle_Scan(struct host_if_drv *hif_drv,
 	strWIDList[u32WidsCount].id = WID_SCAN_TYPE;
 	strWIDList[u32WidsCount].type = WID_CHAR;
 	strWIDList[u32WidsCount].size = sizeof(char);
-	strWIDList[u32WidsCount].val = (s8 *)(&(pstrHostIFscanAttr->type));
+	strWIDList[u32WidsCount].val = (s8 *)&pstrHostIFscanAttr->type;
 	u32WidsCount++;
 
 	strWIDList[u32WidsCount].id = WID_SCAN_CHANNEL_LIST;
@@ -904,7 +904,7 @@ static s32 Handle_Scan(struct host_if_drv *hif_drv,
 	strWIDList[u32WidsCount].id = WID_START_SCAN_REQ;
 	strWIDList[u32WidsCount].type = WID_CHAR;
 	strWIDList[u32WidsCount].size = sizeof(char);
-	strWIDList[u32WidsCount].val = (s8 *)(&(pstrHostIFscanAttr->src));
+	strWIDList[u32WidsCount].val = (s8 *)&pstrHostIFscanAttr->src;
 	u32WidsCount++;
 
 	if (hif_drv->enuHostIFstate == HOST_IF_CONNECTED)
@@ -1069,7 +1069,7 @@ static s32 Handle_Connect(struct host_if_drv *hif_drv,
 	strWIDList[u32WidsCount].id = (u16)WID_11I_MODE;
 	strWIDList[u32WidsCount].type = WID_CHAR;
 	strWIDList[u32WidsCount].size = sizeof(char);
-	strWIDList[u32WidsCount].val = (s8 *)(&(hif_drv->strWILC_UsrConnReq.u8security));
+	strWIDList[u32WidsCount].val = (s8 *)&hif_drv->strWILC_UsrConnReq.u8security;
 	u32WidsCount++;
 
 	if (memcmp("DIRECT-", pstrHostIFconnectAttr->ssid, 7))
@@ -1732,21 +1732,21 @@ static int Handle_Key(struct host_if_drv *hif_drv,
 		if (pstrHostIFkeyAttr->action & ADDKEY_AP) {
 
 			PRINT_D(HOSTINF_DBG, "Handling WEP key\n");
-			PRINT_D(GENERIC_DBG, "ID Hostint is %d\n", (pstrHostIFkeyAttr->attr.wep.index));
+			PRINT_D(GENERIC_DBG, "ID Hostint is %d\n", pstrHostIFkeyAttr->attr.wep.index);
 			strWIDList[0].id = (u16)WID_11I_MODE;
 			strWIDList[0].type = WID_CHAR;
 			strWIDList[0].size = sizeof(char);
-			strWIDList[0].val = (s8 *)(&(pstrHostIFkeyAttr->attr.wep.mode));
+			strWIDList[0].val = (s8 *)&pstrHostIFkeyAttr->attr.wep.mode;
 
 			strWIDList[1].id = WID_AUTH_TYPE;
 			strWIDList[1].type = WID_CHAR;
 			strWIDList[1].size = sizeof(char);
-			strWIDList[1].val = (s8 *)(&(pstrHostIFkeyAttr->attr.wep.auth_type));
+			strWIDList[1].val = (s8 *)&pstrHostIFkeyAttr->attr.wep.auth_type;
 
 			strWIDList[2].id = (u16)WID_KEY_ID;
 			strWIDList[2].type = WID_CHAR;
 
-			strWIDList[2].val = (s8 *)(&(pstrHostIFkeyAttr->attr.wep.index));
+			strWIDList[2].val = (s8 *)&pstrHostIFkeyAttr->attr.wep.index;
 			strWIDList[2].size = sizeof(char);
 
 			pu8keybuf = kmemdup(pstrHostIFkeyAttr->attr.wep.key,
@@ -1808,7 +1808,7 @@ static int Handle_Key(struct host_if_drv *hif_drv,
 		} else {
 			strWID.id = (u16)WID_KEY_ID;
 			strWID.type = WID_CHAR;
-			strWID.val = (s8 *)(&(pstrHostIFkeyAttr->attr.wep.index));
+			strWID.val = (s8 *)&pstrHostIFkeyAttr->attr.wep.index;
 			strWID.size = sizeof(char);
 
 			PRINT_D(HOSTINF_DBG, "Setting default key index\n");
@@ -1839,7 +1839,7 @@ static int Handle_Key(struct host_if_drv *hif_drv,
 			strWIDList[0].id = (u16)WID_11I_MODE;
 			strWIDList[0].type = WID_CHAR;
 			strWIDList[0].size = sizeof(char);
-			strWIDList[0].val = (s8 *)(&(pstrHostIFkeyAttr->attr.wpa.mode));
+			strWIDList[0].val = (s8 *)&pstrHostIFkeyAttr->attr.wpa.mode;
 
 			strWIDList[1].id = (u16)WID_ADD_RX_GTK;
 			strWIDList[1].type = WID_STR;
@@ -1914,7 +1914,7 @@ _WPARxGtk_end_case_:
 			strWIDList[0].id = (u16)WID_11I_MODE;
 			strWIDList[0].type = WID_CHAR;
 			strWIDList[0].size = sizeof(char);
-			strWIDList[0].val = (s8 *)(&(pstrHostIFkeyAttr->attr.wpa.mode));
+			strWIDList[0].val = (s8 *)&pstrHostIFkeyAttr->attr.wpa.mode;
 
 			strWIDList[1].id = (u16)WID_ADD_PTK;
 			strWIDList[1].type = WID_STR;
@@ -2160,9 +2160,7 @@ static void Handle_GetLinkspeed(struct host_if_drv *hif_drv)
 		result = -EFAULT;
 	}
 
-	up(&(hif_drv->hSemGetLINKSPEED));
-
-
+	up(&hif_drv->hSemGetLINKSPEED);
 }
 
 s32 Handle_GetStatistics(struct host_if_drv *hif_drv, struct rf_info *pstrStatistics)
@@ -2173,31 +2171,31 @@ s32 Handle_GetStatistics(struct host_if_drv *hif_drv, struct rf_info *pstrStatis
 	strWIDList[u32WidsCount].id = WID_LINKSPEED;
 	strWIDList[u32WidsCount].type = WID_CHAR;
 	strWIDList[u32WidsCount].size = sizeof(char);
-	strWIDList[u32WidsCount].val = (s8 *)(&(pstrStatistics->u8LinkSpeed));
+	strWIDList[u32WidsCount].val = (s8 *)&pstrStatistics->u8LinkSpeed;
 	u32WidsCount++;
 
 	strWIDList[u32WidsCount].id = WID_RSSI;
 	strWIDList[u32WidsCount].type = WID_CHAR;
 	strWIDList[u32WidsCount].size = sizeof(char);
-	strWIDList[u32WidsCount].val = (s8 *)(&(pstrStatistics->s8RSSI));
+	strWIDList[u32WidsCount].val = (s8 *)&pstrStatistics->s8RSSI;
 	u32WidsCount++;
 
 	strWIDList[u32WidsCount].id = WID_SUCCESS_FRAME_COUNT;
 	strWIDList[u32WidsCount].type = WID_INT;
 	strWIDList[u32WidsCount].size = sizeof(u32);
-	strWIDList[u32WidsCount].val = (s8 *)(&(pstrStatistics->u32TxCount));
+	strWIDList[u32WidsCount].val = (s8 *)&pstrStatistics->u32TxCount;
 	u32WidsCount++;
 
 	strWIDList[u32WidsCount].id = WID_RECEIVED_FRAGMENT_COUNT;
 	strWIDList[u32WidsCount].type = WID_INT;
 	strWIDList[u32WidsCount].size = sizeof(u32);
-	strWIDList[u32WidsCount].val = (s8 *)(&(pstrStatistics->u32RxCount));
+	strWIDList[u32WidsCount].val = (s8 *)&pstrStatistics->u32RxCount;
 	u32WidsCount++;
 
 	strWIDList[u32WidsCount].id = WID_FAILED_COUNT;
 	strWIDList[u32WidsCount].type = WID_INT;
 	strWIDList[u32WidsCount].size = sizeof(u32);
-	strWIDList[u32WidsCount].val = (s8 *)(&(pstrStatistics->u32TxFailureCount));
+	strWIDList[u32WidsCount].val = (s8 *)&pstrStatistics->u32TxFailureCount;
 	u32WidsCount++;
 
 	result = send_config_pkt(GET_CFG, strWIDList, u32WidsCount,
@@ -2608,8 +2606,8 @@ static int Handle_RegisterFrame(struct host_if_drv *hif_drv,
 
 	*pu8CurrByte++ = pstrHostIfRegisterFrame->bReg;
 	*pu8CurrByte++ = pstrHostIfRegisterFrame->u8Regid;
-	memcpy(pu8CurrByte, &(pstrHostIfRegisterFrame->u16FrameType), sizeof(u16));
-
+	memcpy(pu8CurrByte, &pstrHostIfRegisterFrame->u16FrameType,
+	       sizeof(u16));
 
 	strWID.size = sizeof(u16) + 2;
 
@@ -4206,7 +4204,7 @@ s32 host_int_init(struct net_device *dev, struct host_if_drv **hif_drv_handler)
 
 	setup_timer(&hif_drv->hRemainOnChannel, ListenTimerCB, 0);
 
-	sema_init(&(hif_drv->gtOsCfgValuesSem), 1);
+	sema_init(&hif_drv->gtOsCfgValuesSem, 1);
 	down(&hif_drv->gtOsCfgValuesSem);
 
 	hif_drv->enuHostIFstate = HOST_IF_IDLE;
@@ -4302,7 +4300,7 @@ s32 host_int_deinit(struct host_if_drv *hif_drv)
 		wilc_mq_destroy(&hif_msg_q);
 	}
 
-	down(&(hif_drv->gtOsCfgValuesSem));
+	down(&hif_drv->gtOsCfgValuesSem);
 
 	ret = remove_handler_in_list(hif_drv);
 	if (ret)
-- 
1.9.1


             reply	other threads:[~2015-10-28  6:57 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28  6:59 Glen Lee [this message]
2015-10-28  6:59 ` [PATCH 02/80] staging: wilc1000: fixes braces {} are not necessary for single statement blocks Glen Lee
2015-10-28  6:59 ` [PATCH 03/80] staging: wilc1000: fixes blank lines aren't necessary brace Glen Lee
2015-10-28  6:59 ` [PATCH 04/80] staging: wilc1000: fixes missing a blank line after declarations Glen Lee
2015-10-28  6:59 ` [PATCH 05/80] staging: wilc1000: fixes please don't use multiple blank lines Glen Lee
2015-10-28  6:59 ` [PATCH 06/80] staging: wilc1000: host_interface: removes unused functions Glen Lee
2015-10-28  7:21   ` Sudip Mukherjee
2015-10-28  7:30     ` glen lee
2015-10-28  6:59 ` [PATCH 07/80] staging: wilc1000: rename au8StartTime of struct join_bss_param Glen Lee
2015-10-28  6:59 ` [PATCH 08/80] staging: wilc1000: rename variable strWID Glen Lee
2015-10-28  6:59 ` [PATCH 09/80] staging: wilc1000: rename u32Address of struct drv_handler Glen Lee
2015-10-28  6:59 ` [PATCH 10/80] staging: wilc1000: rename u32Mode of struct op_mode Glen Lee
2015-10-28  6:59 ` [PATCH 11/80] staging: wilc1000: rename u8MacAddress of struct set_mac_addr Glen Lee
2015-10-28  6:59 ` [PATCH 12/80] staging: wilc1000: rename u8MacAddress of struct get_mac_addr Glen Lee
2015-10-28  6:59 ` [PATCH 13/80] staging: wilc1000: rename strWILC_UsrScanReq of struct host_if_drv Glen Lee
2015-10-28  6:59 ` [PATCH 14/80] staging: wilc1000: rename strWILC_UsrConnReq " Glen Lee
2015-10-28  6:59 ` [PATCH 15/80] staging: wilc1000: rename strHostIfRemainOnChan " Glen Lee
2015-10-28  6:59 ` [PATCH 16/80] staging: wilc1000: rename u8RemainOnChan_pendingreq " Glen Lee
2015-10-28  6:59 ` [PATCH 17/80] staging: wilc1000: rename enuHostIFstate " Glen Lee
2015-10-28 14:07   ` Dan Carpenter
2015-10-28  6:59 ` [PATCH 18/80] staging: wilc1000: rename au8AssociatedBSSID " Glen Lee
2015-10-28 23:46   ` Greg KH
2015-10-28  6:59 ` [PATCH 19/80] staging: wilc1000: rename strCfgValues " Glen Lee
2015-10-28  6:59 ` [PATCH 20/80] staging: wilc1000: rename gtOsCfgValuesSem " Glen Lee
2015-10-28  6:59 ` [PATCH 21/80] staging: wilc1000: rename hSemTestKeyBlock " Glen Lee
2015-10-28  6:59 ` [PATCH 22/80] staging: wilc1000: rename hSemTestDisconnectBlock " Glen Lee
2015-10-28  6:59 ` [PATCH 23/80] staging: wilc1000: rename hSemGetRSSI " Glen Lee
2015-10-28  6:59 ` [PATCH 24/80] staging: wilc1000: rename hSemGetLINKSPEED " Glen Lee
2015-10-28  6:59 ` [PATCH 25/80] staging: wilc1000: rename hSemGetCHNL " Glen Lee
2015-10-28  6:59 ` [PATCH 26/80] staging: wilc1000: rename hSemInactiveTime " Glen Lee
2015-10-28  6:59 ` [PATCH 27/80] staging: wilc1000: rename hScanTimer " Glen Lee
2015-10-28  6:59 ` [PATCH 28/80] staging: wilc1000: rename hConnectTimer " Glen Lee
2015-10-28  6:59 ` [PATCH 29/80] staging: wilc1000: rename hRemainOnChannel " Glen Lee
2015-10-28  6:59 ` [PATCH 30/80] staging: wilc1000: host_interface.h : remove over-commenting Glen Lee
2015-10-28  6:59 ` [PATCH 31/80] staging: wilc1000: rename bReg of struct reg_frame Glen Lee
2015-10-28  6:59 ` [PATCH 32/80] staging: wilc1000: rename u16FrameType " Glen Lee
2015-10-28  6:59 ` [PATCH 33/80] staging: wilc1000: rename u8Regid " Glen Lee
2015-10-28  6:59 ` [PATCH 34/80] staging: wilc1000: rename u16Channel of struct remain_ch Glen Lee
2015-10-28  6:59 ` [PATCH 35/80] staging: wilc1000: rename pRemainOnChanExpired " Glen Lee
2015-10-28  6:59 ` [PATCH 36/80] staging: wilc1000: rename pRemainOnChanReady " Glen Lee
2015-10-28  6:59 ` [PATCH 37/80] staging: wilc1000: rename pVoid " Glen Lee
2015-10-28  6:59 ` [PATCH 38/80] staging: wilc1000: rename au8Bssid of struct ba_session_info Glen Lee
2015-10-28 16:56   ` Dan Carpenter
2015-10-28 17:06     ` Joe Perches
2015-10-29  2:02     ` glen lee
2015-10-28  6:59 ` [PATCH 39/80] staging: wilc1000: rename u8Ted " Glen Lee
2015-10-28  7:00 ` [PATCH 40/80] staging: wilc1000: rename u16BufferSize " Glen Lee
2015-10-28  7:00 ` [PATCH 41/80] staging: wilc1000: rename u16SessionTimeout " Glen Lee
2015-10-28  7:00 ` [PATCH 42/80] staging: wilc1000: remove warnings line over 80 characters Glen Lee
2015-10-28  7:00 ` [PATCH 43/80] staging: wilc1000: rename pfUserScanResult of struct user_scan_req Glen Lee
2015-10-28  7:00 ` [PATCH 44/80] staging: wilc1000: rename u32UserScanPvoid " Glen Lee
2015-10-28  7:00 ` [PATCH 45/80] staging: wilc1000: rename astrFoundNetworkInfo " Glen Lee
2015-10-28  7:00 ` [PATCH 46/80] staging: wilc1000: rename ssidLen of struct user_conn_req Glen Lee
2015-10-28  7:00 ` [PATCH 47/80] staging: wilc1000: rename pu8ConnReqIEs " Glen Lee
2015-10-28  7:00 ` [PATCH 48/80] staging: wilc1000: rename ConnReqIEsLen " Glen Lee
2015-10-28  7:00 ` [PATCH 49/80] staging: wilc1000: rename pfUserConnectResult " Glen Lee
2015-10-28  7:00 ` [PATCH 50/80] staging: wilc1000: rename IsHTCapable " Glen Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446015640-29398-1-git-send-email-glen.lee@atmel.com \
    --to=glen.lee@atmel.com \
    --cc=Nicolas.FERRE@atmel.com \
    --cc=adel.noureldin@atmel.com \
    --cc=adham.abozaeid@atmel.com \
    --cc=austin.shin@atmel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=leo.kim@atmel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tony.cho@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.