From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Dan Streetman <dan.streetman@canonical.com>,
Steffen Klassert <steffen.klassert@secunet.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Dan Streetman <ddstreet@ieee.org>
Subject: Re: [PATCH] xfrm: dst_entries_init() per-net dst_ops
Date: Wed, 28 Oct 2015 14:42:43 +0100 [thread overview]
Message-ID: <1446039763.132965.422568409.3FC44B03@webmail.messagingengine.com> (raw)
In-Reply-To: <CAOZ2QJMuPoSrrFdudiGYQ4PjvELbonqg94X2mQaUhZ-R5yS0hw@mail.gmail.com>
Hello,
On Wed, Oct 28, 2015, at 14:32, Dan Streetman wrote:
> On Tue, Oct 27, 2015 at 12:15 PM, <dan.streetman@canonical.com> wrote:
> > From: Dan Streetman <dan.streetman@canonical.com>
> >
> > The ipv4 and ipv6 xfrms each create a template dst_ops object, and
> > perform dst_entries_init() on the template objects. Then each net
> > namespace has its net.xfrm.xfrm[46]_dst_ops field set to the template
> > values. The problem with that is the dst_ops.pcpuc_entries field is
> > a percpu counter and cannot be used correctly by simply copying it to
> > another object.
How hard would it be to split of the counters from the dst_ops struct?
We could make dst_ops instances const and have normal pointers to them
and keep the dst_entries as a small array in net namespace?
Bye,
Hannes
next prev parent reply other threads:[~2015-10-28 13:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 16:15 [PATCH] xfrm: dst_entries_init() per-net dst_ops dan.streetman
2015-10-28 13:32 ` Dan Streetman
2015-10-28 13:42 ` Hannes Frederic Sowa [this message]
2015-10-28 15:09 ` Dan Streetman
2015-10-28 14:07 ` David Miller
2015-10-29 11:29 ` [PATCHv2] " Dan Streetman
2015-10-29 11:57 ` kbuild test robot
2015-10-29 13:46 ` Dan Streetman
2015-10-29 13:51 ` [PATCHv3] " Dan Streetman
2015-11-03 13:22 ` Steffen Klassert
2015-12-22 9:35 pull request (net): ipsec 2015-12-22 Steffen Klassert
2015-12-22 9:35 ` [PATCH] xfrm: dst_entries_init() per-net dst_ops Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446039763.132965.422568409.3FC44B03@webmail.messagingengine.com \
--to=hannes@stressinduktion.org \
--cc=dan.streetman@canonical.com \
--cc=davem@davemloft.net \
--cc=ddstreet@ieee.org \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.