From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH v2] drm/i915: Always program CSR if CSR is uninitialized Date: Wed, 28 Oct 2015 19:12:17 +0200 Message-ID: <1446052337.21976.89.camel@intel.com> References: <1445593310-26596-1-git-send-email-patrik.jakobsson@linux.intel.com> <1445971291.2408.68.camel@intel.com> <20151028155201.GA4506@patrik-desktop.isw.intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 8EB4C6E08F for ; Wed, 28 Oct 2015 10:12:21 -0700 (PDT) In-Reply-To: <20151028155201.GA4506@patrik-desktop.isw.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Patrik Jakobsson Cc: intel-gfx@lists.freedesktop.org, rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24ga2UsIDIwMTUtMTAtMjggYXQgMTY6NTIgKzAxMDAsIFBhdHJpayBKYWtvYnNzb24gd3JvdGU6 Cj4gT24gVHVlLCBPY3QgMjcsIDIwMTUgYXQgMDg6NDE6MzFQTSArMDIwMCwgSW1yZSBEZWFrIHdy b3RlOgo+ID4gT24gcGUsIDIwMTUtMTAtMjMgYXQgMTE6NDEgKzAyMDAsIFBhdHJpayBKYWtvYnNz b24gd3JvdGU6Cj4gPiA+IFRoZSBjdXJyZW50IENTUiBsb2FkaW5nIGNvZGUgZGVwZW5kcyBvbiB0 aGUgQ1NSIHByb2dyYW0gbWVtb3J5IHRvIGJlCj4gPiA+IGNsZWFyZWQgYWZ0ZXIgYm9vdC4gVGhp cyBpcyB1bmZvcnR1bmF0ZWx5IG5vdCB0cnVlIG9uIGFsbCBoYXJkd2FyZS4KPiA+ID4gSW5zdGVh ZCBtYWtlIHVzZSBvZiB0aGUgRldfVU5JTklUSUFMSVpFRCBzdGF0ZSBpbiBpbml0IGFuZCBjaGVj ayBmb3IKPiA+ID4gRldfTE9BREVEIHRvIHByZXZlbnQgaW5pdCBwYXRoIGZyb20gc2tpcHBpbmcg dGhlIGFjdHVhbCBwcm9ncmFtbWluZy4KPiA+ID4gCj4gPiA+IHYyOiBNb3ZlIGluaXRpYWxpemF0 aW9uIG9mIHN0YXRlIHRvIGFmdGVyIEhBU19DU1IoKSBjaGVjawo+ID4gPiAKPiA+ID4gU2lnbmVk LW9mZi1ieTogUGF0cmlrIEpha29ic3NvbiA8cGF0cmlrLmpha29ic3NvbkBsaW51eC5pbnRlbC5j b20+Cj4gPiA+IFRlc3RlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29t Pgo+ID4gPiBSZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29t Pgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Nzci5jIHwgNCAr KystCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p Cj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3Ny LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jc3IuYwo+ID4gPiBpbmRleCA5ZTUzMGE3 Li5lNzRjMDllIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9j c3IuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jc3IuYwo+ID4gPiBA QCAtMjcxLDcgKzI3MSw3IEBAIHZvaWQgaW50ZWxfY3NyX2xvYWRfcHJvZ3JhbShzdHJ1Y3QgZHJt X2RldmljZSAqZGV2KQo+ID4gPiAgCSAqIFVuZm9ydHVuYXRlbHkgdGhlIEFDUEkgc3Vic3lzdGVt IGRvZXNuJ3QgeWV0IGdpdmUgdXMgYSB3YXkgdG8KPiA+ID4gIAkgKiBkaWZmZXJlbnRpYXRlIHRo aXMsIGhlbmNlIGZpZ3VyZSBpdCBvdXQgd2l0aCB0aGlzIGhhY2suCj4gPiA+ICAJICovCj4gPiA+ IC0JaWYgKEk5MTVfUkVBRChDU1JfUFJPR1JBTSgwKSkpCj4gPiA+ICsJaWYgKEk5MTVfUkVBRChD U1JfUFJPR1JBTSgwKSkgJiYgZGV2X3ByaXYtPmNzci5zdGF0ZSA9PSBGV19MT0FERUQpCj4gPiA+ ICAJCXJldHVybjsKPiA+IAo+ID4gQXMgQW5pbWVzaCBzYWlkIGNzci0+c3RhdGUgaXMgYmVpbmcg cmVtb3ZlZCwgc28gSSdkIHByZWZlciBpZiB3ZSBkaWRuJ3QKPiA+IGFkZCBuZXcgdXNlcnMgZm9y IGl0Lgo+ID4gCj4gPiBJIHRoaW5rIHRoZSBwcm9wZXIgc29sdXRpb24gZm9yIHRoaXMgd291bGQg YmUgdG8gcmVwcm9ncmFtIHRoZSBmaXJtd2FyZQo+ID4gb25seSB3aGVuIHdlIGtub3cgd2UgaGF2 ZSB0byBhbmQgbm90IGhhdmUgaGVyZSBlaXRoZXIgb2YgdGhlIGFib3ZlCj4gPiBjaGVja3MuIFRo ZSBwb2ludHMgd2UgbmVlZCB0byByZXByb2dyYW0gdGhlIGZpcm13YXJlOgo+ID4gCj4gPiBTMy9T NCBib3RoIG9uIFNLTC4KPiA+IFMzL1M0L0RDOSAocnVudGltZSBzdXNwZW5kKSBvbiBCWFQuCj4g Cj4gSXNuJ3QgdGhpcyB3aGF0IGNzci0+c3RhdGUgd2FzIGludGVuZGVkIHRvIHNvbHZlIGluIHRo ZSBmaXJzdCBwbGFjZT8gSXQncyB2ZXJ5Cj4gZWFzeSB0byBnZXQgbG9zdCBpbiB0aGUgZGlzY3Vz c2lvbnMgYXJvdW5kIERNQyBzbyBJJ3ZlIG1pZ2h0IGhhdmUgbWlzc2VkCj4gc29tZXRoaW5nLgoK SXQgd2FzIHVzZWQgdG8gdHJhY2sgaWYgd2UgbmVlZCB0byBlbmFibGUvZGlzYWJsZSBEQzUvNiAo ZGVwZW5kaW5nIG9uCnRoZSBmaXJtd2FyZSBsb2FkIHN0YXR1cyksIGJ1dCB0aGF0IGNoZWNrIHdv bid0IGJlIG5lZWRlZCBhbnkgbW9yZSBzaW5jZQpydW50aW1lIFBNIGl0c2VsZiB3aWxsIGJlIGRp c2FibGVkIHdoaWxlIHRoZSBmaXJtd2FyZSBpcyBub3QgbG9hZGVkLiBTbwp3ZSBjYW4gZW5hYmxl L2Rpc2FibGUgREM1LzYgdW5jb25kaXRpb25hbGx5LgoKV2Uga25vdyB3aGVyZSB3ZSBuZWVkIHRv IHJlcHJvZ3JhbSB0aGUgZmlybXdhcmUgKHJlc3VtaW5nIGZyb20gdGhlIGFib3ZlClBNIHN0YXRl cyksIHNvIHdlIGNvdWxkIHJlcHJvZ3JhbSBpdCBhdCB0aG9zZSB0aW1lcyB1bmNvbmRpdGlvbmFs bHkKd2l0aG91dCB1c2luZyBhIGZsYWcuCgo+ID4gVG8gZml4IHRoaXMgcGFydGljdWxhciBidWcg eW91IGNvdWxkIGFsc28ganVzdCBhZGQgYW4KPiA+IGludGVsX2Nzcl9yZXByb2dyYW0oKSB0aGF0 IHdvdWxkIGNoZWNrIGZvciBDU1JfUFJPR1JBTSgwKSBhcyBub3csIHdoaWxlCj4gPiBkdXJpbmcg ZHJpdmVyIGxvYWRpbmcgeW91IHdvdWxkIHByb2dyYW0gdGhlIGZpcm13YXJlIHVuY29uZGl0aW9u YWxseS4KPiAKPiBEaWQgc29tZSBtb3JlIGRpZ2dpbmcgYW5kIGl0IHNlZW1zIHRoZSBDU1IgcHJv Z3JhbSBpcyBub3QgY2xlYXJlZCBvbiB3YXJtIGJvb3QuCj4gU28gY2hlY2tpbmcgQ1NSX1BST0dS QU0oMCkgPT0gcGF5bG9hZFswXSB3aWxsIG5vdCB3b3JrLgoKWWVzLCB0aGUgY2hlY2sgd2lsbCBu b3Qgd29yayBmb3IgUzMvUzQsIGJ1dCB0aGF0J3MgYSBzZXBhcmF0ZSBleGlzdGluZwppc3N1ZS4g VGhlIHNvbHV0aW9uIGZvciB0aGF0IGlzIGluc3RlYWQgb2YgdGhpcyBjaGVjayBvciBhIGZsYWcs IHByb2dyYW0KdGhlIEZXIHVuY29uZGl0aW9uYWxseSB3aGVuIHdlIGtub3cgd2UgaGF2ZSB0by4g QnV0IHRoYXQgY291bGQgYmUgYWxzbwpmaXhlZCBzZXBhcmF0ZWx5LgoKPiBEb24ndCB0aGluayB3 ZSBjYW4gZmlndXJlIG91dCB0aGUgQ1NSIHN0YXR1cyBieSBwcm9iaW5nIGhhcmR3YXJlIHNvIHdl Cj4gbXVzdCBrZWVwIGEgZmxhZyBmb3IgdGhpcyBzb21ld2hlcmUuCgpXZSBjYW4ndCBwcm9iZSB0 aGUgSFcsIGJ1dCB3ZSBrbm93IHRoZSBwbGFjZXMgdGhlIEZXIG11c3QgYmUKcmVwcm9ncmFtbWVk LCBzbyB3ZSB3b3VsZG4ndCBuZWVkIHRvIHByb2JlLgoKPiBUaGUgQ1NSIHByb2dyYW0gbG9hZGlu ZyBpcyBhc3luYyBzbyB0aGUgc3RhdGUgbmVlZCB0byBiZSBzdG9yZWQKPiBzb21ld2hlcmUgYW5k IG5vdCBqdXN0IHBhc3NlZCBhbG9uZyBhcyBhIGZ1bmN0aW9uIGFyZ3VtZW50LgoKVGhlIHByb2dy YW1taW5nIGl0c2VsZiBpcyBub3QgYXN5bmMuIFNvIGZvciB0aGlzIGZpeCB3ZSBjb3VsZCBwcm9n cmFtCnRoZSBmaXJtd2FyZSB1bmNvbmRpdGlvbmFsbHkgKHdpdGhvdXQgY2hlY2tpbmcgZm9yIENT Ul9QUk9HUkFNKDApKSBmcm9tCmZpbmlzaF9jc3JfbG9hZCgpIHdoaWxlIHN0aWxsIGNoZWNraW5n IENTUl9QUk9HUkFNKDApIHdoZW4gY2FsbGVkIGZyb20Kc2tsX3Jlc3VtZV9wcmVwYXJlKCkuCgpB cyBhIGZvbGxvdy11cCB3ZSBjb3VsZCBhbHNvIGZpeCB0aGUgUzMvUzQgY2FzZXMgYnkgcmVtb3Zp bmcgdGhlCkNTUl9QUk9HUkFNKDApIGNoZWNrIGFsdG9nZXRoZXIsIGFuZCBjYWxsaW5nIGludGVs X2Nzcl9sb2FkX3Byb2dyYW0oKQpvbmx5IHdoZW4gcmVzdW1pbmcgZnJvbSB0aGUgYWJvdmUgUE0g ZXZlbnRzLgoKLS1JbXJlCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK