From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zu1j0-0005N4-4y for qemu-devel@nongnu.org; Wed, 04 Nov 2015 12:19:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zu1iv-0003WU-J4 for qemu-devel@nongnu.org; Wed, 04 Nov 2015 12:19:54 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:35898 helo=relay.sw.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zu1iv-0003UJ-6D for qemu-devel@nongnu.org; Wed, 04 Nov 2015 12:19:49 -0500 From: "Denis V. Lunev" Date: Wed, 4 Nov 2015 20:19:31 +0300 Message-Id: <1446657582-21619-1-git-send-email-den@openvz.org> Subject: [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Denis V. Lunev" , qemu-devel@nongnu.org, Stefan Hajnoczi , Juan Quintela with test while /bin/true ; do virsh snapshot-create rhel7 sleep 10 virsh snapshot-delete rhel7 --current done with enabled iothreads on a running VM leads to a lot of troubles: hangs, asserts, errors. Anyway, I think that the construction like assert(aio_context_is_locked(aio_context)); should be widely used to ensure proper locking. Changes from v4: - only migration/savevm.c code and monitor is affected now. Generic block layer stuff will be sent separately to speedup merging. The approach in general was negotiated with Juan and Stefan. Changes from v3: - more places found - new aio_poll concept, see patch 10 Changes from v2: - droppped patch 5 as already merged - changed locking scheme in patch 4 by suggestion of Juan Changes from v1: - aio-context locking added - comment is rewritten Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi CC: Juan Quintela CC: Kevin Wolf Denis V. Lunev (11): snapshot: create helper to test that block drivers supports snapshots snapshot: return error code from bdrv_snapshot_delete_by_id_or_name snapshot: create bdrv_all_delete_snapshot helper snapshot: create bdrv_all_goto_snapshot helper snapshot: create bdrv_all_find_snapshot helper migration: drop find_vmstate_bs check in hmp_delvm migration: reorder processing in hmp_savevm migration: implement bdrv_all_find_vmstate_bs and bdrv_unlock helpers migration: add missed aio_context_acquire for state writing/reading snapshot: create bdrv_all_create_snapshot helper monitor: add missed aio_context_acquire into vm_completion call block/snapshot.c | 141 +++++++++++++++++++++++++++++- include/block/snapshot.h | 23 ++++- migration/savevm.c | 219 +++++++++++++++-------------------------------- monitor.c | 11 ++- 4 files changed, 234 insertions(+), 160 deletions(-) -- 2.5.0