All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
	Michal Kazior <michal.kazior@tieto.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Configurable scan dwell time?
Date: Thu, 05 Nov 2015 17:25:33 +0100	[thread overview]
Message-ID: <1446740733.2540.9.camel@sipsolutions.net> (raw)
In-Reply-To: <563B8206.1040807@candelatech.com>


> > The thing though is that there are now use cases in the standard(s)
> > that want/require doing this. So just adding it as a hint will run the
> > risk of userspace (like wpa_s) using this "hint" for implementing newer
> > spec functionality, testing on ath9k and hwsim and declaring that it
> > works :-) And then we're stuck with this feature being used/advertised
> > on older devices where it doesn't actually work.
> 
> Scanning is already best effort.  Someone implementing this new hint
> can just be aware of the limitations.  If nothing else, start a scan on
> a known number of channels (or single channel), see how long it takes..then you know if the
> driver is ignoring your hint or not.

But if you were asked to measure something on that channel, for a given
amount of time while scanning, you could reasonably implement it that
way. If you don't really know how long the device is *actually* going
to do this, then you can't rightfully say you implement that spec.

You can't really start a scan and measure the time either since there's
no guarantee the scan will start right away.

> > Now, having those standard use cases is actually a good argument *for*
> > adding them in the standard API, but I think we need to be more careful
> > around these issues - perhaps having drivers indicate that they support
> > it, maybe even with valid ranges, etc.
> 
> I think that is vastly over-engineering the problem, but truth is, it
> can always be added later if there is an actual need for that knowledge.
> 

Well, not really. The only way for this to work would be to outright
reject requests that weren't within the advertised ranges; doing this
after already having the API would break existing clients thereof.

johannes

  reply	other threads:[~2015-11-05 16:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 23:58 Configurable scan dwell time? Ben Greear
2015-11-05  6:41 ` Michal Kazior
2015-11-05  7:56   ` Johannes Berg
2015-11-05 16:01     ` Ben Greear
2015-11-05 16:06       ` Johannes Berg
2015-11-05 16:21         ` Ben Greear
2015-11-05 16:25           ` Johannes Berg [this message]
2015-11-05 16:42             ` Ben Greear
2015-11-20 12:05               ` Johannes Berg
2015-11-20 16:04                 ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446740733.2540.9.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.