From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zv5pe-0003RR-FL for qemu-devel@nongnu.org; Sat, 07 Nov 2015 10:55:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zv5pZ-0005Xs-GA for qemu-devel@nongnu.org; Sat, 07 Nov 2015 10:55:10 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:22736 helo=relay.sw.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zv5pZ-0005XJ-5E for qemu-devel@nongnu.org; Sat, 07 Nov 2015 10:55:05 -0500 From: "Denis V. Lunev" Date: Sat, 7 Nov 2015 18:54:50 +0300 Message-Id: <1446911700-16803-1-git-send-email-den@openvz.org> Subject: [Qemu-devel] [PATCH for 2.5 v6 0/10] dataplane snapshot fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Denis V. Lunev" , qemu-devel@nongnu.org, Stefan Hajnoczi , Juan Quintela with test while /bin/true ; do virsh snapshot-create rhel7 sleep 10 virsh snapshot-delete rhel7 --current done with enabled iothreads on a running VM leads to a lot of troubles: hangs, asserts, errors. Anyway, I think that the construction like assert(aio_context_is_locked(aio_context)); should be widely used to ensure proper locking. Changes from v5: - dropped already merged patch 11 - fixed spelling in patch 1 - changed order of condition in loops in all patches. Thank you Stefan :) - dropped patch 9 - aio_context is not acquired any more in bdrv_all_find_vmstate_bs by request of Stefan - patch 10 is implemented in completely different way Changes from v4: - only migration/savevm.c code and monitor is affected now. Generic block layer stuff will be sent separately to speedup merging. The approach in general was negotiated with Juan and Stefan. Changes from v3: - more places found - new aio_poll concept, see patch 10 Changes from v2: - droppped patch 5 as already merged - changed locking scheme in patch 4 by suggestion of Juan Changes from v1: - aio-context locking added - comment is rewritten Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi CC: Juan Quintela CC: Kevin Wolf Denis V. Lunev (10): snapshot: create helper to test that block drivers supports snapshots snapshot: return error code from bdrv_snapshot_delete_by_id_or_name snapshot: create bdrv_all_delete_snapshot helper snapshot: create bdrv_all_goto_snapshot helper snapshot: create bdrv_all_find_snapshot helper migration: drop find_vmstate_bs check in hmp_delvm snapshot: create bdrv_all_create_snapshot helper migration: reorder processing in hmp_savevm migration: implement bdrv_all_find_vmstate_bs helper migration: normalize locking in migration/savevm.c block/snapshot.c | 130 ++++++++++++++++++++++++++++- include/block/snapshot.h | 21 ++++- migration/savevm.c | 210 +++++++++++++++-------------------------------- 3 files changed, 209 insertions(+), 152 deletions(-) -- 2.5.0