All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: stable@vger.kernel.org
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>,
	NeilBrown <neilb@suse.com>, Jiri Slaby <jslaby@suse.cz>
Subject: [patch added to the 3.12 stable tree] md/raid10: submit_bio_wait() returns 0 on success
Date: Mon,  9 Nov 2015 12:56:34 +0100	[thread overview]
Message-ID: <1447070198-11171-13-git-send-email-jslaby@suse.cz> (raw)
In-Reply-To: <1447070198-11171-1-git-send-email-jslaby@suse.cz>

From: Jes Sorensen <Jes.Sorensen@redhat.com>

This patch has been added to the 3.12 stable tree. If you have any
objections, please let us know.

===============

commit 681ab4696062f5aa939c9e04d058732306a97176 upstream.

This was introduced with 9e882242c6193ae6f416f2d8d8db0d9126bd996b
which changed the return value of submit_bio_wait() to return != 0 on
error, but didn't update the caller accordingly.

Fixes: 9e882242c6 ("block: Add submit_bio_wait(), remove from md")
Reported-by: Bill Kuzeja <William.Kuzeja@stratus.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
 drivers/md/raid10.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index d525d663bb22..98c856dd8ccc 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -2618,7 +2618,7 @@ static int narrow_write_error(struct r10bio *r10_bio, int i)
 				   choose_data_offset(r10_bio, rdev) +
 				   (sector - r10_bio->sector));
 		wbio->bi_bdev = rdev->bdev;
-		if (submit_bio_wait(WRITE, wbio) == 0)
+		if (submit_bio_wait(WRITE, wbio) < 0)
 			/* Failure! */
 			ok = rdev_set_badblocks(rdev, sector,
 						sectors, 0)
-- 
2.6.3


  parent reply	other threads:[~2015-11-09 11:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09 11:56 [patch added to the 3.12 stable tree] spi: fix pointer-integer size mismatch warning Jiri Slaby
2015-11-09 11:56 ` [patch added to the 3.12 stable tree] drm/nouveau/gem: return only valid domain when there's only one Jiri Slaby
2015-11-09 11:56 ` [patch added to the 3.12 stable tree] drm/i915: Restore lost DPLL register write on gen2-4 Jiri Slaby
2015-11-11 22:25   ` Luis Henriques
2015-11-12 13:10     ` Jiri Slaby
2015-11-09 11:56 ` [patch added to the 3.12 stable tree] rbd: require stable pages if message data CRCs are enabled Jiri Slaby
2015-11-09 11:56 ` [patch added to the 3.12 stable tree] Revert "ARM64: unwind: Fix PC calculation" Jiri Slaby
2015-11-09 11:56 ` [patch added to the 3.12 stable tree] dm btree: fix leak of bufio-backed block in btree_split_beneath error path Jiri Slaby
2015-11-09 11:56 ` [patch added to the 3.12 stable tree] xhci: handle no ping response error properly Jiri Slaby
2015-11-09 11:56 ` [patch added to the 3.12 stable tree] xhci: Add spurious wakeup quirk for LynxPoint-LP controllers Jiri Slaby
2015-11-09 11:56 ` [patch added to the 3.12 stable tree] xen-blkfront: check for null drvdata in blkback_changed (XenbusStateClosing) Jiri Slaby
2015-11-09 11:56 ` [patch added to the 3.12 stable tree] module: Fix locking in symbol_put_addr() Jiri Slaby
2015-11-09 11:56 ` [patch added to the 3.12 stable tree] crypto: api - Only abort operations on fatal signal Jiri Slaby
2015-11-09 11:56 ` [patch added to the 3.12 stable tree] md/raid1: submit_bio_wait() returns 0 on success Jiri Slaby
2015-11-09 11:56 ` Jiri Slaby [this message]
2015-11-09 11:56 ` [patch added to the 3.12 stable tree] mvsas: Fix NULL pointer dereference in mvs_slot_task_free Jiri Slaby
2015-11-09 11:56 ` [patch added to the 3.12 stable tree] IB/cm: Fix rb-tree duplicate free and use-after-free Jiri Slaby
2015-11-09 11:56 ` [patch added to the 3.12 stable tree] serial: 8250_pci: Add support for 16 port Exar boards Jiri Slaby
2015-11-09 11:56 ` [patch added to the 3.12 stable tree] serial: 8250_pci: Add support for 12 " Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447070198-11171-13-git-send-email-jslaby@suse.cz \
    --to=jslaby@suse.cz \
    --cc=Jes.Sorensen@redhat.com \
    --cc=neilb@suse.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.