From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvnva-0006gD-5P for qemu-devel@nongnu.org; Mon, 09 Nov 2015 10:00:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvnvW-0007DL-QC for qemu-devel@nongnu.org; Mon, 09 Nov 2015 10:00:14 -0500 Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:37679) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvnvW-0007DC-H8 for qemu-devel@nongnu.org; Mon, 09 Nov 2015 10:00:10 -0500 Received: by wmww144 with SMTP id w144so35958754wmw.0 for ; Mon, 09 Nov 2015 07:00:09 -0800 (PST) From: Leonid Bloch Date: Mon, 9 Nov 2015 16:59:22 +0200 Message-Id: <1447081170-11614-1-git-send-email-leonid.bloch@ravellosystems.com> Subject: [Qemu-devel] [PATCH v5 0/8] e1000: Various fixes and registers' implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Dmitry Fleytman , Jason Wang , Leonid Bloch , Shmulik Ladkani This series fixes issues with packet/octet counting in e1000's Statistic registers, fixes a bug in the packet address filtering procedure, and implements many MAC registers that were absent before, some Statistic counters among them. Besides this, the series introduces a parameter which, if set to "on" (default), will cause the entire MAC registers' array to migrate during live migration (please see patch #2 for details). The rational behind this is the ability to implement additional MAC registers in the future, without worrying about migration compatibility between future versions. For compatibility with previous versions, the above mentioned parameter can be set to "off". Also, a new array is introduced to control the access to the various MAC registers. This takes care of situations when a MAC register requires a certain parameter to be accessed, or is partially implemented, and requires a debug warning to be printed on access attempts. Additionally, several cosmetic changes are made. Differences v1-2: -------------------- * Wording of several commit messages corrected. * For trivially implemented Diagnostic registers, a debug message is added on read/write attempts, alerting of incomplete implementation. * Following testing on a physical device, only the lower 16 bits can now be read from AIT, and only the lower 4 - from FFMT*. * The grow_8reg_if_not_full function is rewritten. * inc_tx_bcast_or_mcast_count and increase_size_stats are now called from within e1000_send_packet, to avoid code duplication. Differences v2-3: -------------------- * Minor rewordings of some commit messages (0002, 0003). * Live migration capability is added to the newly implemented registers. Differences v3-4: -------------------- * Introduction of the "full_mac_registers" parameter (see above). * Reversion of the live migration handling introduced in v3. * Small alignment changes in patch #1 to correspond with the following patches. Differences v4-v5: -------------------- * Introduction of an array to control the access to the MAC registers. * Removal of the specific functions that warned of partial implementation on read/write from patch 4. * Adequate changes to patches 4 and 8: mainly adding the registers introduced there to the new array. The majority of these changes result from Jason Wang's review - thank you, Jason! Leonid Bloch (8): e1000: Cosmetic and alignment fixes e1000: Add support for migrating the entire MAC registers' array e1000: Introduced an array to control the access to the MAC registers e1000: Trivial implementation of various MAC registers e1000: Fixing the received/transmitted packets' counters e1000: Fixing the received/transmitted octets' counters e1000: Fixing the packet address filtering procedure e1000: Implementing various counters hw/net/e1000.c | 503 +++++++++++++++++++++++++++++++++++++++++----------- hw/net/e1000_regs.h | 8 +- include/hw/compat.h | 4 + 3 files changed, 406 insertions(+), 109 deletions(-) -- 2.4.3