From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751781AbbKJVvY (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 Nov 2015 16:51:24 -0500
Received: from mail-pa0-f52.google.com ([209.85.220.52]:34492 "EHLO
	mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751059AbbKJVvX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 Nov 2015 16:51:23 -0500
Message-ID: <1447192280.17135.83.camel@edumazet-glaptop2.roam.corp.google.com>
Subject: Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800
 Ethernet controller
From: Eric Dumazet <eric.dumazet@gmail.com>
To: =?ISO-8859-1?Q?M=E5ns_Rullg=E5rd?= <mans@mansr.com>
Cc: David Miller <davem@davemloft.net>, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, slash.tmp@free.fr
Date: Tue, 10 Nov 2015 13:51:20 -0800
In-Reply-To: <yw1xvb99pn43.fsf@unicorn.mansr.com>
References: <yw1xr3jxraqs.fsf@unicorn.mansr.com>
	 <20151110.150403.1195107307226924000.davem@davemloft.net>
	 <yw1xziylpoe8.fsf@unicorn.mansr.com>
	 <20151110.160615.1511568572619688788.davem@davemloft.net>
	 <yw1xvb99pn43.fsf@unicorn.mansr.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2015-11-10 at 21:21 +0000, Måns Rullgård wrote:

> Even ixgbe uses napi_complete() while netdevice.h says one should
> "consider using napi_complete_done() instead."  Did the author consider
> it and decide not to, or has the driver simply not been updated?

napi_complete_done() is quite new, very few drivers use it.

It still requires a tuning (/sys/class/net/ethX/gro_flush_timeout)

> 
> As for the napi_gro_receive() function, calling that instead of
> netif_receive_skb() is easy enough, or are there other things I should
> be doing in addition?

Nothing comes to mind, if you already have a NAPI context,
napi_gro_receive() is the way to go...