From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752576AbbKKOKX (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 Nov 2015 09:10:23 -0500
Received: from mail-pa0-f53.google.com ([209.85.220.53]:33116 "EHLO
	mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752046AbbKKOKW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 Nov 2015 09:10:22 -0500
Message-ID: <1447251020.17135.105.camel@edumazet-glaptop2.roam.corp.google.com>
Subject: Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800
 Ethernet controller
From: Eric Dumazet <eric.dumazet@gmail.com>
To: =?ISO-8859-1?Q?M=E5ns_Rullg=E5rd?= <mans@mansr.com>
Cc: Mason <slash.tmp@free.fr>, David Miller <davem@davemloft.net>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Date: Wed, 11 Nov 2015 06:10:20 -0800
In-Reply-To: <yw1xwptood3n.fsf@unicorn.mansr.com>
References: <yw1xr3jxraqs.fsf@unicorn.mansr.com>
	 <20151110.150403.1195107307226924000.davem@davemloft.net>
	 <yw1xziylpoe8.fsf@unicorn.mansr.com>
	 <20151110.160615.1511568572619688788.davem@davemloft.net>
	 <yw1xvb99pn43.fsf@unicorn.mansr.com>
	 <1447192280.17135.83.camel@edumazet-glaptop2.roam.corp.google.com>
	 <56434584.2090802@free.fr> <yw1xwptood3n.fsf@unicorn.mansr.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2015-11-11 at 13:54 +0000, Måns Rullgård wrote:
> Mason <slash.tmp@free.fr> writes:
> 
> > On 10/11/2015 22:51, Eric Dumazet wrote:
> >
> >> On Tue, 2015-11-10 at 21:21 +0000, Måns Rullgård wrote:
> >> 
> >>> Even ixgbe uses napi_complete() while netdevice.h says one should
> >>> "consider using napi_complete_done() instead."  Did the author consider
> >>> it and decide not to, or has the driver simply not been updated?
> >> 
> >> napi_complete_done() is quite new, very few drivers use it.
> >
> > I was hoping to back-port this driver for my platform. Are the recent
> > features used in the driver available in 4.1? What about 3.14?
> 
> xmit_more was added in 3.18, napi_complete_done() in 3.19.

xmit_more is a hint, you can simply consider skb->xmit_more being
replaced by 0 on old kernels if you want to backport.