All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bandan Das <bsd@redhat.com>
To: qemu-devel@nongnu.org
Cc: Bandan Das <bsd@redhat.com>, mst@redhat.com
Subject: [Qemu-devel] [PATCH 2/2] i440fx: print an error message if user tries to enable iommu
Date: Wed, 11 Nov 2015 22:36:16 -0500	[thread overview]
Message-ID: <1447299376-21252-3-git-send-email-bsd@redhat.com> (raw)
In-Reply-To: <1447299376-21252-1-git-send-email-bsd@redhat.com>

There's no indication of any sort that i440fx doesn't support
"iommu=on""

Signed-off-by: Bandan Das <bsd@redhat.com>
---
 hw/pci-host/piix.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 7b2fbf9..f12593a 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -301,6 +301,10 @@ static void i440fx_pcihost_realize(DeviceState *dev, Error **errp)
 static void i440fx_realize(PCIDevice *dev, Error **errp)
 {
     dev->config[I440FX_SMRAM] = 0x02;
+
+    if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) {
+        fprintf(stderr, "i440fx doesn't support emulated iommu\n");
+    }
 }
 
 PCIBus *i440fx_init(const char *host_type, const char *pci_type,
-- 
2.6.1

  parent reply	other threads:[~2015-11-12  3:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-12  3:36 [Qemu-devel] [PATCH 0/2] Minor cleanups when parsing the "iommu" option Bandan Das
2015-11-12  3:36 ` [Qemu-devel] [PATCH 1/2] q35: Check propery to determine if iommu is set Bandan Das
2015-11-12  3:36 ` Bandan Das [this message]
2015-11-12  8:46   ` [Qemu-devel] [PATCH 2/2] i440fx: print an error message if user tries to enable iommu Markus Armbruster
2015-11-12 22:42     ` Bandan Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447299376-21252-3-git-send-email-bsd@redhat.com \
    --to=bsd@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.