[PATCH 0/3] arm64: make some functions static

[PATCH 0/3] arm64: make some functions static

[Jisheng Zhang]

These functions are only called within the its own file, so they could
be declared static.

Jisheng Zhang (3):
  arm64: smp: make of_parse_and_init_cpus static
  arm64: mmu: make split_pud and fixup_executable static
  arm64: suspend: make hw_breakpoint_restore static

 arch/arm64/kernel/smp.c     | 2 +-
 arch/arm64/kernel/suspend.c | 2 +-
 arch/arm64/mm/mmu.c         | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.6.2

[PATCH 0/3] arm64: make some functions static

[Jisheng Zhang]

These functions are only called within the its own file, so they could
be declared static.

Jisheng Zhang (3):
  arm64: smp: make of_parse_and_init_cpus static
  arm64: mmu: make split_pud and fixup_executable static
  arm64: suspend: make hw_breakpoint_restore static

 arch/arm64/kernel/smp.c     | 2 +-
 arch/arm64/kernel/suspend.c | 2 +-
 arch/arm64/mm/mmu.c         | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.6.2

[PATCH 1/3] arm64: smp: make of_parse_and_init_cpus static

[Jisheng Zhang]

of_parse_and_init_cpus is only called from within smp.c, so it can be
declared static.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm64/kernel/smp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 2bbdc0e..b1adc51 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -473,7 +473,7 @@ acpi_parse_gic_cpu_interface(struct acpi_subtable_header *header,
  * cpu logical map array containing MPIDR values related to logical
  * cpus. Assumes that cpu_logical_map(0) has already been initialized.
  */
-void __init of_parse_and_init_cpus(void)
+static void __init of_parse_and_init_cpus(void)
 {
 	struct device_node *dn = NULL;
 
-- 
2.6.2

[PATCH 1/3] arm64: smp: make of_parse_and_init_cpus static

[Jisheng Zhang]

of_parse_and_init_cpus is only called from within smp.c, so it can be
declared static.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm64/kernel/smp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 2bbdc0e..b1adc51 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -473,7 +473,7 @@ acpi_parse_gic_cpu_interface(struct acpi_subtable_header *header,
  * cpu logical map array containing MPIDR values related to logical
  * cpus. Assumes that cpu_logical_map(0) has already been initialized.
  */
-void __init of_parse_and_init_cpus(void)
+static void __init of_parse_and_init_cpus(void)
 {
 	struct device_node *dn = NULL;
 
-- 
2.6.2

[PATCH 2/3] arm64: mmu: make split_pud and fixup_executable static

[Jisheng Zhang]

split_pud and fixup_executable are only called from within mmu.c, so
they can be declared static.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm64/mm/mmu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
index c2fa6b5..02306c3 100644
--- a/arch/arm64/mm/mmu.c
+++ b/arch/arm64/mm/mmu.c
@@ -165,7 +165,7 @@ static void alloc_init_pte(pmd_t *pmd, unsigned long addr,
 	} while (addr != end);
 }
 
-void split_pud(pud_t *old_pud, pmd_t *pmd)
+static void split_pud(pud_t *old_pud, pmd_t *pmd)
 {
 	unsigned long addr = pud_pfn(*old_pud) << PAGE_SHIFT;
 	pgprot_t prot = __pgprot(pud_val(*old_pud) ^ addr);
@@ -447,7 +447,7 @@ static void __init map_mem(void)
 	memblock_set_current_limit(MEMBLOCK_ALLOC_ANYWHERE);
 }
 
-void __init fixup_executable(void)
+static void __init fixup_executable(void)
 {
 #ifdef CONFIG_DEBUG_RODATA
 	/* now that we are actually fully mapped, make the start/end more fine grained */
-- 
2.6.2

[PATCH 2/3] arm64: mmu: make split_pud and fixup_executable static

[Jisheng Zhang]

split_pud and fixup_executable are only called from within mmu.c, so
they can be declared static.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm64/mm/mmu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
index c2fa6b5..02306c3 100644
--- a/arch/arm64/mm/mmu.c
+++ b/arch/arm64/mm/mmu.c
@@ -165,7 +165,7 @@ static void alloc_init_pte(pmd_t *pmd, unsigned long addr,
 	} while (addr != end);
 }
 
-void split_pud(pud_t *old_pud, pmd_t *pmd)
+static void split_pud(pud_t *old_pud, pmd_t *pmd)
 {
 	unsigned long addr = pud_pfn(*old_pud) << PAGE_SHIFT;
 	pgprot_t prot = __pgprot(pud_val(*old_pud) ^ addr);
@@ -447,7 +447,7 @@ static void __init map_mem(void)
 	memblock_set_current_limit(MEMBLOCK_ALLOC_ANYWHERE);
 }
 
-void __init fixup_executable(void)
+static void __init fixup_executable(void)
 {
 #ifdef CONFIG_DEBUG_RODATA
 	/* now that we are actually fully mapped, make the start/end more fine grained */
-- 
2.6.2

[PATCH 3/3] arm64: suspend: make hw_breakpoint_restore static

[Jisheng Zhang]

hw_breakpoint_restore is only used within suspend.c, so it can be
declared static.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm64/kernel/suspend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/suspend.c b/arch/arm64/kernel/suspend.c
index 40f7b33..fce95e1 100644
--- a/arch/arm64/kernel/suspend.c
+++ b/arch/arm64/kernel/suspend.c
@@ -41,7 +41,7 @@ void notrace __cpu_suspend_save(struct cpu_suspend_ctx *ptr,
  * time the notifier runs debug exceptions might have been enabled already,
  * with HW breakpoints registers content still in an unknown state.
  */
-void (*hw_breakpoint_restore)(void *);
+static void (*hw_breakpoint_restore)(void *);
 void __init cpu_suspend_set_dbg_restorer(void (*hw_bp_restore)(void *))
 {
 	/* Prevent multiple restore hook initializations */
-- 
2.6.2

[PATCH 3/3] arm64: suspend: make hw_breakpoint_restore static

[Jisheng Zhang]

hw_breakpoint_restore is only used within suspend.c, so it can be
declared static.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm64/kernel/suspend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/suspend.c b/arch/arm64/kernel/suspend.c
index 40f7b33..fce95e1 100644
--- a/arch/arm64/kernel/suspend.c
+++ b/arch/arm64/kernel/suspend.c
@@ -41,7 +41,7 @@ void notrace __cpu_suspend_save(struct cpu_suspend_ctx *ptr,
  * time the notifier runs debug exceptions might have been enabled already,
  * with HW breakpoints registers content still in an unknown state.
  */
-void (*hw_breakpoint_restore)(void *);
+static void (*hw_breakpoint_restore)(void *);
 void __init cpu_suspend_set_dbg_restorer(void (*hw_bp_restore)(void *))
 {
 	/* Prevent multiple restore hook initializations */
-- 
2.6.2

Re: [PATCH 0/3] arm64: make some functions static

[Catalin Marinas]

On Thu, Nov 12, 2015 at 08:04:41PM +0800, Jisheng Zhang wrote:
> These functions are only called within the its own file, so they could
> be declared static.
> 
> Jisheng Zhang (3):
>   arm64: smp: make of_parse_and_init_cpus static
>   arm64: mmu: make split_pud and fixup_executable static
>   arm64: suspend: make hw_breakpoint_restore static

Patches applied. Thanks.

-- 
Catalin

[PATCH 0/3] arm64: make some functions static

[Catalin Marinas]

On Thu, Nov 12, 2015 at 08:04:41PM +0800, Jisheng Zhang wrote:
> These functions are only called within the its own file, so they could
> be declared static.
> 
> Jisheng Zhang (3):
>   arm64: smp: make of_parse_and_init_cpus static
>   arm64: mmu: make split_pud and fixup_executable static
>   arm64: suspend: make hw_breakpoint_restore static

Patches applied. Thanks.

-- 
Catalin