All of lore.kernel.org
 help / color / mirror / Atom feed
From: Janusz Dziedzic <janusz.dziedzic@tieto.com>
To: linux-wireless@vger.kernel.org
Cc: ath9k-devel@lists.ath9k.org, Janusz Dziedzic <janusz.dziedzic@tieto.com>
Subject: [PATCH 02/12] ath9k: print real timer value
Date: Thu, 12 Nov 2015 14:15:39 +0100	[thread overview]
Message-ID: <1447334149-15507-2-git-send-email-janusz.dziedzic@tieto.com> (raw)
In-Reply-To: <1447334149-15507-1-git-send-email-janusz.dziedzic@tieto.com>

In case of low HZ before this patch we saw wrong
values in debug message. Print real timeout value.

Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
---
 drivers/net/wireless/ath/ath9k/channel.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/channel.c b/drivers/net/wireless/ath/ath9k/channel.c
index 35802c9..dddaaea 100644
--- a/drivers/net/wireless/ath/ath9k/channel.c
+++ b/drivers/net/wireless/ath/ath9k/channel.c
@@ -356,14 +356,16 @@ static void ath_chanctx_setup_timer(struct ath_softc *sc, u32 tsf_time)
 {
 	struct ath_common *common = ath9k_hw_common(sc->sc_ah);
 	struct ath_hw *ah = sc->sc_ah;
+	unsigned long timeout;
 
 	ath9k_hw_gen_timer_start(ah, sc->p2p_ps_timer, tsf_time, 1000000);
 	tsf_time -= ath9k_hw_gettsf32(ah);
-	tsf_time = msecs_to_jiffies(tsf_time / 1000) + 1;
-	mod_timer(&sc->sched.timer, jiffies + tsf_time);
+	timeout = msecs_to_jiffies(tsf_time / 1000) + 1;
+	mod_timer(&sc->sched.timer, jiffies + timeout);
 
 	ath_dbg(common, CHAN_CTX,
-		"Setup chanctx timer with timeout: %d ms\n", jiffies_to_msecs(tsf_time));
+		"Setup chanctx timer with timeout: %d (%d) ms\n",
+		tsf_time / 1000, jiffies_to_msecs(timeout));
 }
 
 static void ath_chanctx_handle_bmiss(struct ath_softc *sc,
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: Janusz Dziedzic <janusz.dziedzic@tieto.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 02/12] ath9k: print real timer value
Date: Thu, 12 Nov 2015 14:15:39 +0100	[thread overview]
Message-ID: <1447334149-15507-2-git-send-email-janusz.dziedzic@tieto.com> (raw)
In-Reply-To: <1447334149-15507-1-git-send-email-janusz.dziedzic@tieto.com>

In case of low HZ before this patch we saw wrong
values in debug message. Print real timeout value.

Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
---
 drivers/net/wireless/ath/ath9k/channel.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/channel.c b/drivers/net/wireless/ath/ath9k/channel.c
index 35802c9..dddaaea 100644
--- a/drivers/net/wireless/ath/ath9k/channel.c
+++ b/drivers/net/wireless/ath/ath9k/channel.c
@@ -356,14 +356,16 @@ static void ath_chanctx_setup_timer(struct ath_softc *sc, u32 tsf_time)
 {
 	struct ath_common *common = ath9k_hw_common(sc->sc_ah);
 	struct ath_hw *ah = sc->sc_ah;
+	unsigned long timeout;
 
 	ath9k_hw_gen_timer_start(ah, sc->p2p_ps_timer, tsf_time, 1000000);
 	tsf_time -= ath9k_hw_gettsf32(ah);
-	tsf_time = msecs_to_jiffies(tsf_time / 1000) + 1;
-	mod_timer(&sc->sched.timer, jiffies + tsf_time);
+	timeout = msecs_to_jiffies(tsf_time / 1000) + 1;
+	mod_timer(&sc->sched.timer, jiffies + timeout);
 
 	ath_dbg(common, CHAN_CTX,
-		"Setup chanctx timer with timeout: %d ms\n", jiffies_to_msecs(tsf_time));
+		"Setup chanctx timer with timeout: %d (%d) ms\n",
+		tsf_time / 1000, jiffies_to_msecs(timeout));
 }
 
 static void ath_chanctx_handle_bmiss(struct ath_softc *sc,
-- 
1.9.1

  reply	other threads:[~2015-11-12 13:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-12 13:15 [PATCH 01/12] ath9k: add debug messages to aggr/chanctx funcs Janusz Dziedzic
2015-11-12 13:15 ` [ath9k-devel] " Janusz Dziedzic
2015-11-12 13:15 ` Janusz Dziedzic [this message]
2015-11-12 13:15   ` [ath9k-devel] [PATCH 02/12] ath9k: print real timer value Janusz Dziedzic
2015-11-12 13:15 ` [PATCH 03/12] ath9k: queue null frames in case of MCC Janusz Dziedzic
2015-11-12 13:15   ` [ath9k-devel] " Janusz Dziedzic
2015-11-12 13:15 ` [PATCH 04/12] ath9k: P2P_CLIENT, send frames after 1ms AP/GO will aprear Janusz Dziedzic
2015-11-12 13:15   ` [ath9k-devel] " Janusz Dziedzic
2015-11-12 13:15 ` [PATCH 05/12] ath9k: use u32 when calculate tsf Janusz Dziedzic
2015-11-12 13:15   ` [ath9k-devel] " Janusz Dziedzic
2015-11-12 19:51   ` Kalle Valo
2015-11-12 19:51     ` [ath9k-devel] " Kalle Valo
2015-11-12 13:15 ` [PATCH 06/12] ath9k: setup correct skb priority for nullfunc Janusz Dziedzic
2015-11-12 13:15   ` [ath9k-devel] " Janusz Dziedzic
2015-11-12 13:15 ` [PATCH 07/12] ath9k: MCC enable Opportunistic Power Save Janusz Dziedzic
2015-11-12 13:15   ` [ath9k-devel] " Janusz Dziedzic
2015-11-12 13:15 ` [PATCH 08/12] ath9k: P2P_CLIENT, get/set NOA correctly Janusz Dziedzic
2015-11-12 13:15   ` [ath9k-devel] " Janusz Dziedzic
2015-11-12 13:15 ` [PATCH 09/12] ath9k: request NOA update when chanctx active Janusz Dziedzic
2015-11-12 13:15   ` [ath9k-devel] " Janusz Dziedzic
2015-11-12 13:59   ` kbuild test robot
2015-11-12 14:09     ` [ath9k-devel] " kbuild test robot
2015-11-12 13:15 ` [PATCH 10/12] ath9k: MCC, add NOA also in case of an AP Janusz Dziedzic
2015-11-12 13:15   ` [ath9k-devel] " Janusz Dziedzic
2015-11-12 13:15 ` [PATCH 11/12] ath9k: MCC add sta_ap_ratio module param Janusz Dziedzic
2015-11-12 13:15   ` [ath9k-devel] " Janusz Dziedzic
2015-11-12 13:15 ` [PATCH 12/12] ath9k: MCC, print time elapsed between events Janusz Dziedzic
2015-11-12 13:15   ` [ath9k-devel] " Janusz Dziedzic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447334149-15507-2-git-send-email-janusz.dziedzic@tieto.com \
    --to=janusz.dziedzic@tieto.com \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.