From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932281AbbKLQZR (ORCPT <rfc822;w@1wt.eu>);
	Thu, 12 Nov 2015 11:25:17 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:60569 "EHLO
	out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1754366AbbKLQZM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 12 Nov 2015 11:25:12 -0500
Message-Id: <1447345509.2333208.438003833.012C1A95@webmail.messagingengine.com>
X-Sasl-Enc: KZVQDZNtCUw+Guq3hXjXlHWPyZX02071lH8R/IQSKbcI 1447345509
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>, Netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        David Miller <davem@davemloft.net>, tgraf@suug.ch,
        Tom Herbert <tom@herbertland.com>, Jiri Benc <jbenc@redhat.com>,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
X-Mailer: MessagingEngine.com Webmail Interface - ajax-643af86c
Subject: Re: [PATCH] ip_tunnel: disable preemption when updating per-cpu tstats
Date: Thu, 12 Nov 2015 17:25:09 +0100
In-Reply-To: <1447342212-5543-1-git-send-email-Jason@zx2c4.com>
References: <1447342212-5543-1-git-send-email-Jason@zx2c4.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 12, 2015, at 16:30, Jason A. Donenfeld wrote:
>  	if (err > 0) {
> -               struct pcpu_sw_netstats *tstats = this_cpu_ptr(stats);
> -
> +               struct pcpu_sw_netstats *tstats;
> +               preempt_disable();
> +               tstats = this_cpu_ptr(stats);

The canonical way is get_cpu_ptr(stats) / put_cpu_ptr.

Bye,
Hannes