From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx8ji-0007lW-Bg for qemu-devel@nongnu.org; Fri, 13 Nov 2015 02:25:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zx8jd-0007MG-Em for qemu-devel@nongnu.org; Fri, 13 Nov 2015 02:25:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx8jd-0007MB-9F for qemu-devel@nongnu.org; Fri, 13 Nov 2015 02:25:25 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id BF7E4C0AED51 for ; Fri, 13 Nov 2015 07:25:24 +0000 (UTC) Message-ID: <1447399522.1400.71.camel@redhat.com> From: Gerd Hoffmann Date: Fri, 13 Nov 2015 08:25:22 +0100 In-Reply-To: <1447354243-31825-1-git-send-email-eblake@redhat.com> References: <1447354243-31825-1-git-send-email-eblake@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.5 v2] input: Document why x-input-send-event is still experimental List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, armbru@redhat.com On Do, 2015-11-12 at 11:50 -0700, Eric Blake wrote: > The x-input-send-event command was introduced in 2.2 with mention > that it is experimental, but now that several releases have elapsed > without any changes, it would be nice to document why that was done > and should still remain experimental in 2.5. > > Meanwhile, our documentation states that we prefer 'lower-case', > rather than 'CamelCase', for qapi enum values. The InputButton and > InputAxis enums violate this convention. However, because they are > currently used primarily for generating code that is used internally; > and their only exposure through QMP is via the experimental > 'x-input-send-event' command, we are free to change their spelling. > Of course, it would be nicer to delay such a change until the same > time we promote the command to non-experimental. Adding > documentation will help us remember to do that rename. > > We have plans to tighten the qapi generator to flag instances of > inconsistent use of naming conventions; if that lands first, it > will just need to whitelist these exceptions until the time we > settle on the final interface. Reviewed-by: Gerd Hoffmann