All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ranjith Thangavel <ranjithece24@gmail.com>
To: gregkh@linuxfoundation.org
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	ranjithece24@gmail.com
Subject: [PATCH] comedi: pcmmio: Fix coding style - use BIT macro
Date: Sat, 14 Nov 2015 18:54:04 +0530	[thread overview]
Message-ID: <1447507444-11504-1-git-send-email-ranjithece24@gmail.com> (raw)

BIT macro is used for defining BIT location instead of
shifting operator - coding style issue

Signed-off-by: Ranjith Thangavel <ranjithece24@gmail.com>
---
 drivers/staging/comedi/drivers/pcmmio.c |   20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/comedi/drivers/pcmmio.c b/drivers/staging/comedi/drivers/pcmmio.c
index f7ec224..f2aedc21 100644
--- a/drivers/staging/comedi/drivers/pcmmio.c
+++ b/drivers/staging/comedi/drivers/pcmmio.c
@@ -84,20 +84,20 @@
 #define PCMMIO_AI_LSB_REG			0x00
 #define PCMMIO_AI_MSB_REG			0x01
 #define PCMMIO_AI_CMD_REG			0x02
-#define PCMMIO_AI_CMD_SE				BIT(7)
+#define PCMMIO_AI_CMD_SE			BIT(7)
 #define PCMMIO_AI_CMD_ODD_CHAN			BIT(6)
 #define PCMMIO_AI_CMD_CHAN_SEL(x)		(((x) & 0x3) << 4)
 #define PCMMIO_AI_CMD_RANGE(x)			(((x) & 0x3) << 2)
-#define PCMMIO_RESOURCE_REG				0x02
+#define PCMMIO_RESOURCE_REG			0x02
 #define PCMMIO_RESOURCE_IRQ(x)			(((x) & 0xf) << 0)
 #define PCMMIO_AI_STATUS_REG			0x03
 #define PCMMIO_AI_STATUS_DATA_READY		BIT(7)
-#define PCMMIO_AI_STATUS_DATA_DMA_PEND	BIT(6)
-#define PCMMIO_AI_STATUS_CMD_DMA_PEND	BIT(5)
+#define PCMMIO_AI_STATUS_DATA_DMA_PEND		BIT(6)
+#define PCMMIO_AI_STATUS_CMD_DMA_PEND		BIT(5)
 #define PCMMIO_AI_STATUS_IRQ_PEND		BIT(4)
-#define PCMMIO_AI_STATUS_DATA_DRQ_ENA	BIT(2)
+#define PCMMIO_AI_STATUS_DATA_DRQ_ENA		BIT(2)
 #define PCMMIO_AI_STATUS_REG_SEL		BIT(3)
-#define PCMMIO_AI_STATUS_CMD_DRQ_ENA	BIT(1)
+#define PCMMIO_AI_STATUS_CMD_DRQ_ENA		BIT(1)
 #define PCMMIO_AI_STATUS_IRQ_ENA		BIT(0)
 #define PCMMIO_AI_RES_ENA_REG			0x03
 #define PCMMIO_AI_RES_ENA_CMD_REG_ACCESS	0
@@ -126,12 +126,12 @@
 #define PCMMIO_AO_CMD_CHAN_SEL_ALL		(0x0f << 0)
 #define PCMMIO_AO_STATUS_REG			0x0b
 #define PCMMIO_AO_STATUS_DATA_READY		BIT(7)
-#define PCMMIO_AO_STATUS_DATA_DMA_PEND	BIT(6)
-#define PCMMIO_AO_STATUS_CMD_DMA_PEND	BIT(5)
+#define PCMMIO_AO_STATUS_DATA_DMA_PEND		BIT(6)
+#define PCMMIO_AO_STATUS_CMD_DMA_PEND		BIT(5)
 #define PCMMIO_AO_STATUS_IRQ_PEND		BIT(4)
-#define PCMMIO_AO_STATUS_DATA_DRQ_ENA	BIT(2)
+#define PCMMIO_AO_STATUS_DATA_DRQ_ENA		BIT(2)
 #define PCMMIO_AO_STATUS_REG_SEL		BIT(3)
-#define PCMMIO_AO_STATUS_CMD_DRQ_ENA	BIT(1)
+#define PCMMIO_AO_STATUS_CMD_DRQ_ENA		BIT(1)
 #define PCMMIO_AO_STATUS_IRQ_ENA		BIT(0)
 #define PCMMIO_AO_RESOURCE_ENA_REG		0x0b
 #define PCMMIO_AO_2ND_DAC_OFFSET		0x04
-- 
1.7.10.4


             reply	other threads:[~2015-11-14 13:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-14 13:24 Ranjith Thangavel [this message]
2015-11-18 15:51 ` [PATCH] comedi: pcmmio: Fix coding style - use BIT macro Ian Abbott
  -- strict thread matches above, loose matches on Subject: below --
2015-11-09 17:44 Ranjith T
2015-11-11 13:45 ` Ranjith T
2015-11-11 15:34   ` Greg KH
2015-11-09 15:09 Ranjith
2015-11-09 16:56 ` Hartley Sweeten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447507444-11504-1-git-send-email-ranjithece24@gmail.com \
    --to=ranjithece24@gmail.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.