From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v5 8/9] libxc: rework of domain builder's page table handler Date: Mon, 16 Nov 2015 13:40:05 +0000 Message-ID: <1447681205.27871.99.camel@citrix.com> References: <1447335816-31772-1-git-send-email-jgross@suse.com> <1447335816-31772-9-git-send-email-jgross@suse.com> <20151112134724.GJ24281@zion.uk.xensource.com> <564498C1.60608@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <564498C1.60608@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Juergen Gross , Wei Liu Cc: stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, roger.pau@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-11-12 at 14:48 +0100, Juergen Gross wrote: > On 12/11/15 14:47, Wei Liu wrote: > > On Thu, Nov 12, 2015 at 02:43:35PM +0100, Juergen Gross wrote: > > > In order to prepare a p2m list outside of the initial kernel mapping > > > do a rework of the domain builder's page table handler. The goal is > > > to be able to use common helpers for page table allocation and setup > > > for initial kernel page tables and page tables mapping the p2m list. > > > This is achieved by supporting multiple mapping areas. The mapped > > > virtual addresses of the single areas must not overlap, while the > > > page tables of a new area added might already be partially present. > > > Especially the top level page table is existing only once, of course. > > > > > > Currently restrict the number of mappings to 1 because the only > > > mapping > > > now is the initial mapping created by toolstack. There should not be > > > behaviour change and guest visible change introduced. > > > > > > Signed-off-by: Juergen Gross > > > Reviewed-by: Wei Liu > > > Missing closing ">". :-) > > Uuh, mouse buffer underrun, I guess ;-) > > > > > I don't think you need to resend though. > > Thanks, I fixed while I was applying the whole series. Ian.