From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752183AbbKPOqD (ORCPT ); Mon, 16 Nov 2015 09:46:03 -0500 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:55767 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750921AbbKPOp7 (ORCPT ); Mon, 16 Nov 2015 09:45:59 -0500 From: Liviu Dudau To: Russell King , Mark Yao , Heiko Stuebner , Philipp Zabel , Daniel Vetter , David Airlie , Eric Anholt Cc: linux-rockchip , LAKML , dri-devel , LKML Subject: [PATCH 0/2] Improve drm_of_component_probe() and move rockchip to use it Date: Mon, 16 Nov 2015 14:44:51 +0000 Message-Id: <1447685093-26129-1-git-send-email-Liviu.Dudau@arm.com> X-Mailer: git-send-email 2.6.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, When I have introduced the drm_of_component_probe() function I have managed to break rockchip's DRM driver as the compare_of() function had to match both local crtc ports and remote encoder ones. As suggested by Russell King, I have now enhanced the drm_of_component_probe() function to take two comparison functions, and converted (again) rockchip driver to use it. I would really like to get some Tested-By this time if possible from IMX, Armada and Rockchip developers as I lack hardware to do that myself. The only thing not implemented from Russell's suggestion list is the renaming of the function into drm_kms_component_probe(). Best regards, Liviu Liviu Dudau (2): drm: Improve drm_of_component_probe() to correctly handle ports and remote ports. drm/rockchip: Convert the probe function to the generic drm_of_component_probe() drivers/gpu/drm/armada/armada_drv.c | 3 +- drivers/gpu/drm/drm_of.c | 23 +++++-- drivers/gpu/drm/imx/imx-drm-core.c | 3 +- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 98 ++++++----------------------- include/drm/drm_of.h | 6 +- 5 files changed, 44 insertions(+), 89 deletions(-) -- 2.6.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liviu Dudau Subject: [PATCH 0/2] Improve drm_of_component_probe() and move rockchip to use it Date: Mon, 16 Nov 2015 14:44:51 +0000 Message-ID: <1447685093-26129-1-git-send-email-Liviu.Dudau@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King , Mark Yao , Heiko Stuebner , Philipp Zabel , Daniel Vetter , David Airlie , Eric Anholt Cc: linux-rockchip , dri-devel , LAKML , LKML List-Id: linux-rockchip.vger.kernel.org SGVsbG8sCgpXaGVuIEkgaGF2ZSBpbnRyb2R1Y2VkIHRoZSBkcm1fb2ZfY29tcG9uZW50X3Byb2Jl KCkgZnVuY3Rpb24gSSBoYXZlIG1hbmFnZWQgdG8KYnJlYWsgcm9ja2NoaXAncyBEUk0gZHJpdmVy IGFzIHRoZSBjb21wYXJlX29mKCkgZnVuY3Rpb24gaGFkIHRvIG1hdGNoIGJvdGggbG9jYWwKY3J0 YyBwb3J0cyBhbmQgcmVtb3RlIGVuY29kZXIgb25lcy4gQXMgc3VnZ2VzdGVkIGJ5IFJ1c3NlbGwg S2luZywgSSBoYXZlIG5vdwplbmhhbmNlZCB0aGUgZHJtX29mX2NvbXBvbmVudF9wcm9iZSgpIGZ1 bmN0aW9uIHRvIHRha2UgdHdvIGNvbXBhcmlzb24gZnVuY3Rpb25zLAphbmQgY29udmVydGVkIChh Z2Fpbikgcm9ja2NoaXAgZHJpdmVyIHRvIHVzZSBpdC4KCkkgd291bGQgcmVhbGx5IGxpa2UgdG8g Z2V0IHNvbWUgVGVzdGVkLUJ5IHRoaXMgdGltZSBpZiBwb3NzaWJsZSBmcm9tIElNWCwgQXJtYWRh CmFuZCBSb2NrY2hpcCBkZXZlbG9wZXJzIGFzIEkgbGFjayBoYXJkd2FyZSB0byBkbyB0aGF0IG15 c2VsZi4KClRoZSBvbmx5IHRoaW5nIG5vdCBpbXBsZW1lbnRlZCBmcm9tIFJ1c3NlbGwncyBzdWdn ZXN0aW9uIGxpc3QgaXMgdGhlIHJlbmFtaW5nIG9mCnRoZSBmdW5jdGlvbiBpbnRvIGRybV9rbXNf Y29tcG9uZW50X3Byb2JlKCkuCgpCZXN0IHJlZ2FyZHMsCkxpdml1CgpMaXZpdSBEdWRhdSAoMik6 CiAgZHJtOiBJbXByb3ZlIGRybV9vZl9jb21wb25lbnRfcHJvYmUoKSB0byBjb3JyZWN0bHkgaGFu ZGxlIHBvcnRzIGFuZCByZW1vdGUgcG9ydHMuCiAgZHJtL3JvY2tjaGlwOiBDb252ZXJ0IHRoZSBw cm9iZSBmdW5jdGlvbiB0byB0aGUgZ2VuZXJpYyBkcm1fb2ZfY29tcG9uZW50X3Byb2JlKCkKCiBk cml2ZXJzL2dwdS9kcm0vYXJtYWRhL2FybWFkYV9kcnYuYyAgICAgICAgIHwgIDMgKy0KIGRyaXZl cnMvZ3B1L2RybS9kcm1fb2YuYyAgICAgICAgICAgICAgICAgICAgfCAyMyArKysrKy0tCiBkcml2 ZXJzL2dwdS9kcm0vaW14L2lteC1kcm0tY29yZS5jICAgICAgICAgIHwgIDMgKy0KIGRyaXZlcnMv Z3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZHJ2LmMgfCA5OCArKysrKystLS0tLS0tLS0t LS0tLS0tLS0tLS0tLQogaW5jbHVkZS9kcm0vZHJtX29mLmggICAgICAgICAgICAgICAgICAgICAg ICB8ICA2ICstCiA1IGZpbGVzIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKyksIDg5IGRlbGV0aW9u cygtKQoKLS0gCjIuNi4wCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liviu.Dudau@arm.com (Liviu Dudau) Date: Mon, 16 Nov 2015 14:44:51 +0000 Subject: [PATCH 0/2] Improve drm_of_component_probe() and move rockchip to use it Message-ID: <1447685093-26129-1-git-send-email-Liviu.Dudau@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, When I have introduced the drm_of_component_probe() function I have managed to break rockchip's DRM driver as the compare_of() function had to match both local crtc ports and remote encoder ones. As suggested by Russell King, I have now enhanced the drm_of_component_probe() function to take two comparison functions, and converted (again) rockchip driver to use it. I would really like to get some Tested-By this time if possible from IMX, Armada and Rockchip developers as I lack hardware to do that myself. The only thing not implemented from Russell's suggestion list is the renaming of the function into drm_kms_component_probe(). Best regards, Liviu Liviu Dudau (2): drm: Improve drm_of_component_probe() to correctly handle ports and remote ports. drm/rockchip: Convert the probe function to the generic drm_of_component_probe() drivers/gpu/drm/armada/armada_drv.c | 3 +- drivers/gpu/drm/drm_of.c | 23 +++++-- drivers/gpu/drm/imx/imx-drm-core.c | 3 +- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 98 ++++++----------------------- include/drm/drm_of.h | 6 +- 5 files changed, 44 insertions(+), 89 deletions(-) -- 2.6.0