From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH 2/2] Nested hosts: Use hostnamepath() in create_webfile Date: Mon, 16 Nov 2015 15:37:28 +0000 Message-ID: <1447688248.27871.112.camel@citrix.com> References: <22089.62523.390831.567056@mariner.uk.xensource.com> <1447687244-16230-1-git-send-email-ian.jackson@eu.citrix.com> <1447687244-16230-2-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZyLqx-0000Kx-Bl for xen-devel@lists.xenproject.org; Mon, 16 Nov 2015 15:37:59 +0000 In-Reply-To: <1447687244-16230-2-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , xen-devel@lists.xenproject.org Cc: Robert Ho List-Id: xen-devel@lists.xenproject.org On Mon, 2015-11-16 at 15:20 +0000, Ian Jackson wrote: > create_webfile needs a pathname in the shared public-html directory. > These paths need to be (a) stable (b) unique across all running jobs. > We achieve this by basing the filenames on the hostname and (for a > guest) the guest name. > > But for an L2 guest we need to include the physical host name too, > because the L1 `host' is not unique. > > Fix this by using hostnamepath(), replacing the open-coded single > iteration. > > Reported-by: Ian Campbell > CC: Robert Ho > Signed-off-by: Ian Jackson Acked-by: Ian Campbell