From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752784AbbKRGNo (ORCPT ); Wed, 18 Nov 2015 01:13:44 -0500 Received: from cn.fujitsu.com ([59.151.112.132]:33280 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751501AbbKRGNn (ORCPT ); Wed, 18 Nov 2015 01:13:43 -0500 X-IronPort-AV: E=Sophos;i="5.20,242,1444665600"; d="scan'208";a="569518" From: "Wei, Jiangang" To: "standby24x7@gmail.com" CC: "r.baldyga@samsung.com" , "rdunlap@infradead.org" , "linux-kernel@vger.kernel.org" , "balbi@ti.com" , "jkosina@suse.cz" Subject: Re: [PATCH] tools: ffs-aio-example: free memory upon failure Thread-Topic: [PATCH] tools: ffs-aio-example: free memory upon failure Thread-Index: AQHRGrY9ZnQMbd91nU+xmCyH93OB6J6g1PqA Date: Wed, 18 Nov 2015 06:13:34 +0000 Message-ID: <1447827215.8767.3.camel@localhost> References: <1447049776-23413-1-git-send-email-weijg.fnst@cn.fujitsu.com> In-Reply-To: <1447049776-23413-1-git-send-email-weijg.fnst@cn.fujitsu.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.167.226.50] Content-Type: text/plain; charset="utf-8" Content-ID: <438845361D17AD499B16E458483D6F85@fujitsu.local> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tAI6Dx1i015296 To whom it may concern： Sorry to bother again, But any comment about this patch？ Regards, wei On Mon, 2015-11-09 at 14:16 +0800, Wei Jiangang wrote: > Free buffer to avoid memory leak upon failure occurs. > > Signed-off-by: Wei Jiangang > --- > tools/usb/ffs-aio-example/multibuff/device_app/aio_multibuff.c | 4 ++++ > tools/usb/ffs-aio-example/simple/device_app/aio_simple.c | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/tools/usb/ffs-aio-example/multibuff/device_app/aio_multibuff.c b/tools/usb/ffs-aio-example/multibuff/device_app/aio_multibuff.c > index aaca1f44e788..3eb1a92baacf 100644 > --- a/tools/usb/ffs-aio-example/multibuff/device_app/aio_multibuff.c > +++ b/tools/usb/ffs-aio-example/multibuff/device_app/aio_multibuff.c > @@ -263,20 +263,24 @@ int main(int argc, char *argv[]) > sprintf(ep_path, "%s/ep0", argv[1]); > ep0 = open(ep_path, O_RDWR); > if (ep0 < 0) { > + free(ep_path); > perror("unable to open ep0"); > return 1; > } > if (write(ep0, &descriptors, sizeof(descriptors)) < 0) { > + free(ep_path); > perror("unable do write descriptors"); > return 1; > } > if (write(ep0, &strings, sizeof(strings)) < 0) { > + free(ep_path); > perror("unable to write strings"); > return 1; > } > sprintf(ep_path, "%s/ep1", argv[1]); > ep1 = open(ep_path, O_RDWR); > if (ep1 < 0) { > + free(ep_path); > perror("unable to open ep1"); > return 1; > } > diff --git a/tools/usb/ffs-aio-example/simple/device_app/aio_simple.c b/tools/usb/ffs-aio-example/simple/device_app/aio_simple.c > index 1f44a29818bf..ac96892ca5d2 100644 > --- a/tools/usb/ffs-aio-example/simple/device_app/aio_simple.c > +++ b/tools/usb/ffs-aio-example/simple/device_app/aio_simple.c > @@ -234,14 +234,17 @@ int main(int argc, char *argv[]) > sprintf(ep_path, "%s/ep0", argv[1]); > ep0 = open(ep_path, O_RDWR); > if (ep0 < 0) { > + free(ep_path); > perror("unable to open ep0"); > return 1; > } > if (write(ep0, &descriptors, sizeof(descriptors)) < 0) { > + free(ep_path); > perror("unable do write descriptors"); > return 1; > } > if (write(ep0, &strings, sizeof(strings)) < 0) { > + free(ep_path); > perror("unable to write strings"); > return 1; > } > @@ -249,6 +252,7 @@ int main(int argc, char *argv[]) > sprintf(ep_path, "%s/ep%d", argv[1], i+1); > ep[i] = open(ep_path, O_RDWR); > if (ep[i] < 0) { > + free(ep_path); > printf("unable to open ep%d: %s\n", i+1, > strerror(errno)); > return 1; {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I