All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Gromm <christian.gromm@microchip.com>
To: gregkh@linuxfoundation.org
Cc: Christian Gromm <christian.gromm@microchip.com>,
	driverdev-devel@linuxdriverproject.org
Subject: [PATCH 12/28] staging: most: move initialization of pointer
Date: Wed, 18 Nov 2015 13:43:36 +0100	[thread overview]
Message-ID: <1447850632-16782-13-git-send-email-christian.gromm@microchip.com> (raw)
In-Reply-To: <1447850632-16782-1-git-send-email-christian.gromm@microchip.com>

This patch makes function store_add_link initialize the pointer to an AIM
right before the channel is probed.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
---
 drivers/staging/most/mostcore/core.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c
index d5ef61d..21c550c 100644
--- a/drivers/staging/most/mostcore/core.c
+++ b/drivers/staging/most/mostcore/core.c
@@ -996,11 +996,14 @@ static ssize_t store_add_link(struct most_aim_obj *aim_obj,
 	else
 		return -ENOSPC;
 
+	*aim_ptr = aim_obj->driver;
 	ret = aim_obj->driver->probe_channel(c->iface, c->channel_id,
 					     &c->cfg, &c->kobj, mdev_devnod);
-	if (ret)
+	if (ret) {
+		*aim_ptr = NULL;
 		return ret;
-	*aim_ptr = aim_obj->driver;
+	}
+
 	return len;
 }
 
-- 
1.7.9.5

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2015-11-18 12:44 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18 12:43 [PATCH 00/28] staging: most: bug-fixes and clean-up Christian Gromm
2015-11-18 12:43 ` [PATCH 01/28] staging: most: remove unnecessary keep_mbo variable Christian Gromm
2015-11-18 12:43 ` [PATCH 02/28] staging: most: rename variables Christian Gromm
2015-11-18 12:43 ` [PATCH 03/28] staging: most: simplify expression Christian Gromm
2015-11-18 12:43 ` [PATCH 04/28] staging: most: unify types Christian Gromm
2015-11-18 12:43 ` [PATCH 05/28] staging: most: use min_t Christian Gromm
2015-11-18 12:43 ` [PATCH 06/28] staging: most: fix mbo leak Christian Gromm
2015-11-19  5:11   ` Sudip Mukherjee
2015-11-19  9:42     ` Christian Gromm
2015-11-18 12:43 ` [PATCH 07/28] staging: most: fix tracking of MBO offset Christian Gromm
2015-11-18 12:43 ` [PATCH 08/28] staging: most: use readl and writel functions Christian Gromm
2015-11-18 12:43 ` [PATCH 09/28] staging: most: remove function destroy_most_c_obj Christian Gromm
2015-11-18 12:43 ` [PATCH 10/28] staging: most: add missing call to ida_simple_remove Christian Gromm
2015-11-18 12:43 ` [PATCH 11/28] staging: most: move call to disconnect_channel callback Christian Gromm
2015-11-18 12:43 ` Christian Gromm [this message]
2015-11-18 13:16   ` [PATCH 12/28] staging: most: move initialization of pointer Dan Carpenter
2015-11-18 12:43 ` [PATCH 13/28] staging: most: move mutex Christian Gromm
2015-11-18 12:43 ` [PATCH 14/28] staging: most: move channel disconnect to function most_deregister_interface Christian Gromm
2015-11-18 12:43 ` [PATCH 15/28] staging: most: remove tainted flag Christian Gromm
2015-11-18 12:43 ` [PATCH 16/28] staging: most: remove reference counter Christian Gromm
2015-11-18 12:43 ` [PATCH 17/28] staging: most: remove code to destroy channel Christian Gromm
2015-11-18 12:43 ` [PATCH 18/28] staging: most: remove redundant mutexes Christian Gromm
2015-11-18 12:43 ` [PATCH 19/28] staging: most: remove redundant call to wake_up_interruptible Christian Gromm
2015-11-18 12:43 ` [PATCH 20/28] staging: most: encapsulate shared code Christian Gromm
2015-11-18 12:43 ` [PATCH 21/28] staging: most: fix retrieval of buffer availability Christian Gromm
2015-11-18 12:43 ` [PATCH 22/28] staging: most: rename variable channel Christian Gromm
2015-11-18 12:43 ` [PATCH 23/28] staging: most: fix race conditions Christian Gromm
2015-11-18 12:43 ` [PATCH 24/28] staging: most: change type of access_ref Christian Gromm
2015-11-18 12:43 ` [PATCH 25/28] staging: most: remove stacked_mbo Christian Gromm
2015-11-18 12:43 ` [PATCH 26/28] staging: most: rearrange function aim_write Christian Gromm
2015-11-19  7:48   ` Dan Carpenter
2015-11-18 12:43 ` [PATCH 27/28] staging: most: add statistics for dropped packets Christian Gromm
2015-11-18 13:28   ` Dan Carpenter
2015-11-18 12:43 ` [PATCH 28/28] staging: most: remove 2nd forward declaration of struct most_aim Christian Gromm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447850632-16782-13-git-send-email-christian.gromm@microchip.com \
    --to=christian.gromm@microchip.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.