All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glen Lee <glen.lee@atmel.com>
To: <gregkh@linuxfoundation.org>
Cc: <devel@driverdev.osuosl.org>, <linux-wireless@vger.kernel.org>,
	<tony.cho@atmel.com>, <glen.lee@atmel.com>, <leo.kim@atmel.com>,
	<austin.shin@atmel.com>, <adel.noureldin@atmel.com>,
	<adham.abozaeid@atmel.com>, <Nicolas.FERRE@atmel.com>
Subject: [PATCH 06/26] staging: wilc1000: rename u8P2P_oui variable
Date: Thu, 19 Nov 2015 15:56:15 +0900	[thread overview]
Message-ID: <1447916195-24851-6-git-send-email-glen.lee@atmel.com> (raw)
In-Reply-To: <1447916195-24851-1-git-send-email-glen.lee@atmel.com>

From: Leo Kim <leo.kim@atmel.com>

This patch renames u8P2P_oui variable to p2p_oui to avoid camelcase.
And, remove the relation comment.

Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
---
 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index 3b072ef..6ab4a79 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -171,8 +171,7 @@ struct p2p_mgmt_data {
 
 static u8 wlan_channel = INVALID_CHANNEL;
 static u8 curr_channel;
-
-static u8 u8P2P_oui[] = {0x50, 0x6f, 0x9A, 0x09};
+static u8 p2p_oui[] = {0x50, 0x6f, 0x9A, 0x09};
 static u8 u8P2Plocalrandom = 0x01;
 static u8 u8P2Precvrandom = 0x00;
 static u8 u8P2P_vendorspec[] = {0xdd, 0x05, 0x00, 0x08, 0x40, 0x03};
@@ -1997,9 +1996,7 @@ void WILC_WFI_p2p_rx (struct net_device *dev, u8 *buff, u32 size)
 					break;
 
 				case PUBLIC_ACT_VENDORSPEC:
-					/*Now we have a public action vendor specific action frame, check if its a p2p public action frame
-					 * based on the standard its should have the p2p_oui attribute with the following values 50 6f 9A 09*/
-					if (!memcmp(u8P2P_oui, &buff[ACTION_SUBTYPE_ID + 1], 4)) {
+					if (!memcmp(p2p_oui, &buff[ACTION_SUBTYPE_ID + 1], 4)) {
 						if ((buff[P2P_PUB_ACTION_SUBTYPE] == GO_NEG_REQ || buff[P2P_PUB_ACTION_SUBTYPE] == GO_NEG_RSP))	{
 							if (!bWilc_ie) {
 								for (i = P2P_PUB_ACTION_SUBTYPE; i < size; i++)	{
@@ -2016,7 +2013,7 @@ void WILC_WFI_p2p_rx (struct net_device *dev, u8 *buff, u32 size)
 							if ((buff[P2P_PUB_ACTION_SUBTYPE] == GO_NEG_REQ || buff[P2P_PUB_ACTION_SUBTYPE] == GO_NEG_RSP
 							      || buff[P2P_PUB_ACTION_SUBTYPE] == P2P_INV_REQ || buff[P2P_PUB_ACTION_SUBTYPE] == P2P_INV_RSP)) {
 								for (i = P2P_PUB_ACTION_SUBTYPE + 2; i < size; i++) {
-									if (buff[i] == P2PELEM_ATTR_ID && !(memcmp(u8P2P_oui, &buff[i + 2], 4))) {
+									if (buff[i] == P2PELEM_ATTR_ID && !(memcmp(p2p_oui, &buff[i + 2], 4))) {
 										WILC_WFI_CfgParseRxAction(&buff[i + 6], size - (i + 6));
 										break;
 									}
@@ -2292,9 +2289,7 @@ static int mgmt_tx(struct wiphy *wiphy,
 
 				case PUBLIC_ACT_VENDORSPEC:
 				{
-					/*Now we have a public action vendor specific action frame, check if its a p2p public action frame
-					 * based on the standard its should have the p2p_oui attribute with the following values 50 6f 9A 09*/
-					if (!memcmp(u8P2P_oui, &buf[ACTION_SUBTYPE_ID + 1], 4)) {
+					if (!memcmp(p2p_oui, &buf[ACTION_SUBTYPE_ID + 1], 4)) {
 						/*For the connection of two WILC's connection generate a rand number to determine who will be a GO*/
 						if ((buf[P2P_PUB_ACTION_SUBTYPE] == GO_NEG_REQ || buf[P2P_PUB_ACTION_SUBTYPE] == GO_NEG_RSP)) {
 							if (u8P2Plocalrandom == 1 && u8P2Precvrandom < u8P2Plocalrandom) {
@@ -2311,7 +2306,7 @@ static int mgmt_tx(struct wiphy *wiphy,
 
 								/*Search for the p2p information information element , after the Public action subtype theres a byte for teh dialog token, skip that*/
 								for (i = P2P_PUB_ACTION_SUBTYPE + 2; i < len; i++) {
-									if (buf[i] == P2PELEM_ATTR_ID && !(memcmp(u8P2P_oui, &buf[i + 2], 4))) {
+									if (buf[i] == P2PELEM_ATTR_ID && !(memcmp(p2p_oui, &buf[i + 2], 4))) {
 										if (buf[P2P_PUB_ACTION_SUBTYPE] == P2P_INV_REQ || buf[P2P_PUB_ACTION_SUBTYPE] == P2P_INV_RSP)
 											WILC_WFI_CfgParseTxAction(&mgmt_tx->buff[i + 6], len - (i + 6), true, nic->iftype);
 
-- 
1.9.1


  parent reply	other threads:[~2015-11-19  6:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19  6:56 [PATCH 01/26] staging: wilc1000: rename u32LastScannedNtwrksCountShadow variable Glen Lee
2015-11-19  6:56 ` [PATCH 02/26] staging: wilc1000: rename astrLastScannedNtwrksShadow variable Glen Lee
2015-11-19  6:56 ` [PATCH 03/26] staging: wilc1000: rename WILC_WFI_2ghz_channels variable Glen Lee
2015-11-19  6:56 ` [PATCH 04/26] staging: wilc1000: rename WILC_WFI_rates variable Glen Lee
2015-11-19  6:56 ` [PATCH 05/26] staging: wilc1000: rename u8WLANChannel variable Glen Lee
2015-11-19  6:56 ` Glen Lee [this message]
2015-11-19  6:56 ` [PATCH 07/26] staging: wilc1000: rename u8P2Plocalrandom variable Glen Lee
2015-11-19  6:56 ` [PATCH 08/26] staging: wilc1000: rename u8P2Precvrandom variable Glen Lee
2015-11-19  6:56 ` [PATCH 09/26] staging: wilc1000: rename u8P2P_vendorspec variable Glen Lee
2015-11-19  6:56 ` [PATCH 10/26] staging: wilc1000: rename bWilc_ie variable Glen Lee
2015-11-19  6:56 ` [PATCH 11/26] staging: wilc1000: rename duringIP_TIME variable Glen Lee
2015-11-19  6:56 ` [PATCH 12/26] staging: wilc1000: rename wilc_connected_SSID variable Glen Lee
2015-11-19  6:56 ` [PATCH 13/26] staging: wilc1000: clear_shadow_scan: remove unused argument Glen Lee
2015-11-19  6:56 ` [PATCH 14/26] staging: wilc1000: rename pUserVoid in refresh_scan function Glen Lee
2015-11-19  6:56 ` [PATCH 15/26] staging: wilc1000: rename bDirectScan " Glen Lee
2015-11-19  6:56 ` [PATCH 16/26] staging: wilc1000: rename pstrNetworkInfo variable Glen Lee
2015-11-19  6:56 ` [PATCH 17/26] staging: wilc1000: rename s32Freq variable Glen Lee
2015-11-19  6:56 ` [PATCH 18/26] staging: wilc1000: reset_shadow_found: remove unused argument Glen Lee
2015-11-19  6:56 ` [PATCH 19/26] staging: wilc1000: update_scan_time: " Glen Lee
2015-11-19  6:56 ` [PATCH 20/26] staging: wilc1000: rename pUserVoid in is_network_in_shadow function Glen Lee
2015-11-19  6:56 ` [PATCH 21/26] staging: wilc1000: rename pUserVoid in add_network_to_shadow function Glen Lee
2015-11-19  6:56 ` [PATCH 22/26] staging: wilc1000: rename enuScanEvent in CfgScanResult function Glen Lee
2015-11-19  6:56 ` [PATCH 23/26] staging: wilc1000: rename pstrNetworkInfo " Glen Lee
2015-11-19  6:56 ` [PATCH 24/26] staging: wilc1000: rename pUserVoid " Glen Lee
2015-11-19  6:56 ` [PATCH 25/26] staging: wilc1000: rename pJoinParams " Glen Lee
2015-11-19  6:56 ` [PATCH 26/26] staging: wilc1000: rename pstrNetworkInfo in get_rssi_avg function Glen Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447916195-24851-6-git-send-email-glen.lee@atmel.com \
    --to=glen.lee@atmel.com \
    --cc=Nicolas.FERRE@atmel.com \
    --cc=adel.noureldin@atmel.com \
    --cc=adham.abozaeid@atmel.com \
    --cc=austin.shin@atmel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=leo.kim@atmel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tony.cho@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.