From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758786AbbKSPZP (ORCPT ); Thu, 19 Nov 2015 10:25:15 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:58526 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758734AbbKSPZL (ORCPT ); Thu, 19 Nov 2015 10:25:11 -0500 X-Originating-IP: 83.155.44.161 Message-ID: <1447946703.24088.73.camel@hadess.net> Subject: Re: [PATCH v11 2/8] Input: goodix - reset device at init From: Bastien Nocera To: Irina Tirdea , Dmitry Torokhov , Aleksei Mamlin , Karsten Merker , linux-input@vger.kernel.org Cc: Mark Rutland , Rob Herring , Octavian Purdila , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Date: Thu, 19 Nov 2015 16:25:03 +0100 In-Reply-To: <1447936001-21420-3-git-send-email-irina.tirdea@intel.com> References: <1447936001-21420-1-git-send-email-irina.tirdea@intel.com> <1447936001-21420-3-git-send-email-irina.tirdea@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.1 (3.18.1-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-11-19 at 14:26 +0200, Irina Tirdea wrote: > After power on, it is recommended that the driver resets the device. > The reset procedure timing is described in the datasheet and is used > at device init (before writing device configuration) and > for power management. It is a sequence of setting the interrupt > and reset pins high/low at specific timing intervals. This procedure > also includes setting the slave address to the one specified in the > ACPI/device tree. This fails on a 4.3 kernel with an ACPI device (WinBook TW100): Goodix-TS: probe of i2c-GDIX1001:00 failed with error -16 Can you please document which upstream commit is necessary to make this behave properly? I'll test again with a newer kernel. Cheers