All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dennis Kaarsemaker <dennis@kaarsemaker.net>
To: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] check-ignore: correct documentation about output
Date: Fri, 20 Nov 2015 21:29:41 +0100	[thread overview]
Message-ID: <1448051381.6899.2.camel@kaarsemaker.net> (raw)
In-Reply-To: <20151120113129.GE11198@sigill.intra.peff.net>

[Peff, sorry for the duplicate mail. It seems I can't brain today...] 

On vr, 2015-11-20 at 06:31 -0500, Jeff King wrote:
> On Sun, Nov 08, 2015 at 09:10:39PM +0100, Dennis Kaarsemaker wrote:
> 
> > By default git check-ignore shows only the filenames that will be
> > ignored, not the pattern that causes their exclusion.
> 
> Yeah, I think the described behavior is really about the "-v" output.

Yup.

> > --- a/Documentation/git-check-ignore.txt
> > +++ b/Documentation/git-check-ignore.txt
> > @@ -16,10 +16,9 @@ DESCRIPTION
> >  -----------
> >  
> >  For each pathname given via the command-line or from a file via
> > -`--stdin`, show the pattern from .gitignore (or other input files
> > to
> > -the exclude mechanism) that decides if the pathname is excluded or
> > -included.  Later patterns within a file take precedence over
> > earlier
> > -ones.
> > +`--stdin`, check whether the file is excluded by .gitignore (or
> > other
> > +input files to the exclude mechanism) and output the path if it is
> > +excluded.
> 
> This just drops the mention of patterns entirely. Is the description 
> of "-v" sufficient to cover this (especially I am thinking of the
> last-pattern-wins behavior)?

The -v should then also describe precendence rules between files. Or
maybe just link to gitignore(5).

-- 
Dennis Kaarsemaker
www.kaarsemaker.net

  reply	other threads:[~2015-11-20 20:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-08 20:10 [PATCH] check-ignore: correct documentation about output Dennis Kaarsemaker
2015-11-16 14:13 ` Dennis Kaarsemaker
2015-11-17  0:22   ` Stefan Beller
2015-11-17 22:37     ` Jeff King
2015-11-20 11:31 ` Jeff King
2015-11-20 20:29   ` Dennis Kaarsemaker [this message]
2015-11-20 20:30     ` [PATCH v2] " Dennis Kaarsemaker
2015-11-24 22:13       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448051381.6899.2.camel@kaarsemaker.net \
    --to=dennis@kaarsemaker.net \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.