From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753401AbbKWRsf (ORCPT ); Mon, 23 Nov 2015 12:48:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56481 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752114AbbKWRse (ORCPT ); Mon, 23 Nov 2015 12:48:34 -0500 Message-ID: <1448300911.4081.2.camel@redhat.com> Subject: Re: [PATCH] drm/radeon: Retry DDC probing on DVI on failure if we got an HPD interrupt From: Lyude To: "Deucher, Alexander" , "Koenig, Christian" , Daniel Stone Cc: David Airlie , dri-devel , Linux Kernel Mailing List , Jerome Glisse , Benjamin Tissoires Date: Mon, 23 Nov 2015 12:48:31 -0500 In-Reply-To: <1448293381.4081.1.camel@redhat.com> References: <1448034740-30193-1-git-send-email-cpaul@redhat.com> <56507E0F.7030009@amd.com> <56508C34.1030909@amd.com> <1448246674.26668.9.camel@redhat.com> <1448293381.4081.1.camel@redhat.com> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-11-23 at 10:43 -0500, Lyude wrote: > On Mon, 2015-11-23 at 14:20 +0000, Deucher, Alexander wrote: > > > -----Original Message----- > > > From: Lyude [mailto:cpaul@redhat.com] > > > Sent: Sunday, November 22, 2015 9:45 PM > > > To: Koenig, Christian; Daniel Stone > > > Cc: Deucher, Alexander; David Airlie; dri-devel; Linux Kernel Mailing > > > List; > > > Jerome Glisse; Benjamin Tissoires > > > Subject: Re: [PATCH] drm/radeon: Retry DDC probing on DVI on failure if we > > > got an HPD interrupt > > > > > > On Sat, 2015-11-21 at 16:22 +0100, Christian König wrote: > > > > On 21.11.2015 15:49, Daniel Stone wrote: > > > > > Hi, > > > > > > > > > > On 21 November 2015 at 14:22, Christian König > > > > .com> wrote: > > > > > > On 20.11.2015 16:52, cpaul@redhat.com wrote: > > > > > > > This is somewhat rare on most cards (depending on what angle > > > > > > > you plug > > > > > > > the DVI connector in), but on some cards it happens constantly. > > > > > > > The > > > > > > > Radeon R5 on the machine used for testing this patch for > > > > > > > instance, runs > > > > > > > into this issue just about every time I try to hotplug a DVI > > > > > > > monitor and > > > > > > > as a result hotplugging almost never works. > > > > > > > > > > > > > > Rescheduling the hotplug work for a second when we run into an > > > > > > > HPD > > > > > > > signal with a failing DDC probe usually gives enough time for > > > > > > > the rest > > > > > > > of the connector's pins to make contact, and fixes this issue. > > > > > > > > > > > > > > Signed-off-by: Stephen Chandler Paul > > > > > > > > > > > > Yeah, that's something I always wondered a about bit as well. > > > > > > > > > > > > Debouncing is something very common done in electronics, but as > > > > > > far as I > > > > > > know the HPD pins don't necessary have an RC circuit so we might > > > > > > need to > > > > > > handle this case in software here. > > > > > > > > > > > > A delay of something between 10-30ms between the last HPD > > > > > > interrupt and > > > > > > further processing of the signal doesn't sounds like such a bad > > > > > > idea. > > > Unfortunately the delay needed to make hotplugging work on the system > > > mentioned in the commit log can actually be over 700ms. > > > > > > > > > > > > Retrying on the other hand doesn't necessarily improve the > > > > > > situation cause > > > > > > the delay introduced by this might not be enough. > > > Yeah, but I would think it would make sense to retry here so long as we > > > back off after a certain time. This would also have the benefit of > > > skipping this delay on systems that don't need it. > > > > > > > > > > > > So I would rather vote for a fixed delay between an HPD interrupt > > > > > > and > > > > > > actually starting to process anything. > > > > > Yes-ish. Debouncing is useful, and ignoring buggy devices (e.g. > > > > > those > > > > > on marginal power) which send you HPD storms as well. But DP relies > > > > > on > > > > > 'short HPD' pulses which can be as brief as 2ms. So attempting to > > > > > totally debounce all HPD won't work. > > > > Well the discussion so far was about HPD on DVI only. > > > > > > > > I'm not so deep into DP, but why should it uses HPD pulses of less > > > > than 2ms? > > > This is part of the DP spec iirc. This being said though, the issue > > > here with the HPD signal coming before the connector is ready only > > > happens on DVI. I haven't ever run into this issue with any HDMI cables > > > or DP cables, so I'm against imposing this on all connectors. > > > > > > One of the solutions I've been thinking about with this: In > > > radeon_dvi_detect(), if we get a real hotplug signal retry the DDC > > > probe until at least a second has passed, after which we back off and > > > assume the port is disconnected. > > > > FWIW, there are registers to adjust how long the hpd needs to be asserted > > before the hpd connection and short pulse interrupts are triggered.  See > > DC_HPDx_CONTROL.  Maybe adjusting them would help.  We currently just write > > the default value, but it might be better to RMW the value in case there is > > a > > special golden value set by the vbios at init time. > > > This sounds like a much better idea. I'm going to try to come up with a patch > that adjusts these by default for DVI ports. Ignore this; we can't get a long enough delay using those registers to fix the issue so we'll still have to handle this in software. > > Alex > > > > > > > > > > Regards, > > > > Christian. > > > > > > > > > > > > > > Cheers, > > > > > Daniel > > > > > > > -- > > > Cheers, > > > Lyude > > -- Cheers, Lyude From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lyude Subject: Re: [PATCH] drm/radeon: Retry DDC probing on DVI on failure if we got an HPD interrupt Date: Mon, 23 Nov 2015 12:48:31 -0500 Message-ID: <1448300911.4081.2.camel@redhat.com> References: <1448034740-30193-1-git-send-email-cpaul@redhat.com> <56507E0F.7030009@amd.com> <56508C34.1030909@amd.com> <1448246674.26668.9.camel@redhat.com> <1448293381.4081.1.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4429B6E609 for ; Mon, 23 Nov 2015 09:48:34 -0800 (PST) In-Reply-To: <1448293381.4081.1.camel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Deucher, Alexander" , "Koenig, Christian" , Daniel Stone Cc: Jerome Glisse , Benjamin Tissoires , Linux Kernel Mailing List , dri-devel List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAyMDE1LTExLTIzIGF0IDEwOjQzIC0wNTAwLCBMeXVkZSB3cm90ZToKPiBPbiBNb24s IDIwMTUtMTEtMjMgYXQgMTQ6MjAgKzAwMDAsIERldWNoZXIsIEFsZXhhbmRlciB3cm90ZToKPiA+ ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+ID4gRnJvbTogTHl1ZGUgW21haWx0bzpj cGF1bEByZWRoYXQuY29tXQo+ID4gPiBTZW50OiBTdW5kYXksIE5vdmVtYmVyIDIyLCAyMDE1IDk6 NDUgUE0KPiA+ID4gVG86IEtvZW5pZywgQ2hyaXN0aWFuOyBEYW5pZWwgU3RvbmUKPiA+ID4gQ2M6 IERldWNoZXIsIEFsZXhhbmRlcjsgRGF2aWQgQWlybGllOyBkcmktZGV2ZWw7IExpbnV4IEtlcm5l bCBNYWlsaW5nCj4gPiA+IExpc3Q7Cj4gPiA+IEplcm9tZSBHbGlzc2U7IEJlbmphbWluIFRpc3Nv aXJlcwo+ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIXSBkcm0vcmFkZW9uOiBSZXRyeSBEREMgcHJv YmluZyBvbiBEVkkgb24gZmFpbHVyZSBpZiB3ZQo+ID4gPiBnb3QgYW4gSFBEIGludGVycnVwdAo+ ID4gPiAKPiA+ID4gT24gU2F0LCAyMDE1LTExLTIxIGF0IDE2OjIyICswMTAwLCBDaHJpc3RpYW4g S8O2bmlnIHdyb3RlOgo+ID4gPiA+IE9uIDIxLjExLjIwMTUgMTU6NDksIERhbmllbCBTdG9uZSB3 cm90ZToKPiA+ID4gPiA+IEhpLAo+ID4gPiA+ID4gCj4gPiA+ID4gPiBPbiAyMSBOb3ZlbWJlciAy MDE1IGF0IDE0OjIyLCBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZAo+ID4g PiA+ID4gLmNvbT4gd3JvdGU6Cj4gPiA+ID4gPiA+IE9uIDIwLjExLjIwMTUgMTY6NTIsIGNwYXVs QHJlZGhhdC5jb20gd3JvdGU6Cj4gPiA+ID4gPiA+ID4gVGhpcyBpcyBzb21ld2hhdCByYXJlIG9u IG1vc3QgY2FyZHMgKGRlcGVuZGluZyBvbiB3aGF0IGFuZ2xlCj4gPiA+ID4gPiA+ID4geW91IHBs dWcKPiA+ID4gPiA+ID4gPiB0aGUgRFZJIGNvbm5lY3RvciBpbiksIGJ1dCBvbiBzb21lIGNhcmRz IGl0IGhhcHBlbnMgY29uc3RhbnRseS4KPiA+ID4gPiA+ID4gPiBUaGUKPiA+ID4gPiA+ID4gPiBS YWRlb24gUjUgb24gdGhlIG1hY2hpbmUgdXNlZCBmb3IgdGVzdGluZyB0aGlzIHBhdGNoIGZvcgo+ ID4gPiA+ID4gPiA+IGluc3RhbmNlLCBydW5zCj4gPiA+ID4gPiA+ID4gaW50byB0aGlzIGlzc3Vl IGp1c3QgYWJvdXQgZXZlcnkgdGltZSBJIHRyeSB0byBob3RwbHVnIGEgRFZJCj4gPiA+ID4gPiA+ ID4gbW9uaXRvciBhbmQKPiA+ID4gPiA+ID4gPiBhcyBhIHJlc3VsdCBob3RwbHVnZ2luZyBhbG1v c3QgbmV2ZXIgd29ya3MuCj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gUmVzY2hlZHVsaW5n IHRoZSBob3RwbHVnIHdvcmsgZm9yIGEgc2Vjb25kIHdoZW4gd2UgcnVuIGludG8gYW4KPiA+ID4g PiA+ID4gPiBIUEQKPiA+ID4gPiA+ID4gPiBzaWduYWwgd2l0aCBhIGZhaWxpbmcgRERDIHByb2Jl IHVzdWFsbHkgZ2l2ZXMgZW5vdWdoIHRpbWUgZm9yCj4gPiA+ID4gPiA+ID4gdGhlIHJlc3QKPiA+ ID4gPiA+ID4gPiBvZiB0aGUgY29ubmVjdG9yJ3MgcGlucyB0byBtYWtlIGNvbnRhY3QsIGFuZCBm aXhlcyB0aGlzIGlzc3VlLgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IFNpZ25lZC1vZmYt Ynk6IFN0ZXBoZW4gQ2hhbmRsZXIgUGF1bCA8Y3BhdWxAcmVkaGF0LmNvbT4KPiA+ID4gPiA+ID4g Cj4gPiA+ID4gPiA+IFllYWgsIHRoYXQncyBzb21ldGhpbmcgSSBhbHdheXMgd29uZGVyZWQgYSBh Ym91dCBiaXQgYXMgd2VsbC4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IERlYm91bmNpbmcgaXMg c29tZXRoaW5nIHZlcnkgY29tbW9uIGRvbmUgaW4gZWxlY3Ryb25pY3MsIGJ1dCBhcwo+ID4gPiA+ ID4gPiBmYXIgYXMgSQo+ID4gPiA+ID4gPiBrbm93IHRoZSBIUEQgcGlucyBkb24ndCBuZWNlc3Nh cnkgaGF2ZSBhbiBSQyBjaXJjdWl0IHNvIHdlIG1pZ2h0Cj4gPiA+ID4gPiA+IG5lZWQgdG8KPiA+ ID4gPiA+ID4gaGFuZGxlIHRoaXMgY2FzZSBpbiBzb2Z0d2FyZSBoZXJlLgo+ID4gPiA+ID4gPiAK PiA+ID4gPiA+ID4gQSBkZWxheSBvZiBzb21ldGhpbmcgYmV0d2VlbiAxMC0zMG1zIGJldHdlZW4g dGhlIGxhc3QgSFBECj4gPiA+ID4gPiA+IGludGVycnVwdCBhbmQKPiA+ID4gPiA+ID4gZnVydGhl ciBwcm9jZXNzaW5nIG9mIHRoZSBzaWduYWwgZG9lc24ndCBzb3VuZHMgbGlrZSBzdWNoIGEgYmFk Cj4gPiA+ID4gPiA+IGlkZWEuCj4gPiA+IFVuZm9ydHVuYXRlbHkgdGhlIGRlbGF5IG5lZWRlZCB0 byBtYWtlIGhvdHBsdWdnaW5nIHdvcmsgb24gdGhlIHN5c3RlbQo+ID4gPiBtZW50aW9uZWQgaW4g dGhlIGNvbW1pdCBsb2cgY2FuIGFjdHVhbGx5IGJlIG92ZXIgNzAwbXMuCj4gPiA+ID4gPiA+IAo+ ID4gPiA+ID4gPiBSZXRyeWluZyBvbiB0aGUgb3RoZXIgaGFuZCBkb2Vzbid0IG5lY2Vzc2FyaWx5 IGltcHJvdmUgdGhlCj4gPiA+ID4gPiA+IHNpdHVhdGlvbiBjYXVzZQo+ID4gPiA+ID4gPiB0aGUg ZGVsYXkgaW50cm9kdWNlZCBieSB0aGlzIG1pZ2h0IG5vdCBiZSBlbm91Z2guCj4gPiA+IFllYWgs IGJ1dCBJIHdvdWxkIHRoaW5rIGl0IHdvdWxkIG1ha2Ugc2Vuc2UgdG8gcmV0cnkgaGVyZSBzbyBs b25nIGFzIHdlCj4gPiA+IGJhY2sgb2ZmIGFmdGVyIGEgY2VydGFpbiB0aW1lLiBUaGlzIHdvdWxk IGFsc28gaGF2ZSB0aGUgYmVuZWZpdCBvZgo+ID4gPiBza2lwcGluZyB0aGlzIGRlbGF5IG9uIHN5 c3RlbXMgdGhhdCBkb24ndCBuZWVkIGl0Lgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gU28gSSB3 b3VsZCByYXRoZXIgdm90ZSBmb3IgYSBmaXhlZCBkZWxheSBiZXR3ZWVuIGFuIEhQRCBpbnRlcnJ1 cHQKPiA+ID4gPiA+ID4gYW5kCj4gPiA+ID4gPiA+IGFjdHVhbGx5IHN0YXJ0aW5nIHRvIHByb2Nl c3MgYW55dGhpbmcuCj4gPiA+ID4gPiBZZXMtaXNoLiBEZWJvdW5jaW5nIGlzIHVzZWZ1bCwgYW5k IGlnbm9yaW5nIGJ1Z2d5IGRldmljZXMgKGUuZy4KPiA+ID4gPiA+IHRob3NlCj4gPiA+ID4gPiBv biBtYXJnaW5hbCBwb3dlcikgd2hpY2ggc2VuZCB5b3UgSFBEIHN0b3JtcyBhcyB3ZWxsLiBCdXQg RFAgcmVsaWVzCj4gPiA+ID4gPiBvbgo+ID4gPiA+ID4gJ3Nob3J0IEhQRCcgcHVsc2VzIHdoaWNo IGNhbiBiZSBhcyBicmllZiBhcyAybXMuIFNvIGF0dGVtcHRpbmcgdG8KPiA+ID4gPiA+IHRvdGFs bHkgZGVib3VuY2UgYWxsIEhQRCB3b24ndCB3b3JrLgo+ID4gPiA+IFdlbGwgdGhlIGRpc2N1c3Np b24gc28gZmFyIHdhcyBhYm91dCBIUEQgb24gRFZJIG9ubHkuCj4gPiA+ID4gCj4gPiA+ID4gSSdt IG5vdCBzbyBkZWVwIGludG8gRFAsIGJ1dCB3aHkgc2hvdWxkIGl0IHVzZXMgSFBEIHB1bHNlcyBv ZiBsZXNzCj4gPiA+ID4gdGhhbiAybXM/Cj4gPiA+IFRoaXMgaXMgcGFydCBvZiB0aGUgRFAgc3Bl YyBpaXJjLiBUaGlzIGJlaW5nIHNhaWQgdGhvdWdoLCB0aGUgaXNzdWUKPiA+ID4gaGVyZSB3aXRo IHRoZSBIUEQgc2lnbmFsIGNvbWluZyBiZWZvcmUgdGhlIGNvbm5lY3RvciBpcyByZWFkeSBvbmx5 Cj4gPiA+IGhhcHBlbnMgb24gRFZJLiBJIGhhdmVuJ3QgZXZlciBydW4gaW50byB0aGlzIGlzc3Vl IHdpdGggYW55IEhETUkgY2FibGVzCj4gPiA+IG9yIERQIGNhYmxlcywgc28gSSdtIGFnYWluc3Qg aW1wb3NpbmcgdGhpcyBvbiBhbGwgY29ubmVjdG9ycy4KPiA+ID4gCj4gPiA+IE9uZSBvZiB0aGUg c29sdXRpb25zIEkndmUgYmVlbiB0aGlua2luZyBhYm91dCB3aXRoIHRoaXM6IEluCj4gPiA+IHJh ZGVvbl9kdmlfZGV0ZWN0KCksIGlmIHdlIGdldCBhIHJlYWwgaG90cGx1ZyBzaWduYWwgcmV0cnkg dGhlIEREQwo+ID4gPiBwcm9iZSB1bnRpbCBhdCBsZWFzdCBhIHNlY29uZCBoYXMgcGFzc2VkLCBh ZnRlciB3aGljaCB3ZSBiYWNrIG9mZiBhbmQKPiA+ID4gYXNzdW1lIHRoZSBwb3J0IGlzIGRpc2Nv bm5lY3RlZC4KPiA+IAo+ID4gRldJVywgdGhlcmUgYXJlIHJlZ2lzdGVycyB0byBhZGp1c3QgaG93 IGxvbmcgdGhlIGhwZCBuZWVkcyB0byBiZSBhc3NlcnRlZAo+ID4gYmVmb3JlIHRoZSBocGQgY29u bmVjdGlvbiBhbmQgc2hvcnQgcHVsc2UgaW50ZXJydXB0cyBhcmUgdHJpZ2dlcmVkLsKgwqBTZWUK PiA+IERDX0hQRHhfQ09OVFJPTC7CoMKgTWF5YmUgYWRqdXN0aW5nIHRoZW0gd291bGQgaGVscC7C oMKgV2UgY3VycmVudGx5IGp1c3Qgd3JpdGUKPiA+IHRoZSBkZWZhdWx0IHZhbHVlLCBidXQgaXQg bWlnaHQgYmUgYmV0dGVyIHRvIFJNVyB0aGUgdmFsdWUgaW4gY2FzZSB0aGVyZSBpcwo+ID4gYQo+ ID4gc3BlY2lhbCBnb2xkZW4gdmFsdWUgc2V0IGJ5IHRoZSB2YmlvcyBhdCBpbml0IHRpbWUuCj4g PiAKPiBUaGlzIHNvdW5kcyBsaWtlIGEgbXVjaCBiZXR0ZXIgaWRlYS4gSSdtIGdvaW5nIHRvIHRy eSB0byBjb21lIHVwIHdpdGggYSBwYXRjaAo+IHRoYXQgYWRqdXN0cyB0aGVzZSBieSBkZWZhdWx0 IGZvciBEVkkgcG9ydHMuCgpJZ25vcmUgdGhpczsgd2UgY2FuJ3QgZ2V0IGEgbG9uZyBlbm91Z2gg ZGVsYXkgdXNpbmcgdGhvc2UgcmVnaXN0ZXJzIHRvIGZpeCB0aGUKaXNzdWUgc28gd2UnbGwgc3Rp bGwgaGF2ZSB0byBoYW5kbGUgdGhpcyBpbiBzb2Z0d2FyZS4KPiA+IEFsZXgKPiA+IAo+ID4gPiA+ IAo+ID4gPiA+IFJlZ2FyZHMsCj4gPiA+ID4gQ2hyaXN0aWFuLgo+ID4gPiA+IAo+ID4gPiA+ID4g Cj4gPiA+ID4gPiBDaGVlcnMsCj4gPiA+ID4gPiBEYW5pZWwKPiA+ID4gPiAKPiA+ID4gLS0KPiA+ ID4gQ2hlZXJzLAo+ID4gPiAJTHl1ZGUKPiA+IAotLSAKQ2hlZXJzLAoJTHl1ZGUKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==