From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1GBd-00060a-OE for qemu-devel@nongnu.org; Tue, 24 Nov 2015 11:11:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1GBa-0005o5-IZ for qemu-devel@nongnu.org; Tue, 24 Nov 2015 11:11:21 -0500 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:38626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1GBa-0005o1-C4 for qemu-devel@nongnu.org; Tue, 24 Nov 2015 11:11:18 -0500 Received: by wmec201 with SMTP id c201so33591530wme.1 for ; Tue, 24 Nov 2015 08:11:17 -0800 (PST) From: Thibaut Collet Date: Tue, 24 Nov 2015 17:10:36 +0100 Message-Id: <1448381436-32106-2-git-send-email-thibaut.collet@6wind.com> In-Reply-To: <1448381436-32106-1-git-send-email-thibaut.collet@6wind.com> References: <1448381436-32106-1-git-send-email-thibaut.collet@6wind.com> Subject: [Qemu-devel] [PATCH for-2.5 1/1] vhost-user: do not send SET_VRING_ENABLE at start List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: thibaut.collet@6wind.com, qemu-devel@nongnu.org, mst@redhat.com, jasowang@redhat.com, marcandre.lureau@gmail.com, yuanhan.liu@linux.intel.com This patch reverts partially commit 3a12f32229a. In case of live migration several queues can be enabled and not only the first one. So inform backend that only the first queue is enabled is wrong. Since commit 7263a0ad7899 backend is already notified of the state of the vring through the vring attach operation. This function, called during the startup sequence, provides the correct state of the vring, even in case of live migration. So nothing has to be added to give the vring state to the backend at the startup. Signed-off-by: Thibaut Collet --- hw/virtio/vhost.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 1794f0d..870cd12 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -1226,11 +1226,6 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev) } } - if (hdev->vhost_ops->vhost_set_vring_enable) { - /* only enable first vq pair by default */ - hdev->vhost_ops->vhost_set_vring_enable(hdev, hdev->vq_index == 0); - } - return 0; fail_log: vhost_log_put(hdev, false); -- 2.1.4