All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Cc: Jonathan Creekmore <jonathan.creekmore@gmail.com>,
	Keir Fraser <keir@xen.org>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>
Subject: Re: [PATCH] build: fix dependencies for files compiled from their parent directory
Date: Wed, 25 Nov 2015 16:26:31 +0000	[thread overview]
Message-ID: <1448468791.17688.136.camel@citrix.com> (raw)
In-Reply-To: <5655ECEA02000078000B91E0@prv-mh.provo.novell.com>

On Wed, 2015-11-25 at 09:16 -0700, Jan Beulich wrote:
> The use of $(basename ...) here was wrong (yet I'm sure I tested it).

Is the issue here that xen/arch/x86/x86_64/.compat.o.d ought really to be
xen/arch/x86/.x86_64.compat.o.d?

Otherwise xen/arch/x86/Makefile (which contains obj-y := ...
x86_64/compat.o) does not correctly track the dependencies of that file?

But that being the case I'm then confused, since it doesn't seem that the
currently wrong version is missing the .o or anything like that which is
what I would have expected the basename to be doing.

This is all in a recently built x86_64 tree (the one I used when building
before push earlier today).

> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -105,7 +105,7 @@ include Makefile
>  DEPS = .*.d
>  define gendep
>      ifneq ($(1),$(subst /,:,$(1)))
> -        DEPS += $(dir $(1)).$(basename $(notdir $(1))).d
> +        DEPS += $(dir $(1)).$(notdir $(1)).d
>      endif
>  endef
>  $(foreach o,$(filter-out %/,$(obj-y)),$(eval $(call gendep,$(o))))
> 
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2015-11-25 16:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 16:16 [PATCH] build: fix dependencies for files compiled from their parent directory Jan Beulich
2015-11-25 16:26 ` Ian Campbell [this message]
2015-11-26  7:43   ` Jan Beulich
2015-11-26  9:51     ` Ian Campbell
2015-11-26 10:38       ` Jan Beulich
2015-11-26 10:47         ` Ian Campbell
2015-11-30 16:31 ` Jonathan Creekmore
2015-11-30 16:36   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448468791.17688.136.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=jonathan.creekmore@gmail.com \
    --cc=keir@xen.org \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.