From: Ian Campbell <ian.campbell@citrix.com>
To: Juergen Gross <jgross@suse.com>, Wei Liu <wei.liu2@citrix.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com,
roger.pau@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v5 6/9] libxc: create unmapped initrd in domain builder if supported
Date: Mon, 30 Nov 2015 10:34:59 +0000 [thread overview]
Message-ID: <1448879699.15768.14.camel@citrix.com> (raw)
In-Reply-To: <565C23A6.4080707@suse.com>
On Mon, 2015-11-30 at 11:23 +0100, Juergen Gross wrote:
> On 30/11/15 11:20, Wei Liu wrote:
> > On Thu, Nov 26, 2015 at 08:35:02AM +0100, Juergen Gross wrote:
> > >
> > > /* initrd parameters as specified in start_info page */
> > > - unsigned long initrd_start;
> > > - unsigned long initrd_len;
> > > + uint64_t initrd_start;
> > > + uint64_t initrd_len;
> > >
> >
> > I think these should be of type xen_vaddr_t. Doesn't make a difference
> > in the end though.
>
> xen_vaddr_t seems not to be appropriate. It can be either a virtual
> address or a pfn.
Did you mean a virtual address or a physical _address_? Potentially mixing
addresses and frame numbers in a single variable seems liable to be
confusing, at best.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-11-30 10:34 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 13:43 [PATCH v5 0/9] libxc: support building large pv-domains Juergen Gross
2015-11-12 13:43 ` [PATCH v5 1/9] libxc: reorganize domain builder guest memory allocator Juergen Gross
2015-11-12 13:48 ` Wei Liu
2015-11-12 14:03 ` Juergen Gross
2015-11-12 14:47 ` Wei Liu
2015-11-12 14:47 ` Ian Campbell
2015-11-12 14:48 ` Wei Liu
2015-11-12 15:27 ` Juergen Gross
2015-11-12 15:55 ` Wei Liu
2015-11-13 4:41 ` Juergen Gross
2015-11-13 9:28 ` Ian Campbell
2015-11-13 11:13 ` Wei Liu
2015-11-12 13:43 ` [PATCH v5 2/9] xen: add generic flag to elf_dom_parms indicating support of unmapped initrd Juergen Gross
2015-11-12 13:43 ` [PATCH v5 3/9] libxc: rename domain builder count_pgtables to alloc_pgtables Juergen Gross
2015-11-12 13:43 ` [PATCH v5 4/9] libxc: introduce domain builder architecture specific data Juergen Gross
2015-11-12 13:43 ` [PATCH v5 5/9] libxc: use domain builder architecture private data for x86 pv domains Juergen Gross
2015-11-12 13:43 ` [PATCH v5 6/9] libxc: create unmapped initrd in domain builder if supported Juergen Gross
2015-11-25 16:12 ` Boris Ostrovsky
2015-11-25 16:18 ` Wei Liu
2015-11-25 16:24 ` Boris Ostrovsky
2015-11-25 16:29 ` Ian Campbell
2015-11-25 16:31 ` Wei Liu
2015-11-25 16:34 ` Boris Ostrovsky
2015-11-26 5:06 ` Juergen Gross
2015-11-26 5:19 ` Juergen Gross
2015-11-26 7:35 ` Juergen Gross
2015-11-30 10:20 ` Wei Liu
2015-11-30 10:23 ` Juergen Gross
2015-11-30 10:29 ` Wei Liu
2015-11-30 10:34 ` Ian Campbell [this message]
2015-11-30 10:47 ` Juergen Gross
2015-11-30 10:51 ` Ian Campbell
2015-11-30 10:52 ` Ian Campbell
2015-11-30 11:03 ` Juergen Gross
2015-11-30 11:23 ` Ian Campbell
2015-11-30 12:20 ` Juergen Gross
2015-11-30 12:35 ` Ian Campbell
2015-11-30 12:59 ` Juergen Gross
2015-11-30 13:16 ` pvgrub "Error 9: Unknown boot failure" booting Debian Jessie kernel (Was: Re: [PATCH v5 6/9] libxc: create unmapped initrd in domain builder if supported) Ian Campbell
2015-11-30 13:41 ` Ian Campbell
2015-11-30 14:10 ` Ian Campbell
2015-11-30 16:15 ` Juergen Gross
2015-11-30 16:25 ` Ian Campbell
2015-11-30 16:56 ` Ian Campbell
2015-12-01 7:15 ` Juergen Gross
2015-12-01 7:41 ` Juergen Gross
2015-12-01 8:30 ` Ian Campbell
2015-12-01 8:53 ` Juergen Gross
2015-12-01 10:01 ` Ian Campbell
2015-12-01 10:04 ` Ian Campbell
2015-12-01 10:21 ` Wei Liu
2015-12-01 10:31 ` Ian Campbell
2015-12-01 10:33 ` Wei Liu
2015-12-01 10:35 ` Ian Campbell
2015-12-01 10:47 ` Juergen Gross
2015-12-01 8:32 ` Ian Campbell
2015-12-01 11:12 ` dom builder logging from pvgrub Ian Campbell
2015-12-01 12:17 ` Samuel Thibault
2015-11-30 10:57 ` [PATCH v5 6/9] libxc: create unmapped initrd in domain builder if supported Juergen Gross
2015-11-30 18:00 ` Boris Ostrovsky
2015-11-12 13:43 ` [PATCH v5 7/9] libxc: split p2m allocation in domain builder from other magic pages Juergen Gross
2015-11-12 13:43 ` [PATCH v5 8/9] libxc: rework of domain builder's page table handler Juergen Gross
2015-11-12 13:47 ` Wei Liu
2015-11-12 13:48 ` Juergen Gross
2015-11-16 13:40 ` Ian Campbell
2015-11-16 14:32 ` Juergen Gross
2015-11-18 16:11 ` Boris Ostrovsky
2015-11-18 16:16 ` Wei Liu
2015-11-18 16:21 ` Boris Ostrovsky
2015-11-19 6:09 ` Juergen Gross
2015-11-19 13:41 ` Boris Ostrovsky
2015-11-12 13:43 ` [PATCH v5 9/9] libxc: create p2m list outside of kernel mapping if supported Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448879699.15768.14.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=roger.pau@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.